Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-9354 now.

No conversion for birthdate prior to 1970 (fix completed in vcs)

For birthdates prior to 1970, Niels Birthday MOD for phpBB2 calculates negative values.
Convertor to phpBB3 doesn't translate those negative values at all!

I joined a MODX file of the change to complete the convertor.

Comments / History

Posted by bantu (3.0 Release Manager) on Feb 7th 2008, 17:16

Hmm. I thought kellanved fixed this. Sorry for not reporting this (sooner), it must have been there since RC3 (at least).
See: http://www.phpbb.de/viewtopic.php?p=884147#884147

Posted by alf007 on Feb 7th 2008, 18:49


Sorry but i'm not fluent at all in german language ^^

Posted by bantu (3.0 Release Manager) on Feb 7th 2008, 18:58

That link was only meant as a reminder for kellanved, since he posted in this thread.

I'll translate that specific post.

--
Try this:

Open phpBB3-RC3/install/convertors/functions_phpbb20.php

Find (~ Line 453)
Code: Select all
if (!$birthday || $birthday == 999999 || $birthday 0


replace with
Code: Select all
if (!$birthday || $birthday == 999999


Regards,
bantu
--

The person posting next reported, that this fixed the problem. I'm not sure if that has always to be the case. You may want to try this, too.

Regards.

Posted by alf007 on Feb 8th 2008, 00:24

ah ok,
well i doubt that quite short fix would be enough !?

In fact i've joined in my first post a zip of a modx with the change i've made that works for me :>

Assigned ticket to user "Kellanved"

Action performed by Kellanved (Former Team Member) on Feb 13th 2008, 14:02

Changed ticket status from "New" to "Fix in progress"

Action performed by Kellanved (Former Team Member) on Feb 13th 2008, 14:03

Posted by Kellanved (Former Team Member) on Feb 13th 2008, 15:10

The problem is that PHP < 5.1 has a problem with negative arguments for gmdate() on some (Windows) systems.

Posted by bantu (3.0 Release Manager) on Feb 13th 2008, 15:36

So, on most OSes also negative values are working? Maybe you can do some OS checking. I actually see no reason why negative values have to be blocked on non-Windows systems. (Of course only when they are working.)

Posted by Kellanved (Former Team Member) on Feb 13th 2008, 15:43

I have implemented a PHP Version check. In the end, the time is better spent fixing other bugs / coding 3.1 ;) than trying to come up with elaborate support for an un-validated MOD.

Posted by bantu (3.0 Release Manager) on Feb 13th 2008, 15:45

Yes. No doubts.

Changed ticket status from "Fix in progress" to "Fix completed in SVN"

Action performed by Kellanved (Former Team Member) on Feb 13th 2008, 16:27

Linked ticket with changeset: r8379

Action performed by Kellanved (Former Team Member) on Feb 13th 2008, 16:28

Ticket details

Related SVN changesets