Bug tracker

Uninstalled mods Available Changes (fix completed in vcs)

In the AUTOMOD ACP, under Uninstalled MODs, you have the option to view details of the mod, if the mod have contrib under link-group:
Code: Select all
      <link-group>
         <link type="template" href="subsilver2.xml" lang="en">Subsilver2</link>
         <link type="contrib" href="contrib/contrib_ABBC3_v1012.xml" lang="en">Contributions</link>
      </link-group>

the template is not displayed, but contributions yes, and you can click on (Install this MOD)

The thing is ( I think ) this should not be displayed because the mod is not installed yet, but if it's right and you click on the link you will got an error :
Cannot locate File: ./../store/mods/ontrib/contrib/contrib_ABBC3_v1012.xml
( note the "ontrib" without a "c" )
In this part there are another error, the link is wrong, there are no parent_id :
Code: Select all
http://YOUR_BOARD_ADDRESS/adm/index.php?i=mods&sid=f568bf313748905af4000b6eace6e3ab&mode=frontend&action=install&parent=&mod_path=contrib%2Fcontrib_ABBC3_v1012.xml


My first impression is that the Available changes should not be displayed, and I think the solution for it is :
in root/includes/acp/acp_mods.php change this :
Code: Select all
   function handle_contrib(&$children)
   {
      global $template, $parent_id, $phpbb_root_path;

      if (isset($children['contrib']) && sizeof($children['contrib']))

with this :
Code: Select all
   function handle_contrib(&$children)
   {
      global $template, $parent_id, $phpbb_root_path;

      if ( !$parent_id )
      {
         return;
      }

      if (isset($children['contrib']) && sizeof($children['contrib']))

Comments / History

Moved ticket from project "EasyMOD" (Bug tracker) to "MOD Team Tools" (Bug tracker)

Action performed by A_Jelly_Doughnut (MOD Team Member) on May 26th 2009, 01:23

Assigned ticket to user "A_Jelly_Doughnut"

Action performed by A_Jelly_Doughnut (MOD Team Member) on May 29th 2009, 20:36

Changed ticket status from "New" to "Reviewed"

Action performed by A_Jelly_Doughnut (MOD Team Member) on May 29th 2009, 20:36

Changed ticket status from "Reviewed" to "Fix in progress"

Action performed by A_Jelly_Doughnut (MOD Team Member) on May 30th 2009, 20:21

Posted by leviatan21 on May 30th 2009, 21:09

Thanks !

Changed ticket status from "Fix in progress" to "Fix completed in SVN"

Action performed by A_Jelly_Doughnut (MOD Team Member) on Jun 10th 2009, 04:04

Ticket details