Bug tracker

MODs install twice when applied to custom style with Forced Install (fix completed in vcs)

This appears to happen when you use the function "Apply these changes ___ to ___", under Available Changes in MOD Details.

I am using a different skin, and ran the changes for proSilver on my proSilver-based custom skin. The mod was mChat. AutoMOD reported there was one change it couldn't find, that of adding the mChat link to the menu bar. Since it was only cosmetic and I could manually do it later, I clicked Force Install. This is when I noticed the first discrepancy. In the actions completed list, it said the menu bar change had been successful, whereas the editor.js change had failed. I looked at my custom skin's editor.js, but it did have the changes made successfully while the menu bar did not have the mChat link. Scratching my head, I figured all was well.

When I looked at the proSilver skin, I discovered it had two mChat windows and two mChat links in the menu bar. It had installed twice! The reason editor.js failed was because the first install changed the code it had to find, so it couldn't find the same location again.

I checked Index.php to see if it also duplicated the changes made to the base forum system, and found that it did.

Comments / History

Assigned ticket to user "A_Jelly_Doughnut"

Action performed by A_Jelly_Doughnut (MOD Team Member) on Jan 26th 2010, 16:19

Changed ticket status from "New" to "Fix in progress"

Action performed by A_Jelly_Doughnut (MOD Team Member) on Jan 28th 2010, 04:20

Marked ticket #57225 as duplicate of this ticket

Action performed by A_Jelly_Doughnut (MOD Team Member) on Jan 31st 2010, 19:01

Posted by VSE on Feb 8th 2010, 05:33

I can verify this bug. I installed a Mod, then went to "Details" to apply the prosilver edits to my other style.

First it wanted to re-do the SQL, which flagged an error because they were already done the first time around. So you had to choose Force Install.

Then everything went berserk and that is when I noticed all the file edits to php files had also been redone, doubling the install and causing all sorts of mayhem!

Marked ticket #57465 as duplicate of this ticket

Action performed by A_Jelly_Doughnut (MOD Team Member) on Feb 8th 2010, 17:58

Posted by A_Jelly_Doughnut (MOD Team Member) on Feb 8th 2010, 17:59

Just to confirm my suspicion: you're using the FTP write method (check in AutoMOD Configuration)

Posted by VSE on Feb 12th 2010, 00:16

I use the Direct method.

Linked ticket with changeset: r227

Action performed by A_Jelly_Doughnut (MOD Team Member) on Feb 14th 2010, 00:27

Changed ticket status from "Fix in progress" to "Fix completed in SVN"

Action performed by A_Jelly_Doughnut (MOD Team Member) on Feb 14th 2010, 00:32

Posted by A_Jelly_Doughnut (MOD Team Member) on Feb 14th 2010, 00:32

I'm not sure that I was ever able to properly reproduce this error, because un-doing the fix I committed and trying to produce it with the direct write method does not produce any wrong behavior for me.

I was however able to reproduce it with FTP, and that is now fixed in SVN r227.

VSE, if you are able to use SVN and can still reproduce this error, please let me know.

Ticket details

Duplicates of this ticket

Related SVN changesets