Linked ticket with changeset: r243
Action performed by A_Jelly_Doughnut (MOD Team Member) on Apr 30th 2010, 14:40
upload_mod function in acp_mods.php is missing global $config declaration. As a result, when store/mods is deleted, upload_mod creates it with 0000 permissions here:
mkdir($this->mods_dir, octdec($config['am_dir_perms']));
which fails the upload and generally renders the store/mods directory unusable.
To reproduce the issue, rm -rf store/* and try to upload a mod.
Patch fixing this problem is attached.
Additionally it is perhaps not a bad idea to sanity check file/directory modes before using them. A null/0 mode is never useful.