Bug tracker
Mass Email not working (fix completed in vcs)
Here is one of many links on the subject: viewtopic.php?f=46&t=1356535
Are you aware of this and if so is it in the pipeline to be fixed?
Cheers, Mix
Comments / History
(bulk)mails are not beeing send, although phpBB3 says it succesfully send the mail, no mails get to the receivers. This is for bulk mails and foor notification mails.
Mails send during new user registrations ARE send an DO get to the receiver.
Myforum is a fresh install with converted data from a 2.0.22
I found out that blank jabber fields in the user profiles are causing trouble when sending bulk mails.
It's caused by line 125 of /includes/acp/acp_email.php
This is the line:
- Code: Select all
($row['user_notify_type'] == NOTIFY_BOTH && $row['user_email'] && $row['user_jabber']))
There can be two things.
1) user_notify_type is set to 2 while it should be set to 0
or
2) && $row['user_jabber'] should be something else.
Hopefully this helps to pinpoint the exact problem.
I removed the && $row['user_jabber'] as a work around because jabber is disabled in my forum.
This did the trick for me.... as a work around!!
but apart from that.... notification mails still fail.
registration mail is still send correctly.
Does this info help to pinpoint a possible cause?
- Code: Select all
if (!$config['jab_enable'] || !$data['jabber'] || !@extension_loaded('xml'))
{
// User has not filled in a jabber address (Or one of the modules is disabled or jabber is disabled)
// Disable notify by Jabber now for this user.
$data['notify'] = NOTIFY_BOTH;
}
So if the user has not filled in a jabber address when updating his profile, the user_notify_status will be set to NOTIFY_BOTH, which in turn excludes the user from mass emails. And there is no way for the user to change it back to NOTIFY_EMAIL because the corresponding options in ucp_prefs_personal.html are (of course) disabled without a jabber address in the profile.
-> marked as severe
NOTIFY_BOTH should, as far I know, just send out the email, even in case its empty.
EDIT: Nvm, comment isnt needed regarding this bug. its in acp_mail.
Registration mails: Succes
Notification mails: Succes *1
Mass mail: Fail
note:
*1 Notification mails DO work. Previously I was sending myself a PM and no mail was received. But when I send PM to someone else, I DO receive a notification. So this looks like expected behaviour.
Bottom line:
Only Mass mail (acp_email.php:124) has a problem.
I have jabber disabled and a blank jabber adres, but $row['user_notify_type'] is set to NOTIFY_BOTH (2) while I expect $row['user_notify_type'] to be NOTIFY_EMAIL (0)
Am I right?
At least it's retrieved from the user table. So it is set to NOTIFY_BOTH (2) at an earlier moment.
A user has user_notify_type initialy set to 0 (also when phpbb2 is converted to phpbb3)
Then when a jabber adress is set by a user, the user_notify_type for this user is set to 2
But.... when the jabber adress is removed again (is set to blank) the user_notify_type remains 2. Which I think is not correct. (via UCP)
When I manualy set the user_notify_type back to 0 again, the mass mailer works fine.
When playing around with the jabber adres via ACP the user_notify_type doens't get changed at all. So there is an inconsistancy at this point that has effect on the way the mass mailer works.
Maybe its helpfull to review ucp_profile.php:352-357
And rethink about ! and ||.
Should all the ! be removed? And how about changing || into &&
Hope this helps you Acyd Burn
Thanks,
Mix
Mass E-Mails are a very important feature, i think.
Best Regards,
Trash-Master