phpBB • Free and Open Source Forum Software

For bots or users who don’t have permission to view profiles, it doesn’t make much sense to allow the links to exist to go to the viewprofile pages.
But also, it is possible to give Guests permission to view profiles, but in reality that’s impossible since it’s restricted from Guests hardcoded into the function.
This would be my suggestion: (in get_username_string() function)

Code: Select all: if ($user_id && $auth->acl_get('u_viewprofile')) // globalize $auth { … } else

Or at least...

Code: Select all: if ($user_id && $user_id != ANONYMOUS && !$user->data['is_bot']) { … } else

So the links won’t show unnecessarily for spiders and bots.

Um...Not really sure what you're getting at HoL.

The code in get_username_string() checks if the poster (or other use of get_username_string()) is a guest, not if the user trying to view the topic is a guest. Note the user of $user_id instead of $user->data['user_id']

You are right... never report bugs late at night.

Anyways, the original point of the bug report is the fact that it’s useless to have links to member’s profiles if the user viewing does not have permission to see it... thus the $auth->acl_get('u_viewprofile').
The same goes for bots... they don’t have permission (by default) to the memberlist/profiles, so having hundreds of links all over the board going there does not make sense... to the bot they are dead.
The alternative was to change it in the templates