phpBB • Free and Open Source Forum Software

RSS Facebook Twitter

Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-139 now.

Bot-IP is not checked (fix completed in vcs)

When altering the browser-tag, you're always welcomed as Googlebot (if you changed the tag to googlebot's) - it does not matter which IP you have.
For example at my localhost, I have 127.0.0.1 and the software greeted my with "Logout [ Googlebot ]".

Furthermore, in ACP -> Bot-Settings you are told to seperate IPs with an apostrophe. But if you do so, you'll receive an error while saving that settings.
>> The IP addresses you supplied were invalid or the hostname could not be resolved.

Comments / History

Posted by Acyd Burn (Server Manager) on Mar 25th 2006, 12:34

When altering the browser-tag, you're always welcomed as Googlebot (if you changed the tag to googlebot's) - it does not matter which IP you have.
For example at my localhost, I have 127.0.0.1 and the software greeted my with "Logout [ Googlebot ]".


If you did not enter an IP for the googlebot this is the expected behaviour. Smile

I changed the CVS to additionally check the IP address (instead of using it only if the agent string has not been supplied). The language string was wrong too, the seperator is a comma instead of an apostrophe. Smile

Linked ticket with changeset: r5710

Action performed by Anonymous (I am too lazy to register) on Mar 25th 2006, 12:35

Posted by rellek on Mar 25th 2006, 14:00

So, the old behaviour was that you EITHER enter a browser-tag OR an IP? Okay, but by default, both is set (default values were Agent match: "Googlebot/" and IPs: "216.239.46.,64.68.8" - so it'd be better if both is checked (as you wrote that it is now)...

I'll try to download an updated CVS-Version and check if it's okay now, just a moment...

Posted by rellek on Mar 25th 2006, 14:10

Okay, i have downloaded a CVS-Version 5 minutes ago and now I received another error-message at the to of the installation:
>> Notice: Trying to get property of non-object in D:\xampp\htdocs\x-phpbb\includes\template.php on line 207

Also, it's not so nice, that you are kicked to the "old" installer-page after entering mysql-data - especially that server-information is not filled in as it used to be...

But that is not the fact in this bug, so back to google-bot-identification:
It's okay now - when I delete IPs from the list, I'm identified as googlebot and if I re-enter them I'm logged in as usual - thanks Smile

Ticket details

  • Ticket ID: 1213
  • Project: phpBB 3.0.x
  • Status: Fix completed in VCS
  • Severity: Uncategorised/normal
  • Component: Sessions
  • Project version: 3.0.x SVN
  • PHP version: Unknown
  • Database: Unknown
  • Assigned to: Acyd Burn
  • Reported by: rellek (Send PM)
  • Reporter's tickets: List all tickets
  • Reported on: Mar 21st 2006, 11:51

Related SVN changesets

Advertisements

 BlueHost.com • Web Hosting UK • HostMonster • Reseller Web Hosting UK • FastDomain Hosting • Advertise on phpBB.com