Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-255 now.

Globalized Flood Control (fix completed in vcs)

When searching there is a flood control in place, However this is globalized via $config and will effect other users overall.

Search.php
Code: Select all
// Check last search time ... if applicable
if ($config['search_interval'])
{
   if ($config['last_search_time'] > time() - $config['search_interval'])
   {
      trigger_error($user->lang['NO_SEARCH_TIME']);
   }
}


This needs to be session based like the fix that was applied to phpBB 2.0.X CVS (.20)

Comments / History

Linked ticket with changeset: r3525

Action performed by Anonymous (I am too lazy to register) on Feb 25th 2003, 16:03

Posted by Acyd Burn (Server Manager) on Mar 27th 2006, 13:33

this is intended as far as i know. This is a global search interval applied to all users.

Though it has to be communicated this way at the ACP settings page

Posted by ShadyCrazy (I've Been Banned!) on Mar 27th 2006, 13:55

Wont this effect users that are just searching normally when another user just searched tho... imo it would be better to just have it apply on a per-user basic like the patch in 2.0.20 (CVS)

Posted by naderman (Development Team Leader) on Mar 27th 2006, 19:33

We will change it to something similar to 2.0.x

Posted by DKing on Mar 30th 2006, 08:45

Yeah, because if it's set into config, and one user searched, say, five seconds ago, and I go to search, it will give me the flood limit error because the other person just searched. So it needs to go on the session/cookie side rather than database. Unless you want to update the database with a last_search_time field for each user and just change that everytime the user searches...

Linked ticket with changeset: r5981

Action performed by naderman (Development Team Leader) on May 28th 2006, 19:06

Ticket details

Related SVN changesets