Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-6759 now.

Pruning users by last activity takes later joined users which had never activity (fix completed in vcs)

ACP/Prune users, set prune by Last activity. You'll be suggested to prune users which have registered later than last activity time you set but they never visited your board yet.

Shouldn't it take just users joined before the last activity date you've set?

Comments / History

Posted by ProTON (Translator) on Jan 6th 2008, 19:24

I stumbled on this problem too.

Assigned ticket to user "APTX"

Action performed by Acyd Burn (Server Manager) on Jan 30th 2008, 15:29

Posted by Acyd Burn (Server Manager) on Mar 18th 2008, 10:12

Did you select to prune by last activity before the date you set?

Posted by rxu (Development Team Member) on Mar 18th 2008, 13:27

Did you select to prune by last activity before the date you set?

Yes.
This bug affects users which have registered but didn't logged in yet at all. In other words, these users have user_lastvisit = 0.

Posted by rxu (Development Team Member) on Mar 18th 2008, 14:44

I guess the one of the ways it could be fixed is the following edit of includes/acp/acp_prune.php:
Code: Select all
408c408
<          $where_sql .= (sizeof($active)) ? " AND user_lastvisit > 0 AND user_lastvisit " . $key_match[$active_select] . " " . gmmktime(0, 0, 0, (int) $active[1], (int) $active[2], (int) $active[0]) : '';
---
>          $where_sql .= (sizeof($active)) ? " AND user_lastvisit " . $key_match[$active_select] . " " . gmmktime(0, 0, 0, (int) $active[1], (int) $active[2], (int) $active[0]) : '';

Posted by Acyd Burn (Server Manager) on Mar 21st 2008, 10:45

The other way around, but yes, this is what i have done here. ;)

Changed ticket status from "New" to "Fix completed in SVN"

Action performed by Acyd Burn (Server Manager) on Mar 21st 2008, 10:46

Linked ticket with changeset: r8453

Action performed by Anonymous (I am too lazy to register) on Mar 21st 2008, 10:47

Ticket details

Related SVN changesets