Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-6781 now.

Sync fails when moving all of a user's posts (fix completed in vcs)

From includes/acp/acp_users.php, near line 630
Code: Select all
                     $forum_id_ary = array_unique($forum_id_ary);
                     $topic_id_ary = array_unique(array_merge($topic_id_ary, $new_topic_id_ary));


                     if (sizeof($topic_id_ary))
                     {
                        sync('reported', 'topic_id', $topic_id_ary);
                        sync('topic', 'topic_id', $topic_id_ary);
                     }

The problem here: sync() works on the topic IDs in the array values, but here the topic IDs are in the keys. The forum ID sync is fine, AFAIK.

Simply add an array_keys to $topic_id_ary :)

Comments / History

Posted by iyeru42 on Jan 1st 2008, 16:19

Is this related to crazy loop's posts? Because I noticed I can't read an unread topic because of posts removed, yet it doesn't show that way on the topic list. -_-

See Attachment. Here's the topic too.

Posted by iyeru42 on Jan 1st 2008, 16:20

Man, forgot you had to hit "Add Attachment."

Posted by A_Jelly_Doughnut (Former Team Member) on Jan 1st 2008, 16:28

Yes, that is how this bug was identified.

Assigned ticket to user "Acyd Burn"

Action performed by Acyd Burn (Server Manager) on Jan 6th 2008, 14:59

Posted by Acyd Burn (Server Manager) on Jan 6th 2008, 15:12

hmm, the array_merge is wrong too then, since the new_topic_id_array is indeed using the values - whereby the topic_id_array using keys. :o

Changed ticket status from "New" to "Fix in progress"

Action performed by Acyd Burn (Server Manager) on Jan 6th 2008, 15:20

Changed ticket status from "Fix in progress" to "Fix completed in CVS"

Action performed by Acyd Burn (Server Manager) on Jan 6th 2008, 17:03

Ticket details