Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-779 now.

Change poster (fix completed in vcs)

When changing a poster of a post, and you type in a name, and press confirm to that button, the user thats selected in the selectbox is the new user, and not the user thats typed in.

Comments / History

Posted by Highway of Life (QA Team) on Jun 11th 2006, 13:27

I just tested this and it seems to work fine, but I'm sure a Dev will have a look at it.

The intended function is, for example:
username1 posted

Changing post author to username2,
username1 should now be in the drop menu list. And username2 is the new post author.

To restore the post author back to username1 click confirm on the drop menu.

Posted by Highway of Life (QA Team) on Jun 11th 2006, 16:40

Hey Paul,
After you update the CVS, if you already did... can you double check this one?
It seems to be working fine for me. Smile

Posted by Paul (MOD Team Member) on Jun 11th 2006, 16:50

tested on newest cvs:
If no dropdown box, and you try to change it, it is changed.
If there is a downdown box, and you try to change it, it is changed to the selected user in the dropdown, and the user typed in ISN'T displayed in dropdown.

Dropdown is only displayed if another user has posted with the same IP(So far I can test).

Posted by Highway of Life (QA Team) on Jun 14th 2006, 03:35

Well, you are right paul!

Brand new June 14th snapshot with a clean database.
I do remember encountering that error some time ago.
If the user is in the drop-down menu, then typing in a user will do no good when the form is submitted. It will always choose the top poster in the drop menu.

However, I found a very simple fix, though I think Meik can gleam a better function fix off of this.

in styles/subSilver/template/mcp_post.html
line 93-100

Change this:
Code: Select all
<span class="syntaxdefault"><?php&nbsp;</span><span class="syntaxkeyword"><!--&nbsp;IF&nbsp;</span><span class="syntaxdefault">S_CAN_CHGPOSTER&nbsp;</span><span class="syntaxkeyword">--><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<</span><span class="syntaxdefault">tr</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<</span><span class="syntaxdefault">form&nbsp;method</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"post"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"mcp_chgposter"&nbsp;</span><span class="syntaxdefault">action</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"{U_POST_ACTION}"</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<</span><span class="syntaxdefault">td&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"row1"&nbsp;</span><span class="syntaxdefault">valign</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"top"</span><span class="syntaxkeyword">><</span><span class="syntaxdefault">b&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"gen"</span><span class="syntaxkeyword">>{</span><span class="syntaxdefault">L_CHANGE_POSTER</span><span class="syntaxkeyword">}</</span><span class="syntaxdefault">b</span><span class="syntaxkeyword">></</span><span class="syntaxdefault">td</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<</span><span class="syntaxdefault">td&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"row2"</span><span class="syntaxkeyword">><</span><span class="syntaxdefault">input&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"post"&nbsp;</span><span class="syntaxdefault">type</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"text"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"username"&nbsp;</span><span class="syntaxdefault">value</span><span class="syntaxkeyword">=</span><span class="syntaxstring">""&nbsp;</span><span class="syntaxkeyword">/>&nbsp;<</span><span class="syntaxdefault">input&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"btnmain"&nbsp;</span><span class="syntaxdefault">type</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"submit"&nbsp;</span><span class="syntaxdefault">value</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"{L_CONFIRM}"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"action&#91;chgposter&#93;"&nbsp;</span><span class="syntaxkeyword">/><</span><span class="syntaxdefault">br&nbsp;</span><span class="syntaxkeyword">/><</span><span class="syntaxdefault">span&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"gensmall"</span><span class="syntaxkeyword">>&#91;&nbsp;<</span><span class="syntaxdefault">a&nbsp;href</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"{U_FIND_MEMBER}"&nbsp;</span><span class="syntaxdefault">onclick</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"window&#46;open('{U_FIND_MEMBER}',&nbsp;'_phpbbsearch',&nbsp;'HEIGHT=500,resizable=yes,scrollbars=yes,WIDTH=740');return&nbsp;false;"</span><span class="syntaxkeyword">>{</span><span class="syntaxdefault">L_FIND_USERNAME</span><span class="syntaxkeyword">}</</span><span class="syntaxdefault">a</span><span class="syntaxkeyword">>&nbsp;&#93;</</span><span class="syntaxdefault">span</span><span class="syntaxkeyword">><!--&nbsp;IF&nbsp;</span><span class="syntaxdefault">S_USER_SELECT&nbsp;</span><span class="syntaxkeyword">--><</span><span class="syntaxdefault">br&nbsp;</span><span class="syntaxkeyword">/><</span><span class="syntaxdefault">select&nbsp;name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"u"</span><span class="syntaxkeyword">>{</span><span class="syntaxdefault">S_USER_SELECT</span><span class="syntaxkeyword">}</</span><span class="syntaxdefault">select</span><span class="syntaxkeyword">>&nbsp;<</span><span class="syntaxdefault">input&nbsp;type</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"submit"&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"btnmain"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"action&#91;chgposter_ip&#93;"&nbsp;</span><span class="syntaxdefault">value</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"{L_CONFIRM}"&nbsp;</span><span class="syntaxkeyword">/><!--&nbsp;ENDIF&nbsp;--></</span><span class="syntaxdefault">td</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</</span><span class="syntaxdefault">form</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</</span><span class="syntaxdefault">tr</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<!--&nbsp;ENDIF&nbsp;--></span>



To this:
Code: Select all
<span class="syntaxdefault"><?php&nbsp;<br /></span><span class="syntaxkeyword"><!--&nbsp;IF&nbsp;</span><span class="syntaxdefault">S_CAN_CHGPOSTER&nbsp;</span><span class="syntaxkeyword">--><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<</span><span class="syntaxdefault">tr</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<</span><span class="syntaxdefault">td&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"row1"&nbsp;</span><span class="syntaxdefault">valign</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"top"</span><span class="syntaxkeyword">><</span><span class="syntaxdefault">b&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"gen"</span><span class="syntaxkeyword">>{</span><span class="syntaxdefault">L_CHANGE_POSTER</span><span class="syntaxkeyword">}</</span><span class="syntaxdefault">b</span><span class="syntaxkeyword">></</span><span class="syntaxdefault">td</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<</span><span class="syntaxdefault">td&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"row2"</span><span class="syntaxkeyword">><</span><span class="syntaxdefault">form&nbsp;method</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"post"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"mcp_chgposter"&nbsp;</span><span class="syntaxdefault">action</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"{U_POST_ACTION}"</span><span class="syntaxkeyword">><</span><span class="syntaxdefault">input&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"post"&nbsp;</span><span class="syntaxdefault">type</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"text"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"username"&nbsp;</span><span class="syntaxdefault">value</span><span class="syntaxkeyword">=</span><span class="syntaxstring">""&nbsp;</span><span class="syntaxkeyword">/>&nbsp;<</span><span class="syntaxdefault">input&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"btnmain"&nbsp;</span><span class="syntaxdefault">type</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"submit"&nbsp;</span><span class="syntaxdefault">value</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"{L_CONFIRM}"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"action&#91;chgposter&#93;"&nbsp;</span><span class="syntaxkeyword">/><</span><span class="syntaxdefault">br&nbsp;</span><span class="syntaxkeyword">/><</span><span class="syntaxdefault">span&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"gensmall"</span><span class="syntaxkeyword">>&#91;&nbsp;<</span><span class="syntaxdefault">a&nbsp;href</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"{U_FIND_MEMBER}"&nbsp;</span><span class="syntaxdefault">onclick</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"window&#46;open('{U_FIND_MEMBER}',&nbsp;'_phpbbsearch',&nbsp;'HEIGHT=500,resizable=yes,scrollbars=yes,WIDTH=740');return&nbsp;false;"</span><span class="syntaxkeyword">>{</span><span class="syntaxdefault">L_FIND_USERNAME</span><span class="syntaxkeyword">}</</span><span class="syntaxdefault">a</span><span class="syntaxkeyword">>&nbsp;&#93;</</span><span class="syntaxdefault">span</span><span class="syntaxkeyword">></</span><span class="syntaxdefault">form</span><span class="syntaxkeyword">><!--&nbsp;IF&nbsp;</span><span class="syntaxdefault">S_USER_SELECT&nbsp;</span><span class="syntaxkeyword">--><</span><span class="syntaxdefault">br&nbsp;</span><span class="syntaxkeyword">/><</span><span class="syntaxdefault">form&nbsp;method</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"post"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"mcp_chgposter"&nbsp;</span><span class="syntaxdefault">action</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"U_POST_ACTION"</span><span class="syntaxkeyword">><</span><span class="syntaxdefault">select&nbsp;name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"u"</span><span class="syntaxkeyword">>{</span><span class="syntaxdefault">S_USER_SELECT</span><span class="syntaxkeyword">}</</span><span class="syntaxdefault">select</span><span class="syntaxkeyword">>&nbsp;<</span><span class="syntaxdefault">input&nbsp;type</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"submit"&nbsp;</span><span class="syntaxkeyword">class=</span><span class="syntaxstring">"btnmain"&nbsp;</span><span class="syntaxdefault">name</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"action&#91;chgposter_ip&#93;"&nbsp;</span><span class="syntaxdefault">value</span><span class="syntaxkeyword">=</span><span class="syntaxstring">"{L_CONFIRM}"&nbsp;</span><span class="syntaxkeyword">/><!--&nbsp;ENDIF&nbsp;--></</span><span class="syntaxdefault">form</span><span class="syntaxkeyword">></</span><span class="syntaxdefault">td</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</</span><span class="syntaxdefault">tr</span><span class="syntaxkeyword">><br />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<!--&nbsp;ENDIF&nbsp;--></span>


Basically creating a seperate form for each field will let each one post it's own contents.

Posted by Highway of Life (QA Team) on Jun 14th 2006, 03:35

Woops, sorry for the long scroll.
Forgot to add the code returns in there.

Linked ticket with changeset: r6063

Action performed by naderman (Development Team Leader) on Jun 14th 2006, 18:59

Ticket details

Related SVN changesets