Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-819 now.

sql statement mistake (fix completed in vcs)

in viewtopic.php, the following line appears:
Code: Select all
$sql = 'SELECT COUNT(p.post_id) AS prev_posts
      FROM ' . POSTS_TABLE . " p
      WHERE p.post_approved = 1
         AND p.topic_id = {$topic_data['topic_id']}
         " . ((!$auth->acl_get('m_approve', $forum_id)) ? 'AND p.post_approved = 1' : '') . "
         AND " . (($sort_dir == 'd') ?  "p.post_id >= $post_id" : "p.post_id <= $post_id");

Comments / History

Posted by Acyd Burn (Server Manager) on Jun 14th 2006, 22:04

And? a perfectly valid query if you ask me.

Posted by naderman (Development Team Leader) on Jun 15th 2006, 09:47

The post_approved part doesn't look very correct Wink

Posted by Acyd Burn (Server Manager) on Jun 15th 2006, 12:39

OMG, now i see it... the p.post_approved = 1 directly after the where clause...

Linked ticket with changeset: r6068

Action performed by Anonymous (I am too lazy to register) on Jun 15th 2006, 14:59

Ticket details

Related SVN changesets