Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-7052 now.

User Login Form returns General Error Page when submitting wilth NULL fields (fix completed in vcs)

Hi -- when logging in with the Login Form on the Board Index Page, you get the General Error Message page (instead of the normal login page with an error message), when you submit the form without BOTH the USERNAME and PASSWORD fields filled in.

This didn't seem to happen on earlier phpbb3 RC releases, but does so now on the GOLD release...you can see what I mean by doing this (submit blank login form), on this website's forum login too.

I'm sure it's a small fix, and would be nice to have it not do this anymore as it looks buggy and gives a bad User Experience.

Cheers for everything! Oz

Comments / History

Posted by lennort on Mar 9th 2008, 16:43

It seems to happen anytime you don't provide a password. So you can enter only a username and still get the general error.

Posted by lennort on Mar 10th 2008, 04:29

Alright, here is the solution I found. I can't find anything that says how I should submit a patch, so I'll just show what I changed.

In the files includes/auth/auth_apache, auth_db, and auth_ldap :


if (!$password)
{
return array(
'status' => LOGIN_BREAK,
'error_msg' => 'NO_PASSWORD_SUPPLIED',
);
}

change LOGIN_BREAK to LOGIN_ERROR_PASSWORD. this will pull up the regular login dialog box instead of the general error screen.

I suspect there was some reason for doing this originally however.

Assigned ticket to user "Acyd Burn"

Action performed by Acyd Burn (Server Manager) on Mar 14th 2008, 12:27

Linked ticket with changeset: r8432

Action performed by Anonymous (I am too lazy to register) on Mar 14th 2008, 12:28

Changed ticket status from "New" to "Fix completed in SVN"

Action performed by Acyd Burn (Server Manager) on Mar 14th 2008, 12:28

Ticket details

Related SVN changesets