Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-7060 now.

Can't close report in MCP - error in prosilver template (fix completed in vcs)

Moderator Control Panel -> Reported posts -> Open reports -> click any report, then 'Close report' button.

Prosilver template has:
<form method="post" id="mcp_report" action="{U_CLOSE_ACTION}">

but no U_CLOSE_ACTION is defined in mcp.php, should be:
<form method="post" id="mcp_report" action="{S_CLOSE_ACTION}">

file: styles/prosilver/template/mcp_post.html

But: still error - the report isn't closed, so seems S_CLOSE_ACTION url is also broken.

Comments / History

Posted by ToonArmy (Development Team Member) on Mar 8th 2008, 04:53

The rendered markup is
Code: Select all
<form method="post" id="mcp_report" action="">
which is indeed wrong.

Seems that the a line is missing in includes/mcp/mcp_post.php around this lot:
Code: Select all
      'U_MCP_ACTION'         => "$url&amp;i=main&amp;quickmod=1", // Use this for mode paramaters
      'U_POST_ACTION'         => "$url&amp;i=$id&amp;mode=post_details", // Use this for action parameters
      'U_APPROVE_ACTION'      => append_sid("{$phpbb_root_path}mcp.$phpEx", "i=queue&amp;p=$post_id&amp;f={$post_info['forum_id']}"),

Posted by ToonArmy (Development Team Member) on Mar 8th 2008, 04:56

My bad, seems as though the problem is actually in includes/mcp/mcp_reports.php

I have found this line:
Code: Select all
'S_CLOSE_ACTION'      => $this->u_action . '&amp;p=' . $post_id . '&amp;f=' . $forum_id,

Linked ticket with changeset: r8430

Action performed by Anonymous (I am too lazy to register) on Mar 13th 2008, 15:22

Assigned ticket to user "Acyd Burn"

Action performed by Acyd Burn (Server Manager) on Mar 13th 2008, 15:23

Changed ticket status from "New" to "Fix completed in SVN"

Action performed by Acyd Burn (Server Manager) on Mar 13th 2008, 15:23

Ticket details

Related SVN changesets