Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-1242 now.

Wrong carriage return replacement (fix completed in vcs)

This is a simple bug that I noticed just going through the commit logs. From what I can tell (and I haven't actually tested it), the code in revision 1.31 of includes/acp/acp_styles.php attempts to replace "\n\r" and "\r" with "\n", but that will not work as expected. The reason is that the Windows newline (which I presume is what was supposed to be represented) is actually "\r\n", not "\n\r".

So, the bottom line is, throughout that file (and possibly others), "\n\r" should probably be replaced with "\r\n".

Comments / History

Posted by naderman (Development Team Leader) on Jul 10th 2006, 15:48

Oh my, I'm just stupid Smile

Thanks for that Wink

Linked ticket with changeset: r6175

Action performed by naderman (Development Team Leader) on Jul 12th 2006, 23:21

Ticket details

Related SVN changesets