Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-7583 now.

Selected posts not retained when there is a problem (fix completed in vcs)

When not all information is supplied to perform an action in the MCP, any post selection made is lost. For example, when planning to split certain posts from a topic, and selecting those posts, but failing to supply a title for the new topic, the board will (of course) display an error notice when trying to perform the action and not perform the action. The post selection is reset to all posts in the view selected.

This is true for splitting from selected post, splitting selected posts, and merging selected posts to a different topic (in case no target topic was supplied).

A moderator might end up moving more posts than intended. Possible solutions are to make the default to be all posts unselected (the moderator will get a notice to select posts) or preferably, to retain the post selection.
will have been reset to is going to split a topic, and making a selection of posts to split (or split from), but failing to supply a title for the new topic, the board will (rightly) complain a topic needs to be selected.

However, the selection of posts that was made has been lost. If the moderator does not notice this, he/she may end up splitting more posts than planned, because the default of the view is for all posts to be selected.

I presume the

Comments / History

Posted by blueray2048 on Jul 28th 2008, 05:49

Yes, remember what's selected is good.
But, it seems won't be implemented yet
and I use this,

open includes/mcp/mcp_topic.php

FIND
Code: Select all

            
'S_CHECKED'            => ($post_id_list && in_array(intval($row['post_id']), $post_id_list)) ? true false,
 


REPLACE WITH
Code: Select all

            
'S_CHECKED'            => ($post_id_list && in_array(intval($row['post_id']), $post_id_list)) ? false false,
 


I use it on private forum only :)

Posted by Eelke (QA Team) on Jul 28th 2008, 06:30

Sorry, my initial bug report seems to have missed one last going over, there's parts of previous iterations left :)

What do you mean, seems like it won't be implemented? Is this a duplicate of another bug report? I did search the bug tracker before submitting.

Assigned ticket to user "Kellanved"

Action performed by Kellanved (Former Team Member) on Jul 28th 2008, 13:39

Linked ticket with changeset: r8702

Action performed by Kellanved (Former Team Member) on Jul 28th 2008, 16:44

Changed ticket status from "New" to "Fix completed in SVN"

Action performed by Kellanved (Former Team Member) on Jul 28th 2008, 16:44

Ticket details

Related SVN changesets