Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-7829 now.

Call to display_forums should not use $config (fix completed in vcs)

In viewforum.php (and probably other places) a list with moderators is generated with:

list($active_forum_ary, $moderators) = display_forums($forum_data, $config['load_moderators'], $config['load_moderators']);

display_forums() calls get_moderators() which starts with this code snippet:

Code: Select all
        if (!$config['load_moderators'])
        {
                return;
        }


Which makes sense since get_moderators() only fetches data from the moderators_cache table which won't be filled if load_moderators is set to false.

Because of this calling forums_display() with load_moderators is rather misleading. You can't force forums_display() to return a list with moderators by changing this into TRUE. IMO the call should either omit these arguments or it should use TRUE in the function call.

Comments / History

Edited ticket

Action performed by BartVB (Consultant) on Oct 29th 2008, 20:29

Edited ticket

Action performed by BartVB (Consultant) on Oct 29th 2008, 20:33

Assigned ticket to user "Acyd Burn"

Action performed by Acyd Burn (Server Manager) on Jun 13th 2009, 14:01

Changed ticket status from "New" to "Fix in progress"

Action performed by nickvergessen (Development Team Member) on Jun 18th 2009, 20:33

Assigned ticket to user "nickvergessen"

Action performed by nickvergessen (Development Team Member) on Jun 18th 2009, 20:33

Set this ticket to "unassigned"

Action performed by nickvergessen (Development Team Member) on Jun 20th 2009, 22:52

Changed ticket status from "Fix in progress" to "Reviewed"

Action performed by nickvergessen (Development Team Member) on Jun 20th 2009, 22:52

Assigned ticket to user "Acyd Burn"

Action performed by Acyd Burn (Server Manager) on Jun 21st 2009, 09:15

Changed ticket status from "Reviewed" to "Fix in progress"

Action performed by Acyd Burn (Server Manager) on Jun 21st 2009, 09:29

Linked ticket with changeset: r9640

Action performed by Anonymous (I am too lazy to register) on Jun 21st 2009, 09:36

Changed ticket status from "Fix in progress" to "Fix completed in SVN"

Action performed by Acyd Burn (Server Manager) on Jun 21st 2009, 09:36

Posted by Acyd Burn (Server Manager) on Jun 21st 2009, 09:37

Bart... it is now possible to load moderators directlly. ;)

Ticket details

Related SVN changesets