phpBB • Free and Open Source Forum Software

Hi,

when a user wants to become a member of a public group and files an application ("Antrag stellen"), this is recorded as

user x added to group y

in admin log, even when the request has not been accepted.

This is wrong and confusing. (A few minutes ago I thought: "What the ...., who the .... put newbie x into the senior members group?")

Regards
Wolfgang

If a user joins a group and the membership is pending the following log entry is used:

Code: Select all: 'LOG_USER_GROUP_JOIN_PENDING' => 'User joined group and needs to be approved » %s',

Could you post exact steps to see this log entry?

I was also unable to find your posted log entry.

If you file a bug report, be as specific as possible.

Hello Acyd Burn!

I was also unable to find your posted log entry.

Propably because I translated the log entry from German into English.

The problem still occurs:

Log in with a test account, go to the User Control Panel / Usergroups / Edit memberships. Choose a group in which you want to become a member and click on "submit" button.
Then log in as admin and look at the admin log. What I got, you can see in the attached picture.

Seems like the line

Code: Select all: add_log('user', $user->data['user_id'], 'LOG_USER_GROUP_JOIN' . (($group_row[$group_id]['group_type'] == GROUP_FREE) ? '' : '_PENDING'), $group_row[$group_id]['group_name']);

in includes/ucp/ucp_groups.php doesn't work correctly.

The group type of the group my testuser wanted to join is 0.

Regards
Wolfgang

EDIT: GROUP_FREE == 4, GROUP_OPEN == 0. Anyway, membership in the group the testuser wanted to join, does need approval. Therefore the log is wrong.
Maybe just replace GROUP_FREE with GROUP_OPEN in the line in ucp_groups.php I posted above?

The group type GROUP_OPEN is for groups where membership is pending... (the group Type "Request" within the ACP). The group type GROUP_FREE is for "Open" groups, anyone can join without approval. So, the log entry is absolutely correct...

If the group type the user wanted to join is 0 than the group would be of type "Request" of course, but then the log would use the "Pending" language variable if you have a look at the code.

Could it be that it is an error within the language pack?

Code: Select all: 'LOG_USER_GROUP_JOIN' => 'User joined group » %s', 'LOG_USER_GROUP_JOIN_PENDING' => 'User joined group and needs to be approved » %s',

Although, the german language pack is correct:

Code: Select all: 'LOG_USER_GROUP_JOIN' => 'Gruppe beigetreten » %s', 'LOG_USER_GROUP_JOIN_PENDING' => 'Gruppenmitgliedschaft beantragt, Freigabe erforderlich » %s',

BTW... it is a difference if an admin adds a user to the group, then there is no approval needed of course.

If you replace GROUP_FREE with GROUP_OPEN in the line you quoted than the log entry would be the '_PENDING' one for groups with the id 4.

No, the user requested to be a member of the group.

I think my work is done here. If you have a specific question, just let me know.

Else I will fix the problem by myself.

Regards
Wolfgang,

who nearly got a heartache when he read the log entry mentioned in the first post...

As i said, the problem is not reproducible for me and seems to work for all. Something is really strange on your installation because you often post bug reports where your installation is the only one having the error.

I would be glad to inspect your code if you PM me access details (FTP access and board access), but at the moment it is a support request and not a bug within the software (as i demonstrated above).

I could be always wrong, so please make sure your code is up-to-date. This is not an update from a beta by any means?

Acyd Burn wrote:As i said, the problem is not reproducible for me and seems to work for all.

Acyd Burn wrote:Something is really strange on your installation because you often post bug reports where your installation is the only one having the error.

You made my day, Sir. :-(

It is true that I upgraded from a very heavily modded board (more than 150 MODs installed, but it worked very well in the days of phpBB-2 - not even one complaint within more than two-three years running my modified version of phpBB-2...)

Acyd Burn wrote:I would be glad to inspect your code if you PM me access details (FTP access and board access), but at the moment it is a support request and not a bug within the software (as i demonstrated above).

I know you are a trustworthy person, but giving away my hosting account details??? I don't know...

Maybe you could have my files. But also my hosting account data? Huuuuh....

Acyd Burn wrote:I could be always wrong, so please make sure your code is up-to-date. This is not an update from a beta by any means?

It was an update from a highly modified 2.0.23 to phpBB Olympus Gold 3.0.0. Then upgraded to 3.0.1, 3.0.2 and 3.0.3 (I have to upgrade to 3.0.4 yet. The bug report is from version 3.0.3)

So I am the only one who experiences this issue?
I posted a possible bugfix here:

http://www.phpbb.com/bugs/phpbb3/ticket ... post125845

But I didn't test it yet.

According to your words, my complete board might be messed up (although it seems to work).

What should I do?

Maybe my board was too complicated for the upgrading script phpBB2 --> phpBB3.

I'm really feeling insecure now. What a nice December...

The *beep* ending of a *beep* year.

Greetings
Wolfgang

I do not want you to PM me hosting details.

Just a new FTP account which you are able to remove later.

If you do not trust me in removing any and all data i get after inspecting the error you could also PM/email me your forum files and a dump of your DB, then i can install it locally.

	What:	Where:	Country:
vacatures php arbeit php jobs php lavoro php emploi php trabajo php jobs php arbeit php

Confusing language bug in admin log (fix completed in vcs)

Comments / History

Ticket details

Related SVN changesets

Advertisements