Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-1529 now.

Bots are not listed in bots group in the memberlist (fix completed in vcs)

If you go to the bots group in memberlist.php the bots are not listed.

I have no idea why it is setup like that, it was displaying correctly a while ago(before B2 when I checked it last).

But anyways, it is a pretty easy fix...

Open
includes/constants

Find
//define('USER_BOT', 2);

Replace with
define('USER_BOT', 2);

Open
memberlist.php

Find
$sql_from
WHERE u.user_type IN (" . USER_NORMAL . ', ' . USER_FOUNDER . ")

Replace with
$sql_from
WHERE u.user_type IN (" . USER_NORMAL . ', ' . USER_FOUNDER . ',' . USER_BOT . ")

That worked great here. Very Happy

Comments / History

Posted by Emufarmers on Aug 17th 2006, 03:51

I'm guessing it's intentional; since the memberlist is a public listing, there's no real reason to display the bots.

Posted by EXreaction (Former Team Member) on Aug 17th 2006, 15:22

That could be true, but then if someone trys to view the Bots usergroup it should be explained why they don't see them.

Or better yet(if they want to hide the bots) remove any links that would bring you to the Bots usergroup page.

Posted by EXreaction (Former Team Member) on Aug 17th 2006, 17:20

Wait, you need to do it a little different to completely fix the bug...
(you have to replce the positions 2 times otherwise it will have anouther bug)

Open
memberlist.php

Find
WHERE u.user_type IN (" . USER_NORMAL . ', ' . USER_FOUNDER . ")

Replace with
WHERE u.user_type IN (" . USER_NORMAL . ', ' . USER_FOUNDER . ',' . USER_BOT . ")

Find
WHERE u.user_type IN (" . USER_NORMAL . ', ' . USER_FOUNDER . ")

Replace with
WHERE u.user_type IN (" . USER_NORMAL . ', ' . USER_FOUNDER . ',' . USER_BOT . ")

Posted by Graham (Former Team Member) on Aug 19th 2006, 20:24

I'll take this to me since I was the one who added the Bots group to the index page so that it is clear what those users are in the viewonline.

The memberlist won't be altered to display them since they are not real members, however the key can be altered to remove the link in the same way as there is no profile link for a bot

Posted by Graham (Former Team Member) on Aug 20th 2006, 14:15

Actually on 2nd thoughts I removed it from the legend before Beta 2, not added it.

Where are you seeing a link to this group?

Posted by EXreaction (Former Team Member) on Aug 20th 2006, 18:16

If you add their group to the Who is Online with the Display group in legend part, it shows the Bots link in the Who is online. Smile

Posted by Ectoman on Sep 23rd 2006, 17:26

Is this really needed?

It I know I don't want "GoogleBot" showing up as a registered user on my forum.

Posted by Ectoman on Sep 23rd 2006, 17:26

Oh, and I'm referering to the memberslist.

Linked ticket with changeset: r6398

Action performed by Anonymous (I am too lazy to register) on Sep 23rd 2006, 19:30

Ticket details

Related SVN changesets