Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-8142 now.

Silent die on $user->setup() or $user->set_lang() errors in DEBUG_EXTRA mode (fix completed in vcs)

Whenever an error occurs in the phpBB Language files, it dies silently. This is understandable..However, it also makes debugging a pain, since it makes it harder to locate the source of the problem.

My question & suggestion is why isn't $user->setup(); and $user->set_lang(); using an internal constant defined check (DEBUG_EXTRA being the constant) to override the @include statement with a normal include statement, and not suppress the include errors? This would help out during debugging for MOD constuction/installation, but not be activated unless the board is in total debug mode anyway.

Comments / History

Posted by Desdenova on Feb 12th 2009, 17:41

Wrote up a quick patch for this.
lang_patch.txt (1.58 KB)

Edited post #138745

Action performed by Desdenova on Feb 12th 2009, 17:41

Posted by A_Jelly_Doughnut (MOD Team Member) on Feb 12th 2009, 19:12

Looks like a duplicate of http://www.phpbb.com/bugs/phpbb3/25385 => possibly invalid

Changed ticket severity from "Uncategorised/normal" to "Possibly invalid"

Action performed by A_Jelly_Doughnut (MOD Team Member) on Feb 12th 2009, 19:12

Posted by Desdenova on Feb 13th 2009, 16:57

Didn't see that..however, through that patch DEBUG_EXTRA ought to throw the suppressed errors like Acyd Burn mentioned.

Posted by bantu (3.0 Release Manager) on Feb 17th 2009, 11:59

I would appreciate if this could be added.

Assigned ticket to user "Acyd Burn"

Action performed by Acyd Burn (Server Manager) on Feb 26th 2009, 13:12

Posted by Erik Frèrejean (Support Team Member) on Mar 2nd 2009, 12:48

Just to second this. It is really annoying from a support point of view that these die silent.
The same goes for installations where the wrong DBAL was selected. These also die without any error message.

Posted by Paul (MOD Team Member) on Mar 2nd 2009, 12:55

The one for the DBAL depends I think also on the server config, if thats disabling error reporting or not. (Or is it suppresed in the DBAL itself? :/)

Posted by Acyd Burn (Server Manager) on Mar 2nd 2009, 13:42

The DBAL thing is fixed in 3.1 - since the error is suppressed in 3.0 we rely on the SQL server returning the correct error.

Changed ticket status from "New" to "Fix completed in SVN"

Action performed by Acyd Burn (Server Manager) on Mar 17th 2009, 12:01

Linked ticket with changeset: r9383

Action performed by Anonymous (I am too lazy to register) on Mar 17th 2009, 12:02

Marked ticket #51205 as duplicate of this ticket

Action performed by bantu (3.0 Release Manager) on Sep 12th 2009, 19:40

Ticket details

Duplicates of this ticket

Related SVN changesets