Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-8577 now.

Search for unreads should require login (fix completed in vcs)

I like to keep a bookmark of my own posts and when I click on it, the login page appears and after logging in I'm redirected to my own posts.
A similar behavior should exist in the search of unreads...
If - when not logged in - you hit on search.php?search_id=unreadposts you get results (perhaps of the Anonymous user?)
This does not really make sense. Since unreads for each user are stored in the db I believe it should check whether the user is logged in, if not redirect to the login screen and after that to the proper results...
As a person who's been using the unread feature since my day one with olympus (thanks to View or mark unread posts) I'm just trying to offer my 2c here in order to make this new feature more usable.What do you think?

Comments / History

Posted by rxu (Development Team Member) on Aug 13th 2009, 11:59

Actually, if you click the link to view unread posts being guest, you'll be taken to the "View new posts" page instead of "View unread posts" one.
"View new posts" ability is not restricted for guests.

Posted by nickvergessen (Development Team Member) on Aug 13th 2009, 12:06

I think you should not be able to click it at all.
And you should put a (trigger_error with a) redirect. as 2 different pages with the same result seem really odd to search engines and stuff like that.

Posted by rxu (Development Team Member) on Aug 13th 2009, 12:22

Well, the link is not visible for guests, but you always will be able to "click" it (having bookmark, entering it into the browser address bar, etc), this can't be changed at all ;)

Posted by Kellanved (Former Team Member) on Aug 13th 2009, 12:43

What about a login box?

Edited post #175935

Action performed by rxu (Development Team Member) on Aug 13th 2009, 12:46

Posted by rxu (Development Team Member) on Aug 13th 2009, 13:10

Login box could be implemented for the time being since for now the feature doesn't support unread posts viewing for cookie-based tracking type (and hence for guests too).
But if we decide it to support cookie-based tracking, login box will became redundant.

Posted by narqelion (I've Been Banned!) on Aug 13th 2009, 14:42

Any link that is not normally visible to guests should redirect to a login page if accessed outside of the GUI. It should not return a page inconsistent with it's behavior if accessed properly when logged in.

Changed ticket status from "New" to "Reviewed"

Action performed by ToonArmy (Development Team Member) on Aug 13th 2009, 18:11

Posted by ToonArmy (Development Team Member) on Aug 13th 2009, 18:11

Agreed, if the user has to be logged in then it should ask them to login.

Assigned ticket to user "rxu"

Action performed by ToonArmy (Development Team Member) on Aug 13th 2009, 18:12

Changed ticket severity from "Uncategorised/normal" to "Severe"

Action performed by ToonArmy (Development Team Member) on Aug 13th 2009, 18:12

Changed ticket status from "Reviewed" to "Fix in progress"

Action performed by rxu (Development Team Member) on Aug 14th 2009, 11:20

Linked ticket with changeset: r10004

Action performed by rxu (Development Team Member) on Aug 17th 2009, 13:25

Changed ticket status from "Fix in progress" to "Fix completed in SVN"

Action performed by rxu (Development Team Member) on Aug 17th 2009, 13:25

Changed ticket severity from "Severe" to "Uncategorised/normal"

Action performed by bantu (3.0 Release Manager) on Aug 18th 2009, 08:11

Posted by Paul (MOD Team Member) on Sep 20th 2009, 08:42

Instead of a loginbox I receive the next error as guest
Code: Select all
Sorry but you are not permitted to use the search system.


See here (Running RC1): http://staffordforum.eu/nl/search.php?s ... nreadposts

Ticket details

Related SVN changesets