phpBB • Free and Open Source Forum Software

Because the

Code: Select all: 'S_LOGIN_ACTION'

template variable is defined in index.php and not in the page_header() function you can only add the quick login box to the index page without changing phpBB itself. It looks strange to do this, this way and it limits style author as they can't add the box everywhere.

That will definitely be a great change. Also a lot of authors are currently already using S_LOGIN_ACTION globally in the header as login, but they don't know that it will not work except on the index and login page.

My last patch seems to break the login page itself, due to the fact that those templates use the S_LOGIN_ACTION variable as well. I've prepared two patches to cope with this, the first one changes one of the template variables and therefore will break templates though it seems like the cleanest solution to me. The second will only set the S_LOGIN_ACTION variable in the page_header function if the user isn't looking at the login page.

Erik, please test the attached patch. I hope it syndicates the login action for all pages and all possibilities and also allowing for proper redirects on all pages.

Please also test with cookies disabled.

I did some first tests of course, but need this verified, because it changes quite a lot regarding internal functionality.