Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-8638 now.

Friends & Foes give unexpected behavior (fix completed in vcs)

Steps to reproduce:
  1. Disable the "Manage friends" module in the ACP.
  2. View a regular member's profile - the "Add friend" link is still visible. The link should not display at all... if we were to disable the "Manage foes" module, the Add foe link would display, but this time it would give us "Module not accessible."
  3. Clicking on Add friend ends up adding the user to your foes list.

Comments / History

Posted by narqelion (I've Been Banned!) on Aug 30th 2009, 02:01

As for the links not being removed in the member profile view, that has been brought up many times with regard to 3.0.4, see the following topics:

viewtopic.php?f=46&t=1434975&hilit=foe

viewtopic.php?f=46&t=1543195&hilit=foe

Maybe you can get them to clean up the templates completely when a specific module is disabled, I got shot down every time. I believe Rich (McGirr) has also tried to get that behavior changed without success, but as far as 3.0.5 you are correct that when the friends module is disabled instead of taking you to the fugly "module not accessible" error page it actually adds the user to your foes list.

Edited post #179575

Action performed by narqelion (I've Been Banned!) on Aug 30th 2009, 02:03

Posted by A_O_C on Aug 30th 2009, 09:02

Hmmm, weird. If you disable the "friends and foes" module altogether, the links don't display (correct behavior in my opinion). Maybe another switch is needed to check and see if the individual modules are disabled?

Assigned ticket to user "nickvergessen"

Action performed by nickvergessen (Development Team Member) on Aug 30th 2009, 09:12

Changed ticket status from "New" to "Fix in progress"

Action performed by nickvergessen (Development Team Member) on Aug 30th 2009, 09:12

Linked ticket with changeset: r10065

Action performed by nickvergessen (Development Team Member) on Aug 30th 2009, 11:56

Changed ticket status from "Fix in progress" to "Fix completed in SVN"

Action performed by nickvergessen (Development Team Member) on Aug 30th 2009, 11:56

Linked ticket with changeset: r10066

Action performed by nickvergessen (Development Team Member) on Aug 30th 2009, 12:05

Posted by narqelion (I've Been Banned!) on Aug 30th 2009, 13:00

Posted by A_O_C on Aug 30th 2009, 05:02
Hmmm, weird. If you disable the "friends and foes" module altogether, the links don't display (correct behavior in my opinion). Maybe another switch is needed to check and see if the individual modules are disabled?

Like I said, been brought up more than once and it was dismissed ... :roll:

me wrote:"Post by narqelion ยป Tue Mar 24, 2009 5:40 pm
In your scenario of just wanting to disable the "Foes" feature, disabling it in the ACP does not remove the link in the memberlist template view. The switch in the template is all or nothing, meaning you have to disable both "Friends" & "Foes" for the links to be hidden. The display switch should be re-written to account for one or the other being disabled so you don't have to go in and make a manual edit."

Posted by nickvergessen (Development Team Member) on Aug 30th 2009, 13:12

It is fixed now, see the both added revisions.

Ticket details

Related SVN changesets