phpBB • Free and Open Source Forum Software

Updated from 3.0.5 to 3.0.6RC1 using the auto updater, I have a slighly modified ucp_group.php, After updating following error is now produced:

Code: Select all: Parse error: syntax error, unexpected ';', expecting ')' in /home/euk/couk/forums/includes/ucp/ucp_groups.php on line 716

Oldfile is attached.

Also, its not just that bug, tried to fix it but there are a number of bugs, seems it has duplicated unnecesarily or something, not sure, All I know is it created a bad file

Can you PM me your old file?

Its attached, http://www.phpbb.com/bugs/phpbb3/downlo ... t_id=14955 . If you are still having problems let me know.

That file already contains a syntax error.

Yep, the file you attached already has the duplicated code. I need the original 3.0.5 file to be able to reproduce it here.

Oh sorry, must have accidently overwritten it before uploading while fixing it. Here is the one from my phpbb3.0.5 copy of the forum, I have checked, it works fine.

Oh my... no wonder it is giving a broken file. You changed a lot of phpBB's code, changed the tabs in front of it, moved lines around (as it seems from the diff, will do the update in a minute).

Which mod is this, causing so much core code changes (which are not necessary at all)?

The updater shows 4 conflicts... what did you choose to fix it? The first option, the second, the third, the fourth or did you resolve the conflicts manually by downloading the conflict file and re-uploading it as 3.0.5 file so the updater catches the modifications.

Which mod is this, causing so much core code changes (which are not necessary at all)?

None, I did it a while ago before I got the hang of phpBB's functions (wasnt sure triggeR_error would exit), the else is unnecesary, but I doubt I'm the only person who will have such a modification and use the auto updater. I used the first option - It passed checks, but when moderating groups it came to my attention, I fixed it by uploading a fresh 3.0.6rc1 file.