phpBB • Free and Open Source Forum Software

When a typical user (registered users) with merge mcp permission alone or without split permission. When he / she select a topic as merge target. No title will be displayed on the selected title section.

This also apply to phpBB 3.0.6-rc1

Code: Select all: Index: mcp_topic.php =================================================================== --- mcp_topic.php (revision 4) +++ mcp_topic.php (working copy) @@ -259,7 +259,7 @@ // Display topic icons for split topic $s_topic_icons = false; - if ($auth->acl_get('m_split', $topic_info['forum_id'])) + if ($auth->acl_gets('m_split', 'm_merge', $topic_info['forum_id'])) { include_once($phpbb_root_path . 'includes/functions_posting.' . $phpEx); $s_topic_icons = posting_gen_topic_icons('', $icon_id);

Wow, looking at the revisions this has been the way since the first 3.0.x versions (3.0.0 or even before).

So, you basically have moderators having merge permission but no split permissions?

I think this must be m_merge alone, because to_topic_id is not used for splitting topics at all, only for merging.

edit: of course both, topic icons for both and topic info for merge.

What i wonder is why no one every noticed.

	What:	Where:	Country:
vacatures php arbeit php jobs php lavoro php emploi php trabajo php jobs php arbeit php

Selected merge target no title displayed (fix completed in vcs)

Comments / History

Ticket details

Related SVN changesets

Advertisements