Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-2112 now.

xhtml compliance (fix completed in vcs)

(based on DizzyTech post in area51).
2 small xhtml violations:
1: in posting_attach_body.html, which, in itself, is completely embedded in a table, the javascript code is outside any <tr> or<th> element. this is a violation, as, if i understand correctly, <tr> and <th> are the only legal elements in a table.
2: again, in the same file, you have
<textarea class="post" name="filecomment" rows="3" cols="35" size="40">
"size" is not a valid attribute for a textarea.


HINT:

use http://validator.w3.org
it is a bit challenging to test "posting", especially if you dont allow guest posting, because the validator is not a registered user.
one way of doing it is to get to any specific page, use your browser's "view source", select all, copy, and use the textarea in the validator to paste the whole page.
this way you can validate any page, including pages in posting, private messages, profile, acp/mcp etc., and even without publishing your fixes on the web.

Comments / History

Posted by Virtuality (QA Team) on Nov 13th 2006, 18:19

Lol, I'm pretty sure the devs know about w3c and their validators. :p Nice find though.

Posted by Obi_Wan on Nov 13th 2006, 20:12

I've got a nice firefox addon which checks the pages when I open them ^^.

Posted by Acyd Burn (Server Manager) on Nov 14th 2006, 10:58

I have this addon installed too, but this addon is not always accurate, also listing warnings (empty span) which are actually not "wrong" - therefore this extension is somewhat useless (if it is the same).

Posted by arod-1 on Nov 14th 2006, 12:25

well, there is an "offline page validator" tool that automates the process i described in my "HINT": it opens validator.w3.org in a new tab, and submits the page source to the direct input validator. this makes the process a faster and more convenient.
from what i saw so far, roughly 1 in 3 acp pages, and maybe 1 in 4 ucp pages are in violation. i haven't test any mcp pages yet. some of the user-level pages too.
i don't think i am going to submit a report per each, at least not until you'll declare them all clean.

Posted by dhn (Former Team Member) on Nov 15th 2006, 16:58

arod-1: The Web Developer extension for Firefox has a "Validate Local HTML" option for you to skip the step of copying and pasting the source code to the validator.

Linked ticket with changeset: r6586

Action performed by Anonymous (I am too lazy to register) on Nov 15th 2006, 17:17

Linked ticket with changeset: r7236

Action performed by DavidMJ (Former Team Member) on Mar 28th 2007, 01:01

Ticket details

Related SVN changesets