Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-8804 now.

rss feed problems on special url (fix completed in vcs)

On 3.0.6 rc3 i found thid bug/lack of features.

When you link to a post like this, the url in url bar doesnt work correct.
http://phpbb3bbcodes.com/viewtopic.php? ... 993#p31422

But if the link looks like this. The topic shows up in rss perfect.
http://phpbb3bbcodes.com/viewtopic.php? ... 11&start=0

Its seems strange its posible to link to a post inside a topic without mentioning the "t" in url.

Comments / History

Posted by RMcGirr83 (Former Team Member) on Oct 19th 2009, 14:38

Your link is set as

Code: Select all
http://phpbb3bbcodes.com/viewtopic.php?f=36&p=3993#p31422


which will never complete correctly. Try

Code: Select all
http://phpbb3bbcodes.com/viewtopic.php?p=31422#p31422

Edited post #192605

Action performed by RMcGirr83 (Former Team Member) on Oct 19th 2009, 14:39

Posted by ToonArmy (Development Team Member) on Oct 19th 2009, 15:17

Makes no difference the server never sees the fragment (bit after the #)

Posted by ok_1 on Oct 20th 2009, 15:49

Can you post a link so I can see what is the problem?

Posted by DoYouSpeakWak (Jr. MOD Validator) on Oct 20th 2009, 22:55

See first post in this ticket

Posted by DoYouSpeakWak (Jr. MOD Validator) on Nov 1st 2009, 20:39

Saw the feed mentioned in rc4, but this problem still exists. So it must have been another fix.

What are the chances on this being fixed before gold ?, Found out alot of mods and portals use this way of linking to posts. Seems like the standard way.

Posted by stokerpiller on Nov 17th 2009, 19:23

If anybody should want to reproduce this, just click the last post image here on phpbb.com
You will get a link like this: viewtopic.php?f=46&p=11236515#p11236445

No RSS is available for this topic when you use last post image.
I think it should.

Assigned ticket to user "bantu"

Action performed by bantu (3.0 Release Manager) on Nov 24th 2009, 19:19

Changed ticket status from "New" to "Reviewed"

Action performed by bantu (3.0 Release Manager) on Nov 24th 2009, 19:19

Posted by bantu (3.0 Release Manager) on Nov 24th 2009, 19:47

The problem is ... S_TOPIC_ID is being fetched using request_var() in page_header() which means that the topic feed will not show up when only the p parameter is passed.

S_FORUM_ID does not have the problem because of
Code: Select all
// We overwrite $_REQUEST['f'] if there is no forum specified
// to be able to display the correct online list.
// One downside is that the user currently viewing this topic/post is not taken into account.
if (empty($_REQUEST['f']))
{
    
$_REQUEST['f'] = $forum_id;
in viewtopic.

Assigned ticket to group "Development Team"

Action performed by bantu (3.0 Release Manager) on Nov 24th 2009, 19:52

Assigned ticket to user "bantu"

Action performed by bantu (3.0 Release Manager) on Nov 30th 2009, 00:01

Linked ticket with changeset: r10295

Action performed by bantu (3.0 Release Manager) on Nov 30th 2009, 00:06

Changed ticket status from "Reviewed" to "Fix completed in SVN"

Action performed by bantu (3.0 Release Manager) on Nov 30th 2009, 00:06

Posted by bantu (3.0 Release Manager) on Nov 30th 2009, 00:06

I've commited a fix, but it's not very elegant.

Ticket details

Related SVN changesets