I noticed in my 3.0.6-RC3 board that smilies wider than 127 pixels are being shrunk so they do not exceed the width of 127.
When you go to "Add Multiple Smilies" and the page auto-detects the width & height, it is filling in the width of 127 for smiles bigger than 127. In 3.0.5 this same page shows the correct dimensons of the smilie.
Also, if you try to manually type in the correct width/height dimensions for a smilie in the "Add Multiple Smilies" page or in the individual smilie Edit page, it is ignored and changed back to 127.
The culprit seems to be in acp_icons.php. Not sure why there is a function in there that shrinks smilies down to 127 (@ line 93)?
Bug tracker
Smilies being limited to 127px wide (fix completed in vcs)
Comments / History
Posted by Acyd Burn (Server Manager) on Oct 25th 2009, 07:52
In phpBB it is not possible to have bigger smilies - therefore the "limitation". You would get an sql error if you try to add them.
Posted by VSE on Oct 25th 2009, 09:30
It was possible in all versions before 3.0.6...
Fix #10088 introduced this problem for bug #44415, which was supposed to limit the size of TOPIC ICONS from being too big. But the fix is also affecting smilies too, and should be corrected so it only affects topic icons.
Fix #10088 introduced this problem for bug #44415, which was supposed to limit the size of TOPIC ICONS from being too big. But the fix is also affecting smilies too, and should be corrected so it only affects topic icons.
Posted by nickvergessen (Development Team Member) on Oct 25th 2009, 12:45
Smilies width and height is smallint(4) so it should have the same problem
Posted by narqelion (I've Been Banned!) on Oct 25th 2009, 14:07
VSE wrote:It was possible in all versions before 3.0.6...
That is correct, I am still running 3.0.4 and I have several holiday smilies that are 150 x 150 and there was never an issue with adding them.
Posted by VSE on Oct 25th 2009, 17:12
Well it used to work, besides, the databse could also be changed from smallint to something else too.
v3.0.5 on top, v3.0.6 on bottom:
v3.0.5 on top, v3.0.6 on bottom:
Screenshot2009-10-25.png (40.76 KB)
Posted by ToonArmy (Development Team Member) on Oct 25th 2009, 19:53
The confusion here is that the smilies and icons table have different data types. The former is smallint(4) unsigned and the latter is tinyint(4).
Changed ticket severity from "Uncategorised/normal" to "Severe"
Action performed by ToonArmy (Development Team Member) on Oct 25th 2009, 19:54
Posted by VSE on Oct 26th 2009, 00:35
Thank you ToonArmy...
And smallint() has a max value of 32767 instead of 127.
And smallint() has a max value of 32767 instead of 127.
Posted by ToonArmy (Development Team Member) on Oct 26th 2009, 04:12
Smilies uses an unsigned smallint which maxes out at 65535 the problem is that smilies/icons use the same ACP page so the code limit added applies to both.
Assigned ticket to user "Acyd Burn"
Action performed by Acyd Burn (Server Manager) on Oct 26th 2009, 08:27
Changed ticket status from "New" to "Reviewed"
Action performed by Acyd Burn (Server Manager) on Oct 26th 2009, 08:27
Linked ticket with changeset: r10234
Action performed by Acyd Burn (Server Manager) on Oct 26th 2009, 13:59
Changed ticket status from "Reviewed" to "Fix completed in SVN"
Action performed by Acyd Burn (Server Manager) on Oct 26th 2009, 13:59