Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-8864 now.

prosilver images change (fix completed in vcs)

1.When I set the default prosilver style and language set to zh_cmn_hant (1.jgp)
http://rexkyo.com/1.jpg
2.Members to use UCP to change languages (for example, en), enter the viewtopic when the button is still displayed zh_cmn_hant.( 2.jpg)
http://rexkyo.com/2.jpg
1.jpg (37.36 KB), 2.jpg (105 KB)

Comments / History

Posted by scoop_yo on Nov 21st 2009, 16:48

Same problem here.

Edited post #197785

Action performed by scoop_yo on Nov 21st 2009, 16:49

Edited post #197785

Action performed by scoop_yo on Nov 21st 2009, 16:54

Posted by Raimon (Styles Team Leader) on Nov 23rd 2009, 02:30

The issue is caused because the sid is removed on the stylesheet url, so the $user['default_lang']; can not be called, so it use the default language of the board.

For example if you remove the check (sid) the language of the user will be called, ( for guests would it be the default board language ).
see the patch i have attached.
bug54035.patch (849 Bytes)

Changed ticket severity from "Uncategorised/normal" to "Severe"

Action performed by Kellanved (Former Team Member) on Nov 23rd 2009, 07:46

Posted by nissin on Nov 24th 2009, 07:00

My patch for this bug:
OPEN style.php, FIND
Code: Select all
$id = (isset($_GET['id'])) ? intval($_GET['id']) : 0;

ADD AFTER
Code: Select all
$lang = (isset($_GET['lang']) && !is_array($_GET['lang'])) ? htmlspecialchars($_GET['lang']) : '';

FIND
Code: Select all
   if ($user['user_id'] == ANONYMOUS)
   {
      $user['user_lang'] = $config['default_lang'];
   }

ADD AFTER
Code: Select all
   if (!empty($lang))
   {
      $user['user_lang'] = $lang;
   }

Also need to change the language in Anonymous profile (default english).

Edited post #198245

Action performed by nissin on Nov 24th 2009, 07:17

Changed ticket severity from "Severe" to "Uncategorised/normal"

Action performed by Acyd Burn (Server Manager) on Nov 28th 2009, 10:55

Posted by maxhel on Dec 2nd 2009, 20:24

i have same problem

how to use patch?

Posted by zhenyab on Dec 6th 2009, 21:39

My patch for this problem:

OPEN includes/functions.php, FIND
Code: Select all
'T_STYLESHEET_LINK' => (!$user->theme['theme_storedb']) ? "{$web_path}styles/" . $user->theme['theme_path'] . '/theme/stylesheet.css' : append_sid("{$phpbb_root_path}style.$phpEx", 'id=' . $user->theme['style_id'] . '&lang=' . $user->data['user_lang']),


REPLACE WITH
Code: Select all
'T_STYLESHEET_LINK' => (!$user->theme['theme_storedb']) ? "{$web_path}styles/" . $user->theme['theme_path'] . '/theme/stylesheet.css' : append_sid("{$phpbb_root_path}style.$phpEx", 'id=' . $user->theme['style_id'] . '&lang=' . $user->data['user_lang'],true,$user->session_id),

Posted by Saint_hh on Dec 7th 2009, 06:50

PHP Version: 5.2.6-1+lenny3
MySQL: 5.0.51a-24+lenny1-log

Same issue here with all installed boards, independent which style is set. Standard language buttons are displayed.

The patch by Raimon didn't change anything, but the patch by zhenyab did the trick.
Not tried the patch by nissin.

Edited post #201165

Action performed by Saint_hh on Dec 7th 2009, 06:52

Changed ticket status from "New" to "Fix in progress"

Action performed by ToonArmy (Development Team Member) on Dec 11th 2009, 20:48

Linked ticket with changeset: r10319

Action performed by ToonArmy (Development Team Member) on Dec 11th 2009, 20:49

Changed ticket status from "Fix in progress" to "Fix completed in SVN"

Action performed by ToonArmy (Development Team Member) on Dec 11th 2009, 20:50

Linked ticket with changeset: r10008

Action performed by ToonArmy (Development Team Member) on Dec 11th 2009, 20:51

Posted by Saint_hh on Dec 12th 2009, 02:42

ToonArmy, would you be so nice to let us know which fix has been used?
Thanks in advance!

Posted by ToonArmy (Development Team Member) on Dec 12th 2009, 02:55

2nd one, my changes are linked on the right hand side. ;)

Ticket details

Duplicates of this ticket

Related SVN changesets