Linked ticket with changeset: r6684
Action performed by Anonymous (I am too lazy to register) on Nov 28th 2006, 11:04
Bug tracker
Update from 3.0.B4-dev to 3.0.B4 not working (fix completed in vcs)
I have a CVS snapshot of 3.0.B4-dev installed. After reading an awaited announcement this morning I went to "Version Check" and followed instructions: downloaded phpBB-3.0.B4-dev_to_3.0.B4.zip, unpacked and placed the install directory to my root folder. After clicking on "Now start the update process..." link (https://olympus/install/index.php?mode= ... 6b65c3e6f3) I was redirected to standard announcement that I have to delete an install folder. Nothing was updated. When pointing manually to https://olympus/install/ I saw an update tab (https://olympus/install/index.php?mode= ... anguage=en) but this link redirected to the same "delete install folder" information.
Comments / History
Posted by Acyd Burn (Server Manager) on Nov 28th 2006, 10:27
Normally this should not happen. If the DEBUG_EXTRA constant is defined (please check this in your config.php file) then the install notice should not occur at all - if it is not defined and you are using a newer snapshot it should not occur too if you are properly logged in. This may be a combination of a hardcoded fix i did for the broken Beta3 install check.
Could you change your install/install_update.php file in the following way and test again?
Search line 99:
Replace with:
Could you change your install/install_update.php file in the following way and test again?
Search line 99:
- Code: Select all
/**
* Check for user session
* - commented out for beta3 with "broken" install check routine
if (!$user->data['is_registered'])
{
login_box('', $user->lang['LOGIN_UPDATE_EXPLAIN']);
}
if (!$auth->acl_get('a_'))
{
trigger_error($user->lang['NO_AUTH_UPDATE']);
}
*/
Replace with:
- Code: Select all
// Check for user session
if (!$user->data['is_registered'])
{
login_box('', $user->lang['LOGIN_UPDATE_EXPLAIN']);
}
if (!$auth->acl_get('a_'))
{
trigger_error($user->lang['NO_AUTH_UPDATE']);
}
Posted by bobline on Nov 28th 2006, 10:42
DEBUG_EXTRA was not defined (commented out). The user session part didn't change anything. Yes, I was logged in properly and stay logged in now.
Should I define DEBUG_EXTRA and try to upgrade or do you want me to investigate why it's not working now? (I am using this snapshot: phpBB3-CVS_2006-11-26).
Should I define DEBUG_EXTRA and try to upgrade or do you want me to investigate why it's not working now? (I am using this snapshot: phpBB3-CVS_2006-11-26).
Posted by bobline on Nov 28th 2006, 10:46
I get redirected within call to $user->setup('install'); (line 96 of install/install_update.php)
Posted by Acyd Burn (Server Manager) on Nov 28th 2006, 10:50
So (i need to recreate) DEBUG_EXTRA is commented out and nothing else changed... maybe it is a bug and i need to change the calls slightly.
Posted by bobline on Nov 28th 2006, 10:58
Two cases, same results:
1. DEBUG_EXTRA is commented out. Nothing else is changed yet.
2. DEBUG_EXTRA is commented out. I applied your patch.
Your patch is not executed anyway as the redirect happens earlier on line 95: $user->setup('install');
1. DEBUG_EXTRA is commented out. Nothing else is changed yet.
2. DEBUG_EXTRA is commented out. I applied your patch.
Your patch is not executed anyway as the redirect happens earlier on line 95: $user->setup('install');
Posted by Acyd Burn (Server Manager) on Nov 28th 2006, 11:04
Ah, found the error. 
To use a workaround and get it to work you need to enable DEBUG_EXTRA.
To use a workaround and get it to work you need to enable DEBUG_EXTRA.