phpBB • Free and Open Source Forum Software

RSS Facebook Twitter

Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-2344 now.

viewing file difference - side by side (will not fix)

it's not a bug, but when comparing long codelines in this mode, you will need at least a 30'' monitor to compare "side-by-side".
maybe breaking the codelines at x characters will help for better "comparing".

(not a big prob, but helpful for comparing)

Comments / History

Posted by Acyd Burn (Server Manager) on Dec 2nd 2006, 11:10

I will let this one open (instead of tagging as "Will not fix"). Codelines should not be wrapped, else the context is not able to be displayed correctly (due to side-by-side comparing the number of lines need to match exactly).

But i will assign this to dhn - not for actually fixing this "issue" but for looking at it. He may see something i have overseen.

Posted by Gumfuzi on Dec 2nd 2006, 11:46

Well, thats a good point, which I had not thought about...

many thanks!

Posted by ChALkeR on Dec 9th 2006, 00:49

Maybe a table of lines?

Posted by el_noobe on Dec 10th 2006, 22:37

Maybe it could be possible to add a dropdown menu like "Select number of characters per line" and two or three options like "No line breaks", "50 Characters", "100 Characters", so that a user can choose how he wants it to be displayed.
I hope this will not be seen as a feature request... Wink

Posted by ChALkeR on Dec 12th 2006, 01:11

That could by done via JS.

Posted by ChALkeR on Dec 12th 2006, 01:11

*be done Smile

Linked ticket with changeset: r6947

Action performed by Anonymous (I am too lazy to register) on Jan 28th 2007, 16:46

Posted by dhn (Former Team Member) on Jan 28th 2007, 16:56

Some changes added.

TODO:
- Find a way to get IE to play ball
- RAW display needs some fine tuning

Posted by DualFusion on Apr 27th 2007, 23:04

ChALkeR wrote:That could by done via JS.

Yes, it could, but the idea is to use minimal js, since some users dont have js enabled and therefore (s)he wont be able to see what is being tried to be projected with js.

I think the best thing to do is have two options, word wrap [yes/no]. If word wrap is enabled, a table is shown and there will still be the same amount of lines, if it isnt enabled, the area of the differences would have automatic scrollbars.

Also since I have not yet used the upgrader or the diff engine, I do not know if it already has line numbering. If it doesn't, that would be a great addition for future use :D

Ticket details

  • Ticket ID: 5712
  • Project: phpBB 3.0.x
  • Status: Will not fix
  • Severity: Uncategorised/normal
  • Component: Update system
  • Project version: 3.0.B4
  • PHP version: Unknown
  • Database: Unknown
  • Assigned to: Styles Team
  • Reported by: Gumfuzi (Send PM)
  • Reporter's tickets: List all tickets
  • Reported on: Nov 28th 2006, 19:11

Related SVN changesets

Advertisements

 BlueHost.com • Web Hosting UK • HostMonster • Reseller Web Hosting UK • FastDomain Hosting • Advertise on phpBB.com