Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-2710 now.

URL parsing (specific url) (fix completed in vcs)

The following url is not being recognized by the new code (exprienced by a user at area51):

http://olympuswiki.naderman.de

Comments / History

Posted by Highway of Life (QA Team) on Jan 2nd 2007, 13:36

Heh, you beat me to it, didn't you. Wink

Posted by wagnerch on Jan 2nd 2007, 23:12

Failed to parse:

http://www.powerpostgresql.com/PerfList/

I reversed the change to get_preg_expression in revision 1.515 for includes/functions.php and the first URL was working OK. NOTE: This should only affect users that are using CVS HEAD, as revision 1.503 was released with 3.0B4 (presumably without this issue?).


The next URL that fails:
pg_buffercache

I modified the preg in includes/bbcode.php.

Index: includes/bbcode.php
===================================================================
RCS file: /cvsroot/phpbb/phpBB2/includes/bbcode.php,v
retrieving revision 1.105
diff -u -p -r1.105 bbcode.php
--- includes/bbcode.php 17 Dec 2006 17:59:08 -0000 1.105
+++ includes/bbcode.php 2 Jan 2007 22:58:45 -0000
@@ -203,7 +203,7 @@ class bbcode
$this->bbcode_cache[$bbcode_id] = array(
'preg' => array(
'#\[url:$uid\]((.*?))\[/url:$uid\]#s' => $this->bbcode_tpl('url', $bbcode_id),
- '#\[url=([^\[]+?):$uid\](.*?)\[/url:$uid\]#s' => $this->bbcode_tpl('url', $bbcode_id),
+ '#\[url=([^\]]+?):$uid\](.*?)\[/url:$uid\]#s' => $this->bbcode_tpl('url', $bbcode_id),
)
);
break;
@@ -572,4 +572,4 @@ class bbcode
}
}

-?>
\ No newline at end of file
+?>

Posted by naderman (Development Team Leader) on Jan 3rd 2007, 09:50

I'm probably rather going to make a new change to the url validation regex (changing the way "userinfo" is handled in the url)

Posted by Acyd Burn (Server Manager) on Jan 3rd 2007, 11:12

naderman: Another one which seems to not be catched:

http://forum.beryl-project.org/

Posted by Acyd Burn (Server Manager) on Jan 3rd 2007, 16:19

And yet another one (i hope they are all failing because of the same reasons. Smile):

http://www.lithiumstudios.org/phpBB3/vi ... p?f=9&t=18

Posted by Acyd Burn (Server Manager) on Jan 3rd 2007, 16:23

I have set the severity to High because Jon wanted to run a new conversion. Smile

Linked ticket with changeset: r6832

Action performed by naderman (Development Team Leader) on Jan 3rd 2007, 18:58

Posted by Nicholas the Italian on Jan 3rd 2007, 18:59

It seems a matter of length.
ciao works while
ciao does not.

Ticket details

Related SVN changesets