phpBB • Free and Open Source Forum Software

CVS: January 18 Snapshot

Now I consider this nitpicking to an absurd level, but I noticed a slight alignment issue with the topic icon status key. Here I have highlighted the panel to show the issue clearly:

It stems from the code in viewforum_body.html align code:

Code: Select all: <td align="left" valign="top"> <table cellspacing="3" cellpadding="0" border="0"> <tr> <td width="20" align="left">{FOLDER_NEW_IMG}</td> <td class="gensmall">{L_NEW_POSTS}</td> <td>  </td> <td width="20" align="center">{FOLDER_IMG}</td> <td class="gensmall">{L_NO_NEW_POSTS}</td> <td>  </td> <td width="20" align="center">{FOLDER_ANNOUNCE_IMG}</td> <td class="gensmall">{L_ICON_ANNOUNCEMENT}</td> </tr> <tr> <td width="20" align="center">{FOLDER_HOT_NEW_IMG}</td> <td class="gensmall">{L_NEW_POSTS_HOT}</td> <td>  </td> <td width="20" align="center">{FOLDER_HOT_IMG}</td> <td class="gensmall">{L_NO_NEW_POSTS_HOT}</td> <td>  </td> <td width="20" align="center">{FOLDER_STICKY_IMG}</td> <td class="gensmall">{L_ICON_STICKY}</td> </tr> <tr> <td class="gensmall">{FOLDER_LOCKED_NEW_IMG}</td> <td class="gensmall">{L_NEW_POSTS_LOCKED}</td> <td>  </td> <td class="gensmall">{FOLDER_LOCKED_IMG}</td> <td class="gensmall">{L_NO_NEW_POSTS_LOCKED}</td> <td>  </td> <td width="20" align="center">{FOLDER_MOVED_IMG}</td> <td class="gensmall">{L_MOVED_TOPIC}</td> </tr> </table>

I recommend having every image align to center.

You're using a modified style so it doesn't belong here. Center alignment would probably make the standard style look goofy anyway.

The icons are designed to be changed easily via the ACP iconset tool. This issue does not appear with the default style because every icon is the exact same size. So it does no matter what alignment it is for the provided icons, but it does make a difference when someone changes the icons.

If someone is changing their icons via the ACP, they can just as easily align them from there, too. Changing the alignment now would mess up how subSilver looks.

Changing the default align in each image cell is not going to modify the look of the current subSilver template in the slightest. However, it will make a difference for people who want to swap out the default images to personalize their forum.

Furthermore, this whole table needs a few fixes. For example some cells have the gensmall class that don't need it. It is also pointless to set the table width on anything lower then the first row unless you are using a colspan. Removing the unnecessary data will save a couple bytes per page load.

	What:	Where:	Country:
vacatures php arbeit php jobs php lavoro php emploi php trabajo php jobs php arbeit php

Topic Status Icon Panel Alignment (fix completed in vcs)

Comments / History

Ticket details

Related SVN changesets

Advertisements