phpBB • Free and Open Source Forum Software

RSS Facebook Twitter

Bug tracker

This ticket has been moved to our new tracker. Open Ticket PHPBB3-3674 now.

'save' option works wrong in 'edit' mode (fix completed in vcs)

If you:

- click to edit a post,

- make some changes to the post and save the edits as a draft (using the 'save' button which shows up even in 'edit' mode) and

- load and submit the draft, the edited post gets posted as a new reply rather than replacing the original post.

I think the save feature should either be unavailable in edit mode, or should save an edited post in a way so that when the edited post is finally submitted as a live post it replaces the original post.

For what it's worth, we had a discussion about this point here: http://area51.phpbb.com/phpBB/viewtopic ... =4&t=27492

Comments / History

Changed ticket status from "New" to "Already fixed"

Action performed by Acyd Burn (Server Manager) on Apr 5th 2007, 13:07

Posted by asinshesq (QA Team) on Apr 6th 2007, 12:23

The version in the CVS from April 5 (I just downloaded it) still has this error. Did the fix not yet get committed to CVS?

Changed ticket status from "Already fixed" to "Reviewed"

Action performed by Acyd Burn (Server Manager) on Apr 6th 2007, 17:41

Posted by Acyd Burn (Server Manager) on Apr 6th 2007, 17:41

Ah, this is for save... need to remove it from there too then...

Assigned ticket to user "Acyd Burn"

Action performed by Acyd Burn (Server Manager) on Apr 6th 2007, 17:41

Changed ticket status from "Reviewed" to "Already fixed"

Action performed by Acyd Burn (Server Manager) on Apr 6th 2007, 17:46

Posted by Acyd Burn (Server Manager) on Apr 6th 2007, 17:46

Tested here now... save button works fine (it redirects you to the topic/forum and saved the draft without changing the message) and load does not appear within the edit window at all...

closing.

Posted by asinshesq (QA Team) on Apr 6th 2007, 20:55

I'm really sorry to keep raising this, but I'm pretty sure I'm not explaining myself well enough and for that reason you're not following what I am saying. Bear with me:

I am NOT saying save doesn't work in edit. Instead, I am saying that save button should not appear at all in edit mode if the only thing it will do is to save a draft of a brand new reply to the edited post.

Assume a user posts a post with post_id 1000 and then edits that post and saves the edited version as a draft. Then he goes to his drafts in the UCP, loads the draft and submits it.

The result: the edited post gets posted as a brand new reply (e.g. post_id 1001) and so in viewtopic you end up with the original unedited post followed by the edited one. That makes no sense to me.

I think that either:

- there should be no 'save' button when a user is in edit mode, or

- the save button in edit mode should allow you to edit the post and when you finally submit the draft it should replace the original post.

Hope that helps, and again sorry to keep "bugging" you about this ;)

Changed ticket status from "Already fixed" to "New"

Action performed by Acyd Burn (Server Manager) on Apr 7th 2007, 08:21

Changed ticket status from "New" to "Fix in progress"

Action performed by Acyd Burn (Server Manager) on Apr 21st 2007, 13:36

Changed ticket status from "Fix in progress" to "Fix completed in CVS"

Action performed by Acyd Burn (Server Manager) on Apr 22nd 2007, 15:47

Ticket details

  • Ticket ID: 9624
  • Project: phpBB 3.0.x
  • Status: Fix completed in VCS
  • Severity: Uncategorised/normal
  • Component: Unknown
  • Project version: 3.0.B5
  • PHP version: Unknown
  • Database: Unknown
  • Assigned to: Acyd Burn
  • Reported by: asinshesq (QA) (Send PM)
  • Reporter's tickets: List all tickets
  • Reported on: Apr 4th 2007, 23:01

Advertisements

 BlueHost.com • Web Hosting UK • HostMonster • Reseller Web Hosting UK • FastDomain Hosting • Advertise on phpBB.com