Code: Select all
<a href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}">
Code: Select all
<a href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}" target="_blank">
Code: Select all
<div class="gensmall" style="float: {S_CONTENT_FLOW_BEGIN};"> <!-- IF postrow.U_PROFILE --><a href="{postrow.U_PROFILE}">{PROFILE_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_PM --><a href="{postrow.U_PM}">{PM_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_EMAIL --><a href="{postrow.U_EMAIL}">{EMAIL_IMG}</a> <!-- ENDIF --> </div>
Code: Select all
<div class="gensmall" style="float: {S_CONTENT_FLOW_BEGIN};"> <!-- IF postrow.U_PROFILE --><a href="{postrow.U_PROFILE}">{PROFILE_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_PM --><a href="{postrow.U_PM}">{PM_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_EMAIL --><a href="{postrow.U_EMAIL}">{EMAIL_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_WWW --><a href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}">{WWW_IMG}</a><!-- ENDIF --> </div>
TheIlluminative (post corrected) wrote:1- Open file: styles/prosilver/template/viewtopic_body.html, find:replace with:Code: Select all
<a href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}">
2- Open file: styles/subsilver2/template/viewtopic_body.html, find:Code: Select all
<a target="_blank" href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}" target="_blank">
replace with:Code: Select all
<div class="gensmall" style="float: {S_CONTENT_FLOW_BEGIN};"> <!-- IF postrow.U_PROFILE --><a href="{postrow.U_PROFILE}">{PROFILE_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_PM --><a href="{postrow.U_PM}">{PM_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_EMAIL --><a href="{postrow.U_EMAIL}">{EMAIL_IMG}</a> <!-- ENDIF --> </div>
refresh your templates then through ACP.Code: Select all
<div class="gensmall" style="float: {S_CONTENT_FLOW_BEGIN};"> <!-- IF postrow.U_PROFILE --><a href="{postrow.U_PROFILE}">{PROFILE_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_PM --><a href="{postrow.U_PM}">{PM_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_EMAIL --><a href="{postrow.U_EMAIL}">{EMAIL_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_WWW --><a target="_blank" href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}">{WWW_IMG}</a><!-- ENDIF --> </div>
Actually, what you've done is you've invalidated that code with a second target. First, there is no proper order in the HTML attributes. The original code was fine having it at the end. Second, the target attribute itself is invalid for XHTML, which is what subsilver2 validates as.Linda Carter wrote:I have corrected your post, now I can have both the WWW button and the ability to open links on another window!
This is the correct syntax:
<a target="_blank" href="
TheIlluminative (post corrected) wrote:1- Open file: styles/prosilver/template/viewtopic_body.html, find:replace with:Code: Select all
<a href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}">
Code: Select all
<a target="_blank" href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}" target="_blank">
The "target" attribute does not have to appear in any particular place in order to be functional, therefore the code posted by TheIlluminative was absolutely fine. In fact, your "correction" was wrong in that you included the target="_blank" twice.Linda Carter wrote:I have corrected your post, now I can have both the WWW button and the ability to open links on another window!
This is the correct syntax:
<a target="_blank" href="
Code: Select all
<a href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}" target="_blank">
Code: Select all
<a href="{postrow.U_WWW}" target="_blank" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}">
Code: Select all
<a target="_blank" href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}">
Code: Select all
<a target="_blank" href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}" target="_blank">
you could have simply stated that the button was missing and asked how to fix it. Also you statedit seems the phpBB developers have missed the fact the WWW button is not being showed on the subSilver2 style
If you had read the phpBB Discussion forum you would have found a number of topics (including this one) that have already dealt with this. The decision of not opening a new window was made to adhere to standards, not personal opinions....and it's not opening on a new window. Which doesn't make any sense.
drathbun is correct about the proSilver style, but the subSilver2 is different. My last post have the correct syntax for that line. By adding the target attribute before the href attribute (not after), you did what was necessary to open that link on another window.Noxwizard wrote:Actually, what you've done is you've invalidated that code with a second target. First, there is no proper order in the HTML attributes. The original code was fine having it at the end. Second, the target attribute itself is invalid for XHTML, which is what subsilver2 validates as.
Code: Select all
<div class="gensmall" style="float: {S_CONTENT_FLOW_BEGIN};"> <!-- IF postrow.U_PROFILE --><a href="{postrow.U_PROFILE}">{PROFILE_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_PM --><a href="{postrow.U_PM}">{PM_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_EMAIL --><a href="{postrow.U_EMAIL}">{EMAIL_IMG}</a> <!-- ENDIF --> <!-- IF postrow.U_WWW --><a target="_blank" href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}">{WWW_IMG}</a><!-- ENDIF --> </div>
And may I assume those who spend their time using the software are not allowed to show their discontent with your so called standards that on a daily-basis will be a bad choice and mean nothing for most people?Normally I would not have called attention to the manner of your posting, but you have shown a certain pattern which has brought your posts to the attention of the moderator team on more than one occasion. Please keep this in mind for future posts. Attacking or denigrating the developers does not earn you points on this site from those that put out their free time to write the code and maintain this site, nor does it earn you points from those of us that are fans of the work that is being done.
I wasn't refering to whether it actually opened in a window or not. That code is invalid, adding a second target further invalidates it.Linda Carter wrote:drathbun is correct about the proSilver style, but the subSilver2 is different. My last post have the correct syntax for that line. By adding the target attribute before the href attribute (not after), you did what was necessary to open that link on another window.
That is due to adding the first target.Line 2, Column 10: there is no attribute "target".Code: Select all
<a target="_blank" href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_W
You have used the attribute named above in your document, but the document type you are using does not support that attribute for this element. This error is often caused by incorrect use of the "Strict" document type with a document that uses frames (e.g. you must use the "Transitional" document type to get the "target" attribute), or by using vendor proprietary extensions such as "marginheight" (this is usually fixed by using CSS to achieve the desired effect instead).
This error may also result if the element itself is not supported in the document type you are using, as an undefined element will have no supported attributes; in this case, see the element-undefined error message for further information.
How to fix: check the spelling and case of the element and attribute, (Remember XHTML is all lower-case) and/or check that they are both allowed in the chosen document type, and/or use CSS instead of this attribute. If you received this error when using the <embed> element to incorporate flash media in a Web page, see the FAQ item on valid flash.
That is caused by the addition of your code, the line is syntactically incorrect.Line 2, Column 92: duplicate specification of attribute "target".Code: Select all
…IT_WEBSITE}: {postrow.U_WWW}" target="_blank">
You have specified an attribute more than once. Example: Using the "height" attribute twice on the same "img" tag.
Expressing your opinion is fine, as well as some criticism. However, constant criticism on nearly every MOD Request and style change is not constructive criticism.Linda Carter wrote:I always thought a little criticism, instead of being received as a major offense, would be used for something good. I guess I was mistaken.
That's the beauty of open source. You can do whatever you want with it.Linda Carter wrote:I can't believe most phpBB users are happy with the idea of opening links in the same window (unless they don't use the URL BBcode, or find the idea of Local BBCodes interesting). Thanks, but I will stick with something that was a "standard" for 7 years on phpBB 2. The new version always manages to change the one feature you like/need most.
There are productive ways to express your opinions or ask for help. Saying "I would like to see this work in a different way" is much more likely to receive a positive response than "what on earth were the developers thinking when they wrote this code?". If you can't see the difference between those two choices then I am afraid that you're going to continue to experience negative responses here. If I can clarify this point further via PM please feel free to contact me, as I do not want to clutter up this topic any more than we already have. Thanks.I always thought a little criticism, instead of being received as a major offense, would be used for something good. I guess I was mistaken.