Code: Select all
#
#-----[ OPEN ]------------------------------------------
#
viewforum.php
#
#-----[ FIND ]------------------------------------------
#
ORDER BY t.topic_last_post_id DESC ";
#
#-----[ IN-LINE FIND ]------------------------------------------
#
DESC
#
#-----[ IN-LINE AFTER, ADD ]------------------------------------------
#
, t.topic_last_post_id DESC
fredol wrote: Hi,
This is a very cool MOD, but I think there might be a little mistake in the MOD
I think it should be t.topic_priority and not topic_last_post_id again and I also think it should be added BEFORE, so AFTER ORDER BY (to get ORDER BY t.topic_priority DESC, t.topic_last_post_id DESC) Right??Code: Select all
# #-----[ OPEN ]------------------------------------------ # viewforum.php # #-----[ FIND ]------------------------------------------ # ORDER BY t.topic_last_post_id DESC "; # #-----[ IN-LINE FIND ]------------------------------------------ # DESC # #-----[ IN-LINE AFTER, ADD ]------------------------------------------ # , t.topic_last_post_id DESC
And just a thought, but why not add a little something so ADMIN and MODS can set the priority when posting a new topic, instead of having to go in the MOD CP ?
Anyway, great MOD!
Thanks,
fredol
Code: Select all
#
#-----[ FIND ]------------------------------------------
#
ORDER BY t.topic_last_post_id DESC ";
#
#-----[ REPLACE WITH ]------------------------------------------
#
ORDER BY t.topic_priority DESC, t.topic_last_post_id DESC ";
Renegade88 wrote: You are absolutely right.
This mod was perfect (400 installations to prove it), but the PHPBB team made me switch from the FIND and REPLACE command to the INLINE FIND and INLINE REPLACE and I didn't want to do it because the code was perfect, but it wasn't going to get approved otherwise. I was nervous that I would make a mistake, changing good code for no gain apparent to me. Looks like my worries were not unfounded. I tried to be extra careful, but it looks like I messed up the conversion anyway. I will try to update that, good catch.
Code: Select all
#
#-----[ FIND ]------------------------------------------
#
<td class="row2" align="center" valign="middle">
<input type="checkbox" name="topic_id_list[]" value="{topicrow.TOPIC_ID}" />
</td>
#
#-----[ AFTER, ADD ]------------------------------------------
#
<td class="row1" align="center" valign="middle">
<input type="Text" name="topic_cement:{topicrow.TOPIC_ID}" value="{topicrow.TOPIC_PRIORITY}" maxlength="5" size="5" />
</td>
Actually, did you fix that problem above?
Can you try with Firefox? If it works in one browser and not another, that would point to a problem with the FORM in the template.
Code: Select all
Code removed by wGEric, Please don't post large amounts of code. Thanks.
Code: Select all
Code removed by wGEric, Please don't post large amounts of code
Code: Select all
Code removed by wGEric, Please don't post large amounts of code
Renegade88 wrote: I don't know why you posted that whole thing.
I asked, "did you fix the known bug in the 1.0.1 script before you ran it"?
You said "no".
Mystery solved.
Solution: Read the posts above and correct as necessary.
ORDER BY t.topic_priority DESC, t.topic_last_post_id DESC ";