phpBB • Free and Open Source Forum Software

Neither edits functions_messenger.php

I'd compare functions_messenger.php from 3.0.9 with what you have and see what changes there are, if any, outside those made for the digest mod.

Will do thanks..

Differences
Line 255 did read:

Code: Select all

   function send($method = NOTIFY_EMAIL, $break = false)

Now Reads:

Code: Select all

   function send($method = NOTIFY_EMAIL, $break = false, $is_html = false, $is_digest = false)

Line 291 did read:

Code: Select all

      if (preg_match('#^(Subject:(.*?))$#m', $this->msg, $match))

Now Reads:

Code: Select all

      if (!$is_digest && preg_match('#^(Subject:(.*?))$#m', $this->msg, $match))

Line 314 did read:

Code: Select all

            $result = $this->msg_email();

Now REads:

Code: Select all

            $result = $this->msg_email($is_html);

Line 322 did read:

Code: Select all

            $result = $this->msg_email();

Now REads:

Code: Select all

            $result = $this->msg_email($is_html);

Line 379 did read:

Code: Select all

   function build_header($to, $cc, $bcc)

Now Reads:

Code: Select all

   function build_header($to, $cc, $bcc, $is_html = false)

Line 404 did read:

Code: Select all

      $headers[] = 'Content-Type: text/plain; charset=UTF-8'; // format=flowed

Now Reads:

Code: Select all

      $headers[] = ($is_html) ? 'Content-Type: text/html; charset=UTF-8' : 'Content-Type: text/plain; charset=UTF-8';

LIne 424 did read:

Code: Select all

   function msg_email()

Now Reads:

Code: Select all

   function msg_email($is_html=false)

Line 479 did read:

Code: Select all

      $headers = $this->build_header($to, $cc, $bcc);

Now reads:

Code: Select all

      $headers = $this->build_header($to, $cc, $bcc, $is_html);

Line 696 did read:

Code: Select all

   function process()

Now Reads:

Code: Select all

   function process($process_all=false)

Line 704> did read:

Code: Select all

      if (!$process_all)
      {
         if (!file_exists($this->cache_file) || filemtime($this->cache_file) > time() - $config['queue_interval'])
         {
            $this->unlock($lock_fp);
            return;
         }
      }

Now Reads:

Code: Select all

      if (!$process_all)
      {
         if (!file_exists($this->cache_file) || filemtime($this->cache_file) > time() - $config['queue_interval'])
         {
            $this->unlock($lock_fp);
            return;
         }
      }

Line 722 did read:

Code: Select all

         $num_items = (!$package_size || sizeof($data_ary['data']) < $package_size) ? sizeof($data_ary['data']) : $package_size;

Now reads (line 725):

Code: Select all

         $num_items = (!$package_size || sizeof($data_ary['data']) < $package_size || $process_all) ? sizeof($data_ary['data']) : $package_size;

Those are the only parts of the 3.0.9 clean/orig file and the current one that differ.

Those look like digest changes only.

Any other suggestions? The users were getting a lot of use out of the digests. Then we discovered that only half were getting them. In trying to fix this I decided i might as well upgrade to 2.2.17 in the process. Now we seem to be worse off than before.

I know it is beta and bugs are to be expected. Right now there's really no functionality though, for us on our board.

Do you have any suggestions on what I should do next? Uninstall the whole thing and go back to 2.2.16 from scratch?

Thanks for your help.
-Christi

It would be nice to know what's causing your problem. Are you Windows or Unix hosted? I am assuming Unix if you can change file permissions. Do you use SMTP to send the email?

What is your email package size? I think the default is 20, which means that if 30 should go out the first 20 will and the next 10 will go into the queue, and that seems to be the problem (saving to the queue). I have to think the root of the problem is permissions for the cache, but if other cache files are in your cache directory I doubt that's the problem.

Changing line 149 to:

Code: Select all

$messenger = new messenger(false);

will at least turn off the queue and make one digest go out at a time. If you do this comment the lines that save to the queue and process the queue.

I agree!

Linux, GoDaddy Shared Hosting.
I'm afraid my noob is showing here but I'll do my best to answer the rest of your questions.

Using Sendmail. SMTP is not currentlly configured in my installation of phpBB3.

No idea how to find out my email package size. Suggestions on where to look?

I changed 149 to include the (false). I get no error when there is no digest to send and the same error when there is one to send. The digest seems to send but then errors and I never get the 'ending mail digests' message.

This is the chron report I get via email after the last send. One email was sent (this was proper) then it errored and did not end.

HideShow

<strong>Starting mail_digests.php</strong><br /><strong>A digest was sent to admin (removed) containing 15 posts and 0 private messages</strong><br /><br /> <b>Fatal error</b>: Call to a member function save() on a non-object in <b>/home/-snip-/html/phpBB3/mail_digests.php</b> on line <b>654</b><br />

As I said, you need to comment out those lines at the start of the topic.

Ahh sorry I misunderstood. So is it correct then that the following should be commented out

Code: Select all

/*
if (sizeof($rowset) > 0)
{
   $messenger->queue->save(); // Writes the queue to disk. Seems to be necessary
   $messenger->queue->process(true); // Send everything in the queue, even if it is over the limit.
}
*/

AND line 149 should read

Code: Select all

$messenger = new messenger(false);

Yes, should work.

Hum.. Something's still up. No errors but I changed one of my users pref to email at 8. It's now 9 and the last chron job didn't mention her. It came up empty.

Could it be that daylight savings time/summer time is not turned on in her profile? The setting is taken into effect in calculating the time a digest goes out.

Several members were set to get digests this morning and did not seem to. It has been several hours since it was supposed to go out so DLST should not have been the reason they didn't go out.

STRIKE THAT- I just got a cron report that 94 digests went out. I'll go quiz those people and see if they actually got them!


Thank you for your help!
-Christi