UCP Style Preview

xhtml error in ucp_prefs_personal - UCP Style Preview

xhtml error in ucp_prefs_personal

Postby DoYouSpeakWak » Fri Sep 03, 2010 1:58 pm

Hey Rich

Just noticed a strange xhtml error when viewing this mod in ucp when using prosilver

If i use this (from the mod)
Code: Select all
   <!-- IF S_STYLE_OPTIONS and not S_STYLE_PREVIEW -->
      <dl>
         <dt><label for="style">{L_BOARD_STYLE}:</label></dt>
         <dd><select name="style" id="style">{S_STYLE_OPTIONS}</select></dd>
      </dl>
   <!-- ELSEIF S_STYLE_PREVIEW -->
   <!-- INCLUDE ucp_style_preview.html -->
   <!-- ENDIF -->


I get a xhtml error

If the org code is used, there is no xhtml error
Code: Select all
   <!-- IF S_STYLE_OPTIONS -->
      <dl>
         <dt><label for="style">{L_BOARD_STYLE}:</label></dt>
         <dd><select name="style" id="style">{S_STYLE_OPTIONS}</select></dd>
      </dl>
   <!-- ENDIF -->


Error code from the validator
Hide
line 279 column 19 - Info: reference to non-existent ID "style"


Strange since the ID style is also used in org code.


EDIT: It seems subsilver2. has 4 xhtml errors on these lines
Code: Select all
<script type="text/javascript" src="./style_preview/jquery_core_mini.js"></script>
<script type="text/javascript" src="./style_preview/jquery_ui_custom.js"></script>
<script type="text/javascript" src="./style_preview/style_preview_ajax_mini.js"></script>

<script type="text/javascript">


All of the errors are the same
Hide
line 328 column 72 - Error: document type does not allow element "script" here
Whatever you share comes back. Support the phpBB Communities
My Validated and Released Modifications
User avatar
DoYouSpeakWak
Jr. MOD Validator
 
Posts: 1921
Joined: Fri Jul 25, 2008 1:32 pm
Location: Island of Wak-Wak
Name: Mikkel koch

Re: xhtml error in ucp_prefs_personal

Postby RMcGirr83 » Fri Sep 03, 2010 5:29 pm

Hide
DoYouSpeakWak wrote:Hey Rich

Just noticed a strange xhtml error when viewing this mod in ucp when using prosilver

If i use this (from the mod)
Code: Select all
   <!-- IF S_STYLE_OPTIONS and not S_STYLE_PREVIEW -->
      <dl>
         <dt><label for="style">{L_BOARD_STYLE}:</label></dt>
         <dd><select name="style" id="style">{S_STYLE_OPTIONS}</select></dd>
      </dl>
   <!-- ELSEIF S_STYLE_PREVIEW -->
   <!-- INCLUDE ucp_style_preview.html -->
   <!-- ENDIF -->


I get a xhtml error

If the org code is used, there is no xhtml error
Code: Select all
   <!-- IF S_STYLE_OPTIONS -->
      <dl>
         <dt><label for="style">{L_BOARD_STYLE}:</label></dt>
         <dd><select name="style" id="style">{S_STYLE_OPTIONS}</select></dd>
      </dl>
   <!-- ENDIF -->


Error code from the validator
Hide
line 279 column 19 - Info: reference to non-existent ID "style"


Strange since the ID style is also used in org code.


Sorry I don't get the same error....I don't get any error at all.


Hide
EDIT: It seems subsilver2. has 4 xhtml errors on these lines
Code: Select all
<script type="text/javascript" src="./style_preview/jquery_core_mini.js"></script>
<script type="text/javascript" src="./style_preview/jquery_ui_custom.js"></script>
<script type="text/javascript" src="./style_preview/style_preview_ajax_mini.js"></script>

<script type="text/javascript">


All of the errors are the same
Hide
line 328 column 72 - Error: document type does not allow element "script" here


So set a switch in the overall_header.html for if SCRIPT_NAME eq ucp and then set the js in there. You can try it, but I'm not going to worry about W3c errors on subsilver 2.

If you find a solution, please post it up.
Assistance with mods | My MODS | Grateful for the mods/support? Then why not buy me a beer

Image
User avatar
RMcGirr83
Former Team Member
 
Posts: 14839
Joined: Wed Jun 22, 2005 4:33 pm
Location: Connecticut USA
Name: Rich McGirr