Search found 489 matches

by vipaka
Fri Sep 20, 2019 8:53 am
Forum: Extension Writers Discussion
Topic: submit_post should use $poster_id but doesn't
Replies: 3
Views: 367

Re: submit_post should use $poster_id but doesn't

Not sure what it is that you are trying to say here. Do you believe that this is a bug? In which case report it to the bug tracker. Are you saying that the code is badly written? If so create a PR to improve it. Are you saying that extensions are using the wrong data? Then report it to the appropri...
by vipaka
Thu Sep 19, 2019 4:52 am
Forum: Extension Writers Discussion
Topic: submit_post should use $poster_id but doesn't
Replies: 3
Views: 367

submit_post should use $poster_id but doesn't

The poster_id value is assumed to be $user->data['user_id'] several times in the function most notably around line 1613 where the 'poster_id' array key is keyed to it for all replies always, even though $poster_id has already been defined based intelligently off data array vs user->data. I think thi...
by vipaka
Wed Aug 22, 2018 2:36 am
Forum: Extension Writers Discussion
Topic: Global functions?
Replies: 12
Views: 717

Re: [SOLVED] Global functions?

As it is this code wil not pass the validation (I am quite sure). On a side note can't be considered as "solved" since is leading the future readers/extension writers to wrong directives. Not every extension is written with the intent of passing the validation process. I have at this point probably...
by vipaka
Wed Aug 22, 2018 12:28 am
Forum: Extension Writers Discussion
Topic: Global functions?
Replies: 12
Views: 717

Re: [SOLVED] Global functions?

From your description I think you just need to listen to a phpBB PHP event that is triggered on every page (like i.e core.page_header ), not a global function. Global functions go against the philosophy of extensions not being global in scope. This extension needs to be global. It needs to be acces...
by vipaka
Tue Aug 21, 2018 3:32 am
Forum: Extension Writers Discussion
Topic: Global functions?
Replies: 12
Views: 717

Re: [SOLVED] Global functions?

3Di wrote:
Mon Aug 20, 2018 11:49 pm
That's not the right way to do it if I can say.
What way do you prefer?
by vipaka
Mon Aug 20, 2018 10:38 pm
Forum: Extension Writers Discussion
Topic: Global functions?
Replies: 12
Views: 717

Re: Global functions?

Full answer for anyone else who might need want it (I found it in another ext I had already written). in event listener. return array( 'core.common' => whatever', ) public function whatever($event) { global $phpbb_root_path, $phpEx; include($phpbb_root_path . 'ext/extAuthor/extName/includes/function...
by vipaka
Mon Aug 20, 2018 10:10 pm
Forum: Extension Writers Discussion
Topic: Global functions?
Replies: 12
Views: 717

Global functions?

Hopefully a quick and easy question. How do we build custom global functions correctly into the PHPBB ext system? I have a custom PHP function I want available on every page, and without manually writing it into functions.php or one of the other global php files I am not sure how to achieve that. Th...
by vipaka
Mon Jul 30, 2018 4:22 am
Forum: Extension Requests
Topic: Marketplace extension
Replies: 65
Views: 9590

Re: Marketplace extension

I feel compelled to comment after reading some of the (naive) comments on here... I taught myself to code thinking "it'll be simple, the extension I want can't be that hard" with the same mentality I'm seeing on here. I don't regret it but, for the record, it took YEARS. Sure, after a few *months* o...
by vipaka
Fri Feb 10, 2017 7:19 am
Forum: Abandoned Extensions
Topic: [ABD] Notifications 2.0
Replies: 5
Views: 1771

Re: [DEV] Notifications 2.0

Hi! Could you add to notify all team members when a user is warned? Example: Moderator_Username warned Username by reason: If this extension works (which it may not, depending on what phpbb3.2 is capable of without changes to core), the moderators should be able to set their own options for the use...
by vipaka
Thu Feb 09, 2017 1:42 am
Forum: Extension Writers Discussion
Topic: Improved Documentation
Replies: 3
Views: 319

Re: Improved Documentation

Events are documented here: https://wiki.phpbb.com/Event_List general documentation is here: https://area51.phpbb.com/docs/dev/32x/extensions/ (And 3.1: https://area51.phpbb.com/docs/dev/31x/extensions/ ) Thank you for the links, but I have already read through those. The points raised in the first...
by vipaka
Wed Feb 08, 2017 7:12 am
Forum: Abandoned Extensions
Topic: [ABD] Notifications 2.0
Replies: 5
Views: 1771

[ABD] Notifications 2.0

Extension Name: Notifications 2.0 Author: vipaka Extension Description: Expansion of the notification system...because it needs this. I am not even sure if this ext will be possible with the events available in 3.2 but I'll attempt it. Extension Version: 0.0.1 Requirements: PHP 5+ I suppose Feature...
by vipaka
Wed Feb 08, 2017 7:00 am
Forum: [3.1.x] Support Forum
Topic: Where in ACP are settings of different notifications?
Replies: 3
Views: 310

Re: Where in ACP are settings of different notifications?

(This is a zombie post I know but in case anyone else has the same issues...) Unfortunately it looks like the notification system is still woefully under developed. The database records for "enabled" or not (in notification_types) have no effect on the options page (or anything else) and there is no...
by vipaka
Wed Feb 08, 2017 3:44 am
Forum: Extension Writers Discussion
Topic: Improved Documentation
Replies: 3
Views: 319

Improved Documentation

This is a total whinge, and not an ext request so much as a wiki/site/dev request. I've been working with the new ext system and noticed a few things that aren't documented anywhere at all (or there are big important parts of the documentation missing), or have to be dumped/unraveled before they can...
by vipaka
Sun Apr 17, 2016 5:23 pm
Forum: Extension Writers Discussion
Topic: [CLOSED]Group Permissions and New Permission Category Issues
Replies: 0
Views: 248

[CLOSED]Group Permissions and New Permission Category Issues

Trying to set up some permissions for an extension I'm writing. They are working for roles, but not groups. Additionally, setting up a new category for them to display inside is also not working. I tried setting them only for the group and removing the roles entirely, but that didn't work either. In...
by vipaka
Sun Nov 15, 2015 9:24 pm
Forum: Extension Writers Discussion
Topic: Improving Phpbb Performance
Replies: 9
Views: 838

Re: Improving Phpbb Performance

do you know how much of Twig is being cached? Lurking the cached Twig folder with a decent Text Editor will introduce you to an Universe. About extensions and phpBB itself, not every query needs or can be cached, due to different factors. Let's talk about notifications, why do we have to cache them...

Go to advanced search