Search found 777 matches

by kasimi
Wed May 09, 2018 8:43 am
Forum: Extension Writers Discussion
Topic: PHPBB_ENVIRONMENT, production vs development
Replies: 11
Views: 353

Re: PHPBB_ENVIRONMENT, production vs development

Blitze wrote:
Tue May 08, 2018 4:17 pm
I can open a bug and provide a PR to fix it.
Please do.
Blitze wrote:
Tue May 08, 2018 4:17 pm
As for Travis, is it possible to make it run in development so bugs like this are not simply ignored?
I'm sure there's a more elegant way, but you could try calling error_reporting(-1); in setUpBeforeClass().
by kasimi
Tue May 08, 2018 5:40 am
Forum: Extension Writers Discussion
Topic: PHPBB_ENVIRONMENT, production vs development
Replies: 11
Views: 353

Re: PHPBB_ENVIRONMENT, production vs development

Your code doesn't behave differently, the problems are just ignored when in production . If your environment is set to development , all errors are reported. https://github.com/phpbb/phpbb/blob/release-3.2.2/phpBB/common.php#L101 https://github.com/phpbb/phpbb/blob/release-3.2.2/phpBB/phpbb/debug/de...
by kasimi
Mon May 07, 2018 8:38 pm
Forum: Extension Writers Discussion
Topic: core.search_get_topic_data
Replies: 7
Views: 251

Re: core.search_get_topic_data

Try appending to the existing sql_where value instead of overwriting it. Also you should be using $db->sql_in_set():

Code: Select all

$event['sql_where'] .= ' AND ' . $this->db->sql_in_set('t.forum_id', $forums_id_ary);
by kasimi
Mon May 07, 2018 8:34 pm
Forum: Extension Writers Discussion
Topic: Using pagination with another variable in the URL
Replies: 2
Views: 110

Re: Using pagination with another variable in the URL

You can add additional parameters to the $base_url : // For a route: $base_url = $controller_helper->route('my_route', ['another' => 'parameter']); // Otherwise: $base_url = append_sid($root_path . 'index.' . $php_ext, ['another' => 'parameter']); $pagination->generate_template_pagination($base_url,...
by kasimi
Sun May 06, 2018 7:34 am
Forum: Extensions in Development
Topic: [3.2][RC] Connection logger
Replies: 14
Views: 935

Re: [3.2][RC] Connection logger

I love this extension. Now i can see who want to log in and what login attempts are bots. Sadly the server gives me an error when a user logs into the forum mod_fcgid: stderr: PHP Fatal error: Class 'lr94\\lc\\event\\auth' not found in ..ext/lr94/lc/event/main_listener.php on line 159 Hello! Sorry ...
by kasimi
Sun Apr 22, 2018 9:34 am
Forum: Extension Writers Discussion
Topic: ACP_CAT_DOT_MOD vs ACP_EXTENSIONS module_langname
Replies: 2
Views: 195

Re: ACP_CAT_DOT_MOD vs ACP_EXTENSIONS module_langname

Use the former to add your modules to the Extensions tab. Have a look at their translations:

Code: Select all

'ACP_CAT_DOT_MODS'			=> 'Extensions',
'ACP_EXTENSIONS'			=> 'Manage extensions',
by kasimi
Sat Apr 21, 2018 9:17 pm
Forum: Extensions in Development
Topic: [RC] Digests 3.2.6
Replies: 699
Views: 38655

Re: [RC] Digests 3.2.6

// This module is new with the extension so if exists, there are no modules to convert You return $module_id == false , so if the module does not exist, your migration is effectively installed and thus being skipped. I think you want to return $module_id != false here. Also, you don't need to check...
by kasimi
Sat Apr 21, 2018 7:54 pm
Forum: Extensions in Development
Topic: [RC] Digests 3.2.6
Replies: 699
Views: 38655

Re: [RC] Digests 3.2.6

There's a fix available, see the linked PR in the ticket. It has been merged into 3.2.3-RC1, so give an update to that version a shot.
by kasimi
Sat Apr 21, 2018 7:27 pm
Forum: Extensions in Development
Topic: [RC] Digests 3.2.6
Replies: 699
Views: 38655

Re: [RC] Digests 3.2.6

MarkDHamill wrote:
Sat Apr 21, 2018 5:38 pm
There are issues with old modules not deleting that I am still puzzling through.
Maybe this is what's causing your modules not getting deleted: https://tracker.phpbb.com/browse/PHPBB3-15595
by kasimi
Tue Apr 17, 2018 7:59 pm
Forum: Extension Writers Discussion
Topic: user_add and fun with newest_user_colour
Replies: 12
Views: 357

Re: user_add and fun with newest_user_colour

You don't need to inject $config if you're not using it yourself. It sounds like you're not actually writing an extension, or you're calling your thing.php script directly, which is not how extension scripts are supposed to be used. You should use a controller and a route. https://area51.phpbb.com/d...
by kasimi
Mon Apr 16, 2018 8:23 pm
Forum: Extension Writers Discussion
Topic: user_add and fun with newest_user_colour
Replies: 12
Views: 357

Re: user_add and fun with newest_user_colour

What seems most likely to me is that your $config object isn't initialized properly, either because of wrong code or a stale cache. Are you accessing $config via dependency injection? Have you tried clearing your board cache? Instead of editing core code, add this line before your call to user_add()...
by kasimi
Tue Apr 03, 2018 10:45 pm
Forum: Extension Writers Discussion
Topic: Event core.handle_post_delete_conditions apparently ignores delete_reason
Replies: 8
Views: 357

Re: Event core.handle_post_delete_conditions apparently ignores delete_reason

Brf, $event is an object (more precise: a reference to an object) that coincidentally act's like an array (it implements the ArrayAccess interface). As it's already a reference , there's no need to explicitly add the & . You only need to specify it on object arguments if you wanted to return an obje...
by kasimi
Sun Apr 01, 2018 2:58 pm
Forum: Extension Writers Discussion
Topic: Environment service decoration
Replies: 3
Views: 180

Re: Environment service decoration

I've had similar issues with service decoration. Since your environment extends \phpbb\template\twig\environment , you need to call the parent constructor and pass all its arguments, which means your decoration service needs them injected in addition to the .inner service . Also I'm not sure if the ...
by kasimi
Sun Apr 01, 2018 2:36 pm
Forum: Custom BBCode Development and Requests
Topic: Entering the Sitename via bbCode
Replies: 5
Views: 392

Re: Entering the Sitename via bbCode

Maybe this and this is what you want? You can access the $configurator object in the core.text_formatter_s9e_configure_after event.
by kasimi
Fri Mar 23, 2018 3:53 pm
Forum: Extension Requests
Topic: Move Topics When Locked
Replies: 3
Views: 149

Re: Move Topics When Locked

None of my extensions are abandoned. Feel free to start a new topic with a detailed error description in the extension's support section if you have any problems.

Go to advanced search