Search found 24 matches

by JWPlatt
Wed Feb 22, 2017 3:59 pm
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

There is a Show (green) and Hide (red) icon/button, if that's what you mean, on the spoiler's Title Bar. The entire bar responds to a click - not just the button - which I think is a nifty feature.

AbaddonOrmuz has a screencap above on this page of the thread showing it.
by JWPlatt
Mon Feb 20, 2017 4:59 am
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

Humor - not hostility. Sorry about the lack of enough winks. The irony is that the spoiler title is truncated with an appended ellipsis before it gets too long anyway, so the whole subdiscussion about that is fairly moot. It's a great extension and just what the community needed after phpBB broke ou...
by JWPlatt
Sun Feb 19, 2017 9:21 pm
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

@AbaddonOrmuz We made a fix to style.css that should make all of us happy, which sets the status height according to the button with 1.8em instead of 100%. It allows multiline titles and solves our issue and perhaps others' with custom styles. I've sent a Github Pull Request. And by the way, the tit...
by JWPlatt
Sun Feb 19, 2017 7:37 am
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

Line 60 helper.php is: $this->remove_bbcode('spoiler'); It looks like a case issue (Spoiler | spoiler). Well, I think all tags should be in lowercase... When users can type it any way they want, it doesn't matter what you think. ;) Ours was named "Spoiler". I think it's reasonable to make just two ...
by JWPlatt
Sun Feb 19, 2017 3:15 am
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

Update:

This addition of height fixed it for me:

Code: Select all

.spoiler .spoiler-header {
	display: flex;
	height: 1.25em;
	justify-content: space-between;
}
Height was otherwise showing up as 100% in the Chrome Inspector.
by JWPlatt
Sun Feb 19, 2017 1:23 am
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

I can't reproduce the Chrome issue (v56.0.2924.87), but I think is because of display: flex , I'll look into it. If I omit display: flex; completely, as below, it behaves normally in prosilver and prosilver se. In our inherited custom style, it also fixes the issue(!), but the title and the Show/Hi...
by JWPlatt
Sat Feb 18, 2017 9:51 pm
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

Awesome, thanks. All modes/browsers work except the Chrome post Preview.

You would likely have to view the effect on our style.

What about the non-removal of our previous "Spoiler" BBCode?

Line 60 helper.php is:
$this->remove_bbcode('spoiler');

It looks like a case issue (Spoiler | spoiler).
by JWPlatt
Sat Feb 18, 2017 7:41 pm
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

Symptoms: Chrome: High spoiler title bar and button in preview, but works fine in viewpost mode. The buttons work. IE: Spoiler refuses to open when Show/Hide buttons are clicked in viewpost mode or in preview mode. Also fails under prosilver se. Firefox: All works - no big title bars in Preview I fi...
by JWPlatt
Sat Feb 18, 2017 5:28 pm
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

I have a custom style on our site that inherits prosilver se. I've created the necessary style folders and it works fine in regular viewpost mode. But in post preview, the spoiler title bar becomes humongously long, so it must be that either the title bar or the button is getting told to be very hig...
by JWPlatt
Sat Feb 18, 2017 4:22 pm
Forum: Extensions in Development
Topic: [CDB] Simple Spoiler BBCode
Replies: 39
Views: 5900

Re: [3.2][RC] Simple Spoiler BBCode

@AbaddonOrmuz Thanks for this extension, especially since phpBB 3.2 appears to have broken most or all of the custom spoiler BBCode out there. I have two suggestions: 1. To make install as easy as possible for non-techs, this instruction should not exist: Copy the files and directories inside <PHPBB...
by JWPlatt
Sat Nov 05, 2016 2:21 am
Forum: Extension Requests
Topic: phpBB-style Banner & Menu Extension
Replies: 0
Views: 264

phpBB-style Banner & Menu Extension

I'd like to see an extension offered to do what this website does with its banner and menu. Last I checked, phpBB does not have an event to support the order of banner, menu, and link/breadcrumb bar. We've had to edit overall_header.php to physically move the available event to do what phpbb.com doe...
by JWPlatt
Sat Nov 05, 2016 2:09 am
Forum: phpBB Discussion
Topic: Discuss: phpBB 3.1.10 released
Replies: 81
Views: 11699

Re: Discuss: phpBB 3.1.10 released

I've never known there to be a development vacuum before. Well, a friend of mine happened to need it, so did it himself and shared, so that's not my excuse now.
by JWPlatt
Fri Nov 04, 2016 11:58 pm
Forum: phpBB Discussion
Topic: Discuss: phpBB 3.1.10 released
Replies: 81
Views: 11699

Re: Discuss: phpBB 3.1.10 released

Then mamba will have saved the time involved in installing a "trivial" upgrade with a known issue almost upon release. Because I have other custom modifications to make with each new release, I've made the same decision. American English STILL being unavailable for 3.1.10 is another factor. Maybe th...
by JWPlatt
Tue Nov 01, 2016 8:33 pm
Forum: phpBB Discussion
Topic: Discuss: phpBB 3.1.10 released
Replies: 81
Views: 11699

Re: Discuss: phpBB 3.1.10 released

Using inheritance, I edit two files - overall_header.html and stylesheet.css - to implement a site banner and navigation menu.

Haven't looked at 3.2, but I will when it's officially released.
by JWPlatt
Tue Nov 01, 2016 7:48 pm
Forum: phpBB Discussion
Topic: Discuss: phpBB 3.1.10 released
Replies: 81
Views: 11699

Re: Discuss: phpBB 3.1.10 released

That's a lot of work revision to revision. Can't you use inheritance?

Go to advanced search