Thank you Ger, I would be very interested in how you converted an entire board to a PDF. Would you mind sharing how you did that? My intent and purpose is to just archive the board to a save the information to a static place. It does not have to be interactive or searchable... Just saved and archiv...
I have converted an entire phpBB 3.x board to PDF files once. 1 topic per PDF. That makes the whole thing independent of any dedicated software like a certain PHP version with given modules, database versions, etc.
But like others mentioned: it depends entirely on what your purpose is.
The error message is pretty clear: you have limited the file size, the image is bigger than that. Just remove that limitation, resizing on upload should never result in extreme file sizes.
Lightbox doesn't touch the file, it simply shrinks them on display.
What the TS asks if feasible though, I've made something similar in a in-browser app that allows taking photos. That shrinks to given pixels but that reduces the files to a couple of hundred MB
I don't know what that extension does, but if it makes an avatar rounded at upload, that would probably conflict since both extensions try to manipulate the file during upload. I would personally just use a border-radius to display a rounded avatar on rendering. That way, you leave the original file...
I'm not sure either will work in 2022. 3.0.12 cannot run on PHP versions >5.6. You should check that first.
That said, I'm not sure what I've changed 5 years ago
Code reviews should be code reviews. And sure, while reviewing you see stuff working and you'll have an opinion about it. But, as DavidIQ writes, in the real world one would still merge it when the code had good quality, is secure, etc. You then should make a suggestion to the product owner about yo...
It's limited though since the viewtopic.php isn't a proper controller. It does however allow you to see if there are any new posts on a page you're currently viewing.
david63 wrote: ↑Sat Jan 01, 2022 11:10 pm
As an aside, but somewhat relevant, when are phpBB's coding guidelines going to be updated to use industry standards?
What standards are these exactly that are outdated?
Well, it's detracting to say the least. And like I wrote before, my last submission almost 3 years ago seems to be denied solely for formatting reasons. I've re-read it just now, I don't see anything that fits in another category. Now I don't want to get into details about this extension per se, but...