Search found 777 matches

by -=ET=-
Wed May 27, 2020 9:22 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][RC] Group Edit Time

kinerity wrote:
Tue May 26, 2020 11:50 am
I apologize, I've had a death in the family and have been dealing with that.
Sorry, I didn't know.
kinerity wrote:
Wed May 27, 2020 5:24 pm
Bumped to RC.
Thanks! :)

Will you submit it to the Ext DB?
by -=ET=-
Mon May 25, 2020 1:01 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

Hi Kinerity,

Do you know when will you push a RC?
You've done your modifications 10 days ago but we're still waiting. I would like to send your ext to a website's owner who needs it.

Thanks! :)
by -=ET=-
Mon May 11, 2020 8:52 am
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

Added a few comments to you PR. Address those and I'll gladly merge it. ;) After the merge, IMO it's now a RC version, ready for extensive testing, not a DEV version any more. So far I can't find any issue :) but this option is only for groups, on the site in general? is it not possible to enable t...
by -=ET=-
Mon May 11, 2020 7:50 am
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

But well, I'd go for the TIMESTAMP way to do it. The ACP code is very old, just using old code means nothing IMO. I'm not sure you understand the logic of the setting. The setting is meant to say users have (for example) 15mn to edit their posts after being posted. What do you want to do with a tim...
by -=ET=-
Mon May 11, 2020 7:11 am
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

I'd like to note that the edit time it is a timestamp and should be coded as 'group_edit_time' => ['TIMESTAMP', 0], https://github.com/kinerity/groupedittime/blob/e61fc486ed3be49407ca6e26287aa86c0e2868fc/migrations/v10x/m1_initial_schema.php#L29 I don't really understand the comment. This setting i...
by -=ET=-
Sat May 09, 2020 6:00 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

The idea is you go into the settings for each group and change it to your desired value. I'm pretty sure this is standard practice for extensions. Nope. Even before you do anything, there's "0" in the database, which would mean "unlimited" by default, overriding the global setting. Test it, you'll ...
by -=ET=-
Sat May 09, 2020 1:14 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

Trust me, I certainly understand. However, it seemed as if you also wanted it to coincide with the board-wide setting. That's where the logic gets messy (at least from my perspective). Personally, I feel the board wide setting should be thrown out and moved to a per-group setting. That's the way I ...
by -=ET=-
Fri May 08, 2020 11:17 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

It makes no sense to have a group edit time limit as well as a board-wide setting. So I'm going back to the original design of per group. Having both settings just makes a mess of the logic. The logic of those sentences is hard to understand :? Having a field to enable/disable the group limit editi...
by -=ET=-
Thu May 07, 2020 9:20 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

how will this extension work? I select a time for a group and after that time no one from that group can edit? Yes. On the Settings form of a group, there will be 2 new fields: - One to enable a specific editing time management for the group - And another one to set this specific limit editing time...
by -=ET=-
Thu May 07, 2020 2:25 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

To prevent trying to hack it too much, would something like this be sufficient? This is just a mock-up, no code has been created. I would suggest something like: - Checkbox 1st: Enable group limit edit time / Help: Allow to overcome the global limit time to edit posts for the members of the group. ...
by -=ET=-
Thu May 07, 2020 1:58 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: [3.3][DEV] Group Edit Time

The group setting (if set to something other than 0) will override the global setting. If the setting is left at 0, this will give unlimited edit time to that group unless the global setting is still in play. That check is here and here and was part of the latest update. Hopefully that satisfies al...
by -=ET=-
Thu May 07, 2020 1:40 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: Best way to do without modifying core files?

I still disagree... Just a quick answer in case you disconnect quickly ;) You disagree with what? Just a quick question: if for you "0" = disabled, what would be the setting to give, specifically, unlimited time to edit posts to the members of a specific group? Don't tell me "0" otherwise, as it's ...
by -=ET=-
Thu May 07, 2020 12:43 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: Best way to do without modifying core files?

Keeping in mind that it also casts the variables as int. The group_edit_time should not be empty. A "0" means ignore the setting, anything above that and the setting should apply. That's not enough. Ok for the INT field that can't be empty with phpBB but we need to find another technical solution t...
by -=ET=-
Wed May 06, 2020 7:50 pm
Forum: Extensions in Development
Topic: [3.3][RC] Group Edit Time
Replies: 48
Views: 2478

Re: Best way to do without modifying core files?

I had a quick look at the code of main_listener.php and I think... In the SQL query, you don't look for groups that have a limit time of 0... $sql = 'SELECT group_id, group_edit_time FROM ' . $this->tables['groups'] . ' WHERE group_edit_time > ' . (int) 0; This does not allow to manage "0" as a requ...

Go to advanced search