Search found 3289 matches

by MarkDHamill
Wed Jul 01, 2020 1:51 pm
Forum: Extensions in Development
Topic: [3.3][RC] Filter by country - version 1.0.16
Replies: 359
Views: 32841

Re: [3.3][RC] Filter by country - version 1.0.13

Thanks for reporting this. Try changing the line to:

Code: Select all

		if (isset($insert_sql_ary) && count($insert_sql_ary) > 0)
by MarkDHamill
Wed Jul 01, 2020 2:16 am
Forum: Extensions in Development
Topic: [3.3][RC] Filter by country - version 1.0.16
Replies: 359
Views: 32841

Re: [3.3][RC] Filter by country - version 1.0.13

Thanks. Thought I had done that. Fixed now.
by MarkDHamill
Tue Jun 30, 2020 9:51 pm
Forum: Extensions in Development
Topic: [3.3][RC] Filter by country - version 1.0.16
Replies: 359
Views: 32841

[3.3][RC] Filter by country - version 1.0.13 released

A new version 1.0.13 is available for download. It can be downloaded from my web page or from the GitHub branch page . If you download it from GitHub, make sure you place it in the /ext/phpbbservices/filterbycountry directory. This is the first version to get a review by the extension review team. K...
by MarkDHamill
Sat Jun 27, 2020 6:14 pm
Forum: Extension Writers Discussion
Topic: tables.yml parameters in migration files
Replies: 7
Views: 408

Re: tables.yml parameters in migration files

So this seems to be something that extension review teams won't care about using literals for table name in migration programs while requiring a different approach elsewhere. That's been my experience so far, but I don't think it is mentioned anywhere.
by MarkDHamill
Sat Jun 27, 2020 5:58 pm
Forum: Extension Writers Discussion
Topic: tables.yml parameters in migration files
Replies: 7
Views: 408

Re: tables.yml parameters in migration files

The program in question is here . Currently I specify the table name as a constant, not a literal: $this->table_prefix . constants::ACP_FBC_STATS_TABLE => array( I've been told that it should come from a new tables.yml file that currently look like this: parameters: phpbbservices.filterbycountry.tab...
by MarkDHamill
Sat Jun 27, 2020 3:53 pm
Forum: Extension Writers Discussion
Topic: tables.yml parameters in migration files
Replies: 7
Views: 408

Re: tables.yml parameters in migration files

In your code I notice this:

Code: Select all

if ($this->db_tools->sql_table_exists($this->table_prefix . 'flags'))
and I've been doing something similar. But in your case I want to retrieve flags as the value of what's in my tables.yml files, similar to what I'm doing in services.yml.
by MarkDHamill
Sat Jun 27, 2020 3:30 pm
Forum: Extension Writers Discussion
Topic: tables.yml parameters in migration files
Replies: 7
Views: 408

tables.yml parameters in migration files

tables.yml should be used now to reference extension specific table names. In my extension's migration files though I need to interact with the database. In the past I used a constant to reference my tables based on the table prefix, which was automatically available as $this->table_prefix . And ye...
by MarkDHamill
Tue Jun 23, 2020 2:20 am
Forum: [3.3.x] Support Forum
Topic: Open all links INTERNALLY
Replies: 14
Views: 719

Re: Open all links INTERNALLY

I would think with some Javascript it would be possible to have a function tied to an onclick() event of a link. The Javascript could create an <iframe> tag with the content in a window size specified. The script would need to take the action if the URL requested was not on the site. It could be tie...
by MarkDHamill
Tue Jun 16, 2020 3:49 pm
Forum: [3.3.x] Support Forum
Topic: An attachment bbcode tag inside a url tag breaks the url.
Replies: 11
Views: 440

Re: An attachment bbcode tag inside a url tag breaks the url.

If you want to embed an external image or any image that is not attached you can use the [img][/img] tag.
by MarkDHamill
Tue Jun 16, 2020 12:20 pm
Forum: [3.3.x] Support Forum
Topic: An attachment bbcode tag inside a url tag breaks the url.
Replies: 11
Views: 440

Re: An attachment bbcode tag inside a url tag breaks the url.

To be clearer, when you upload an attachment, it is normally an image. The [attach] markup generally then causes the image uploaded to be displayed, so it makes no sense to be allowed to place an [img] tag between the [attach] and [/attach] tags. It is possible the attachment could be a document, in...
by MarkDHamill
Tue Jun 16, 2020 2:22 am
Forum: [3.3.x] Support Forum
Topic: An attachment bbcode tag inside a url tag breaks the url.
Replies: 11
Views: 440

Re: An attachment bbcode tag inside a url tag breaks the url.

An attachment logically should not allow an embedded image between it.
by MarkDHamill
Thu Jun 11, 2020 2:44 pm
Forum: Extensions in Development
Topic: [3.3][RC] Filter by country - version 1.0.16
Replies: 359
Views: 32841

[3.3][RC] Filter by country - version 1.0.12 - German language files

I received a German translation from Pfiffy. Thanks so much for the contribution! I don't normally include language translations in the archive because getting updated translations can take a lot of time when making new releases. I am happy to link to translations in the README file if they are acce...
by MarkDHamill
Thu Jun 11, 2020 12:53 am
Forum: phpBB Discussion
Topic: Discuss: phpBB 3.3 Proteus Feature Release Published
Replies: 163
Views: 19897

Re: Discuss: phpBB 3.3 Proteus Feature Release Published

On extensions, it just takes some research. Look at the discussion topic on the extension's page and the extensions database. Timing depends on the extension author. Many 3.2 extensions work fine under 3.3.

If you don't use reCaptcha as a spambot countermeasure, there is nothing to worry about.
by MarkDHamill
Thu Jun 11, 2020 12:28 am
Forum: phpBB Discussion
Topic: Discuss: phpBB 3.3 Proteus Feature Release Published
Replies: 163
Views: 19897

Re: Discuss: phpBB 3.3 Proteus Feature Release Published

You can go straight to 3.3 following the upgrade process.

You should make sure your extensions will work on 3.3. You will probably need to update the style as well. Also, if you are using reCaptcha, you will need a new set of keys for the Invisible Captcha, as the checkmark is not supported.
by MarkDHamill
Tue Jun 09, 2020 9:35 pm
Forum: [3.3.x] Support Forum
Topic: Private Messages email notifications not working [SOLVED (with magic)]
Replies: 10
Views: 325

Re: Private Messages email notifications not working [SOLVED (with magic)]

Sometimes you just got to kick the email server to get it to do its job. ;)

Go to advanced search