[phpBB Debug] PHP Warning: in file [ROOT]/phpbb/path_helper.php on line 239: str_repeat(): Second argument has to be greater than or equal to 0
phpBB • MODX 1.2.0 Released

MODX 1.2.0 Released

Discussion forum for MOD Writers regarding MOD Development.
User avatar
wGEric
Former Team Member
Posts: 8805
Joined: Sun Oct 13, 2002 3:01 am
Location: Friday
Name: Eric Faerber
Contact:

MODX 1.2.0 Released

Post by wGEric » Mon Jun 02, 2008 6:36 pm

We are pleased to announce the release of MODX 1.2.0. This release contains a couple new features and bug fixes aimed at making it easier for MOD Authors.

MODX is a format by the phpBB MOD Team that is used to give instructions on how to install modifications to a phpBB install.

Most notable new feature is a link tag. This tag allows authors to link to different install files or MODs that are required or optional. With the addition of this tag we have changed the strict guidelines for how MODX needs to be packaged. Authors, please read the packaging guidelines.

All MODs submitted from this point forward will need to use MODX 1.2.0. Any MODs using old versions of MODX will be denied. All MODs submitted before the time of this announcement will not be denied for using an old version of MODX.

Find out more about MODX by visiting our MODX Resource Centre. We are currently in the process of updating our documentation. Please be patient. The current online MODX/Text MOD Converter isn't using MODX 1.2.0.
Eric

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: MODX 1.2.0 Released

Post by primehalo » Mon Jun 02, 2008 11:26 pm

I love the addition of the link tag, that should come in handy, especially for the people who don't realize additional instructions can be found in the templates directory.
New files should always be placed in the root/ directory, also for the non english languages and non prosilver templates.
Thank you for implementing this policy!
Optional install files/instructions should be placed within the contrib directory. Additional required instructions should be placed in the root directory or in directory called named xml/
Does this mean that the previous instructions for other templates should now be placed in the "contrib" folder (/contrib/subsilver2.xml) rather than the "templates" folder (/templates/subsilver2.xml)?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

pgarvin76
Registered User
Posts: 136
Joined: Sun Mar 20, 2005 5:33 am
Location: Philadelphia, USA
Contact:

Re: MODX 1.2.0 Released

Post by pgarvin76 » Tue Jun 03, 2008 3:22 pm

After replacing the 1.1 version of modx.prosilver.en.xsl with the 1.2 version my xml files are not displaying anymore. In IE it displays all the text inside the tags with no HTML and Firefox just displays a blank page. No errors on either one. My untrained eye doesn't see anything obvious out of place. Ideas?

User avatar
A_Jelly_Doughnut
Former Team Member
Posts: 34452
Joined: Sat Jan 18, 2003 1:26 am
Location: Where the Rivers Run
Contact:

Re: MODX 1.2.0 Released

Post by A_Jelly_Doughnut » Tue Jun 03, 2008 3:36 pm

pgarvin76: Did you also change the URL to the xsd file in the first few lines of your xml file? It should say 1.2.0.xsd, not 1.0.1.xsd

primehalo: The subsilver2.xml file should not be in either of those directories. You can place it nearly anywhere you want, as long as it is linked from the main MODX file. Our sample shows it in the same directory as the main MODX file.
A Donut's Blog
"Bach's Prelude (Cello Suite No. 1) is driving Indiana country roads in Autumn" - Ann Kish

pgarvin76
Registered User
Posts: 136
Joined: Sun Mar 20, 2005 5:33 am
Location: Philadelphia, USA
Contact:

Re: MODX 1.2.0 Released

Post by pgarvin76 » Tue Jun 03, 2008 5:20 pm

A_Jelly_Doughnut wrote:pgarvin76: Did you also change the URL to the xsd file in the first few lines of your xml file? It should say 1.2.0.xsd, not 1.0.1.xsd
Thanks Jelly that worked.

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: MODX 1.2.0 Released

Post by primehalo » Wed Jun 04, 2008 8:45 am

I noticed some issues with the new modx.prosilver.en.xsl:
Screenshot 1:
Image

Screenshot 2:
Image

This is on Windows XP using Firefox 2.0.0.14. Are these known issues that will be fixed shortly, or should I submit a bug report?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24493
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: MODX 1.2.0 Released

Post by Paul » Wed Jun 04, 2008 11:15 am

The padding issues are known (We havent found a solution for it, if someone, please submit it to the bugtracker), please submit the rest as the things as bug to the website bugtracker.
THanks :).
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
A_Jelly_Doughnut
Former Team Member
Posts: 34452
Joined: Sat Jan 18, 2003 1:26 am
Location: Where the Rivers Run
Contact:

Re: MODX 1.2.0 Released

Post by A_Jelly_Doughnut » Wed Jun 04, 2008 1:42 pm

The separator dots is probably your MOD ... the dots are intended to be a part of the version tags (target-version, version, and the like)

The wrapping is the way I intended it. This is the only way I found to allow line-breaks to be kept when the author enters them by hand.
A Donut's Blog
"Bach's Prelude (Cello Suite No. 1) is driving Indiana country roads in Autumn" - Ann Kish

User avatar
Culprit
Registered User
Posts: 356
Joined: Fri Oct 22, 2004 8:43 am
Location: prague
Contact:

Lose language selector

Post by Culprit » Wed Jun 04, 2008 7:14 pm

When I don't use sql tag statement in install package file I lose the language selector and all languages are currently displayed.

SQL tag in action-group is required for displaying the install language selector.
Image

User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24493
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Lose language selector

Post by Paul » Wed Jun 04, 2008 7:41 pm

Culprit wrote:When I don't use sql tag statement in install package file I lose the language selector and all languages are currently displayed.

SQL tag in action-group is required for displaying the install language selector.
Please report bugs in MODX at www.phpbb.com/bugs/website/ so we have them all at a central place and we can fix them, thanks :).
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: MODX 1.2.0 Released

Post by primehalo » Wed Jun 04, 2008 9:28 pm

I'm almost done correcting all the issues, but now I also noticed that the language selection dropdown was hidden from view making it unselectable. I re-enabled it and it seems to work fine, so my question is why was this done?

EDIT: Nevermind, I see it was unintentional. Just a Javascript error that caused the language selection to remain hidden.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: MODX 1.2.0 Released

Post by primehalo » Thu Jun 05, 2008 12:22 am

Okay, I've fixed up the modx.prosilver.en.xsl to correct all of the issues pointed out in my screenshots, plus several more that I discovered. It's a long file, so instead of posting the contents I'll just provide a link to a couple of my MODs that include the new modx.prosilver.en.xsl file:
Prime BBCode Spoiler
Prime Birthdate

I noticed the size of the font increased in this version. I didn't know if that was intentional or not, so I just kept it as is (except for the MOD history, which I made smaller like it was in the previous file). Also, I'm not sure how that database dropdown list is supposed to be used.

Edit: I didn't update the version number on the modx.prosilver.en.xsl file because I don't know what the policy is on that.

Edit 2:
Here are some of the other bugs that were fixed:
  • Internet Explorer 7 would stretch the <pre> box for long lines instead of displaying scrollbars (to fix I added a width of 100% to the <pre> tag's CSS).
  • Internet Explorer 7 does not allow the opening of the external language files when trying to switch languages (used a try/catch to prevent an error message from popping up, and disabled the dropdown box).
  • Internet Explorer 7 would display a blank line next to each number (above each copy instruction) in the list of files to copy (to fix I applied width:100% to the dl tag's CSS)
  • Database dropdown box would display even when there were no options (hid the dropdown box for this case).
  • JavaScript bug that would prevent the language selection from showing up
And now a question: how come we're now writing versions as 0.0.0 instead of the previous:

Code: Select all

<major>0</major>
<minor>0</minor>
<revision>0</revision>
Wouldn't this cause a problem with this bit of xml scripting:

Code: Select all

<xsl:if test="substring(current(), 3, 1) mod 2 != 0 or substring(current(), 0, 1) = 0">
What if the first or second number is two digits, like 10.0.0? Seems like we'd have to break that version string into its components before doing comparisons.

Another question: in the Additional MODX Files section, how come language codes are placed at the beginning of each line?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
A_Jelly_Doughnut
Former Team Member
Posts: 34452
Joined: Sat Jan 18, 2003 1:26 am
Location: Where the Rivers Run
Contact:

Re: MODX 1.2.0 Released

Post by A_Jelly_Doughnut » Thu Jun 05, 2008 4:02 pm

primehalo,

Thanks for your work :)

I'm not running my primary computer at the moment, and it appears this one doesn't even have a .zip unpacker installed on this one (I guess my parents don't download much stuff).

Regarding your question with a 10.0.0 version, you're correct that it would break. I don't recall seeing a strpos() equivalent within the XSL toolkit. I suppose it could be done in Javascript, though.

The language code is supposed to appear whenever no language has been chosen via the dropdown. It is similar behavior to the title and description fields.
A Donut's Blog
"Bach's Prelude (Cello Suite No. 1) is driving Indiana country roads in Autumn" - Ann Kish

User avatar
primehalo
Former Team Member
Posts: 2780
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: MODX 1.2.0 Released

Post by primehalo » Thu Jun 05, 2008 9:26 pm

A_Jelly_Doughnut wrote:primehalo,

Thanks for your work :)

I'm not running my primary computer at the moment, and it appears this one doesn't even have a .zip unpacker installed on this one (I guess my parents don't download much stuff).

Regarding your question with a 10.0.0 version, you're correct that it would break. I don't recall seeing a strpos() equivalent within the XSL toolkit. I suppose it could be done in Javascript, though.

The language code is supposed to appear whenever no language has been chosen via the dropdown. It is similar behavior to the title and description fields.
It would be easy enough to write a JavaScript function to parse the version number, but I don't know enough about XSL scripting to be able to incorporate a JavaScript function into the XSL test condition. How does one accomplish that?

I don't understand what you're saying about the language code. I don't see it showing up next to the Title or Description, or anywhere else for that matter other than in the Additional MODX Files section. I know they need to be inside the xml tags to indicate the language of the text between the tags, but I don't see why the language code actually needs to be made visible on the lines of the Additional MODX Files section.

Also, have you noticed that the language selection doesn't work in IE7 and Opera? Apparently there browsers don't provide the permissions to access files from external hosts.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
A_Jelly_Doughnut
Former Team Member
Posts: 34452
Joined: Sat Jan 18, 2003 1:26 am
Location: Where the Rivers Run
Contact:

Re: MODX 1.2.0 Released

Post by A_Jelly_Doughnut » Fri Jun 06, 2008 12:47 pm

primehalo wrote: It would be easy enough to write a JavaScript function to parse the version number, but I don't know enough about XSL scripting to be able to incorporate a JavaScript function into the XSL test condition. How does one accomplish that?
I believe it would be done by calling a JS function and making the function handle all of the output, but I'm not certain myself.

Here is an example of what I mean about the languages: http://otherfiles.maxthon.cz/phpbb/modx ... nstall.xml
If there were a dropdown present, you'd select the language you want (say english) and the cs entries would go away.

And yeah, we're aware of the difficulties with IE and Opera. The only real workaround would be to generate a MODX stylesheet for every language that we have a translation for at the moment, and require all of them to be packaged in the MOD (so that the files are all local, not across domains). Or host all of the MODs at phpBB.com so that the files are all at phpBB.com. The current way is probably preferable (we don't want to make MOD authors package all those translations, and we want people to be able to install MODs offline).
A Donut's Blog
"Bach's Prelude (Cello Suite No. 1) is driving Indiana country roads in Autumn" - Ann Kish

Locked

Return to “[3.0.x] MOD Writers Discussion”

Who is online

Users browsing this forum: No registered users and 20 guests