Simply Merge Threads

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in here. No new MODs will be accepted into the MOD Database for phpBB2
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.

Rating:

Excellent!
64
52%
Very Good
25
20%
Good
14
11%
Fair
6
5%
Poor
15
12%
 
Total votes: 124

queengeek
Registered User
Posts: 17
Joined: Fri Sep 07, 2007 8:40 pm

Re: [2.0.6] Simply Merge Threads

Post by queengeek » Tue Oct 16, 2007 6:47 am

Thanks Sentinel milk and cookies to you!

User avatar
Sylver Cheetah 53
I've Been Banned!
Posts: 126
Joined: Sat Nov 24, 2007 1:44 pm
Location: Milky Way
Contact:

Re: [2.0.6] Simply Merge Threads

Post by Sylver Cheetah 53 » Sun Nov 25, 2007 2:31 pm

Okay. First of all, this is not a bit an simple MOD, like the title sais! And it's not the first MOD I install, so...

Second, I don't understand the point of Lang Settings and Topic List being there. I don't think anyone is using those MOD's, I don't use them, I don't intend using them so it's useless... By mistake, I did some modifications regarding those useless MODs and then my forum wasn't working anymore. I think I would be able to change only what should be change for this MOD to work, but I still can understand how the author thinked when whriting the instructions... I have like 10-20 MODs installed, and I think many of you guys have many more, but I don't see the point of an MOD author including every stupid MOD in his MODification.
Sorry for being maybe a bit rude, but I simply don't understand...

P.S.: If someone has an "clean" version of install notes for this MOD, I would be happy having them.
P.P.S.: I advice the phpBB Team not to validate this MOD!

User avatar
A_O_C
Registered User
Posts: 2383
Joined: Sun Jul 01, 2007 11:26 pm
Location: phpbb_

Re: [2.0.6] Simply Merge Threads

Post by A_O_C » Sun Nov 25, 2007 3:23 pm

Sylver Cheetah 53 wrote:If someone has an "clean" version of install notes for this MOD, I would be happy having them.
i can understand your frustration becuase i too use this mod, so when i downloaded the mod (a long time ago), i striped it "clean" (to use your choice of words). you can download it here.


Sylver Cheetah 53 wrote:I advice the phpBB Team not to validate this MOD!
a little late arent you? didnt you realize this topic is in the [2.0.x] MOD Database Releases?

User avatar
Sylver Cheetah 53
I've Been Banned!
Posts: 126
Joined: Sat Nov 24, 2007 1:44 pm
Location: Milky Way
Contact:

Re: [2.0.6] Simply Merge Threads

Post by Sylver Cheetah 53 » Mon Nov 26, 2007 11:41 am

Weel, I've seen this...
Nuttzy99 wrote:Again, this MOD was not thoroughly validated, but we are make a one-time exception.

-Nuttzy :cool:
Anyway, I've taken your "clean" version of this MOD, even that I don't think I'll use it anymore. I've found a bug fix for Split and Merge in One Step, and now I can check also the first post in a thread. So now this "simple" MOD is useless. (from my point of view)

User avatar
leviatan21
Registered User
Posts: 2663
Joined: Fri Aug 10, 2007 7:22 am
Location: Buenos Aires, Argentina
Name: Gabriel

Re: [2.0.6] Simply Merge Threads

Post by leviatan21 » Sat Dec 08, 2007 6:07 pm

A_O_C wrote:i can understand your frustration becuase i too use this mod, so when i downloaded the mod (a long time ago), i striped it "clean" (to use your choice of words). you can download it here.
Thanks A_O_C, I just intall it.
Xclavo wrote:What are the Select buttons for ?
Bramster wrote:I installed the mod and after lots of bug hunting it finally works.
But shouldn't I get a pull down menu or something in the areas I marked in red ?
Image
When clicking the select button I get the message No topics or posts met your search criteria :(
Also the option New Topic Title seems broken
Any suggestions ?
I realized that those option dosen't work on my board, I think that it will do a pull-down with the topics titles, so you can choose the "from_topic" & "to_topic"
So I decide to make my own "function select_topic()" to display a pull-down menú.

If someone want the solution, ask for it !
Excuse me for my poor English, I speak Spanish. | Image phpBB en Español

User avatar
A_O_C
Registered User
Posts: 2383
Joined: Sun Jul 01, 2007 11:26 pm
Location: phpbb_

Re: [2.0.6] Simply Merge Threads

Post by A_O_C » Sat Dec 08, 2007 11:57 pm

does it work on just the forum you are in? or ALL topics on the board?


leviatan21 wrote:If someone want the solution, ask for it !
you know someone is going to ask for it, so why dont you just post it anyway? i might not keep it, but i would like to throw it on my testserver just for fun. ;)

User avatar
leviatan21
Registered User
Posts: 2663
Joined: Fri Aug 10, 2007 7:22 am
Location: Buenos Aires, Argentina
Name: Gabriel

Re: [2.0.6] Simply Merge Threads

Post by leviatan21 » Sun Dec 09, 2007 4:05 am

A_O_C wrote:does it work on just the forum you are in? or ALL topics on the board?
the pull-down displays a list of all topics titles preceded by his ID, separated by the names of the forums preceded by his ID.
A_O_C wrote:you know someone is going to ask for it, so why dont you just post it anyway? i might not keep it, but i would like to throw it on my testserver just for fun. ;)
Ok, here it is.

Once you install the "clean" mod (here)

*EDIT* fixed...

Code: Select all

#
#-----[ DIY INSTRUCTIONS ]------------------------------------------
#
If you want delete the file "templates/subSilver/merge_select_body.tpl" we don't need any more.

#
#-----[ OPEN ]-------------------------
#
merge.php

#
#-----[ DIY INSTRUCTIONS ]------------------------------------------
#
All the code since 
// selection
to 
// submission
Must be deleted

#
#-----[ FIND ]-------------------------
#
	'L_SEARCH'				=> $lang['Select'],

#
#-----[ AFTER, ADD ]-------------------------
#
	'S_JUMPBOX_SELECT_1'    => select_topic('from_topic',$from_topic),
	'S_JUMPBOX_SELECT_2'    => select_topic('to_topic',$to_topic),

#
#-----[ FIND ]-------------------------
#
include($phpbb_root_path . 'includes/page_tail.'.$phpEx);

#
#-----[ AFTER, ADD ]-------------------------
#
function select_topic($action, $match_topic_id = 0)
{
	global $userdata, $lang, $db, $phpEx, $SID;

	$sql = "SELECT t.topic_id, t.topic_title, t.forum_id
		FROM " . TOPICS_TABLE . " t, " . FORUMS_TABLE . " f
		WHERE f.forum_id = t.forum_id
		GROUP BY t.forum_id, t.topic_id, t.topic_title";
	if ( !($result = $db->sql_query($sql)) )
	{
		message_die(GENERAL_ERROR, "Couldn't obtain topics list.", "", __LINE__, __FILE__, $sql);
	}
	
	$topic_rows = array();
	while ( $row = $db->sql_fetchrow($result) )
	{
		$topic_rows[] = $row;
	}

	if ( $total_topics = count($topic_rows) )
	{
		$sql = "SELECT *
			FROM " . FORUMS_TABLE . "
			ORDER BY forum_id, forum_order";
		if ( !($result = $db->sql_query($sql)) )
		{
			message_die(GENERAL_ERROR, 'Could not obtain forums information', '', __LINE__, __FILE__, $sql);
		}

		$forum_rows = array();
		while ( $row = $db->sql_fetchrow($result) )
		{
			$forum_rows[] = $row;
		}

		$boxstring = '<select name="' . POST_FORUM_URL . '" onchange="if(this.options[this.selectedIndex].value != -1){ ' . $action . '.value = this.options[this.selectedIndex].value }"><option value="-1">' . $lang['Merge_Select_topic'] . '</option>';
		if ( $total_forums = count($forum_rows) )
		{
			for($i = 0; $i < $total_forums; $i++)
			{
				$boxstring_topics = '';
				for($j = 0; $j < $total_topics; $j++)
				{
					if ( $topic_rows[$j]['forum_id'] == $forum_rows[$i]['forum_id'] && $forum_rows[$i]['auth_view'] <= AUTH_REG )
					{
						$selected = ( $topic_rows[$j]['topic_id'] == $match_topic_id ) ? 'selected="selected"' : '';
						$boxstring_topics .=  '<option value="' . $topic_rows[$j]['topic_id'] . '"' . $selected . '>(' . $topic_rows[$j]['topic_id'] . ')&nbsp;' . $topic_rows[$j]['topic_title'] . '</option>';
					}
				}

				if ( $boxstring_topics != '' )
				{
					$boxstring .= '<option value="-1">&nbsp;</option>';
					$boxstring .= '<option value="-1">(' . $forum_rows[$i]['forum_id'] . ')&nbsp;' . $forum_rows[$i]['forum_name'] . '</option>';
					$boxstring .= '<option value="-1">----------------</option>';
					$boxstring .= $boxstring_topics;
				}
			}
		}
		$boxstring .= '</select>';
	}
	else
	{
		$boxstring .= '<select name="' . POST_FORUM_URL . '" onchange="if(this.options[this.selectedIndex].value != -1){ to_topic.value = this.options[this.selectedIndex].value }"></select>';
	}

	$boxstring .= '<input type="hidden" name="sid" value="' . $userdata['session_id'] . '" />';

	return $boxstring;
}

#
#-----[ OPEN ]-------------------------
#
templates/subSilver/merge_body.tpl

#
#-----[ FIND ]-------------------------
#
<input type="submit" class="liteoption" name="select_from" value="{L_SEARCH}" />

#
#-----[ REPLACE , WITH ]-------------------------
#
</span> &nbsp; <span class="gensmall">{S_JUMPBOX_SELECT_1}

#
#-----[ FIND ]-------------------------
#
<input type="submit" class="liteoption" name="select_to" value="{L_SEARCH}" />

#
#-----[ REPLACE , WITH ]-------------------------
#
</span> &nbsp; <span class="gensmall">{S_JUMPBOX_SELECT_2}

#
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------
#
# EoM
I hope I have been clear.
Last edited by leviatan21 on Sun Dec 09, 2007 5:28 am, edited 1 time in total.
Excuse me for my poor English, I speak Spanish. | Image phpBB en Español

User avatar
A_O_C
Registered User
Posts: 2383
Joined: Sun Jul 01, 2007 11:26 pm
Location: phpbb_

Re: [2.0.6] Simply Merge Threads

Post by A_O_C » Sun Dec 09, 2007 4:17 am

leviatan21 wrote:the pull-down displays a list of all topics titles preceded by his ID, separated by the names of the forums preceded by his ID... I hope I have been clear...
the instructions are clear to me, what isnt clear is the sentence i quoted. what i think you are trying to say is that if my topic id is 5, the pull-down will list the topic titles for topic id 4, 3, 2, and 1? --goes off to install addon--

User avatar
leviatan21
Registered User
Posts: 2663
Joined: Fri Aug 10, 2007 7:22 am
Location: Buenos Aires, Argentina
Name: Gabriel

Re: [2.0.6] Simply Merge Threads

Post by leviatan21 » Sun Dec 09, 2007 4:46 am

A_O_C wrote:
leviatan21 wrote:the pull-down displays a list of all topics titles preceded by his ID, separated by the names of the forums preceded by his ID... I hope I have been clear...
the instructions are clear to me, what isnt clear is the sentence i quoted. what i think you are trying to say is that if my topic id is 5, the pull-down will list the topic titles for topic id 4, 3, 2, and 1? --goes off to install addon--
In the pull-down you will see:

Code: Select all

Select a Topic
(1) Forum one title
-----------------
(1) Topic one title
(2) Topic two title
(3) Topic tree title

(2) Forum two title
-----------------
(4) Topic four title
(5) Topic five title
(6) Topic six title

(3) Forum tree title
-----------------
(7) Topic seven title
(8) Topic eight title
(9) Topic nine title
Excuse me for my poor English, I speak Spanish. | Image phpBB en Español

User avatar
A_O_C
Registered User
Posts: 2383
Joined: Sun Jul 01, 2007 11:26 pm
Location: phpbb_

Re: [2.0.6] Simply Merge Threads

Post by A_O_C » Sun Dec 09, 2007 5:06 am

:(
Fatal error: Call to undefined function sync() in C:\AppServ\www\merge.php on line 533

User avatar
A_O_C
Registered User
Posts: 2383
Joined: Sun Jul 01, 2007 11:26 pm
Location: phpbb_

Re: [2.0.6] Simply Merge Threads

Post by A_O_C » Sun Dec 09, 2007 5:09 am

it will show the topics as merged, but not before i get the error above

*EDIT* fixed... comment out this code...

Code: Select all

		// synchronise the destination topic, and the both forums
		sync('topic', $to_topic_id);
		if ($from_forum_id != $to_forum_id) sync('forum', $from_forum_id);
		sync('forum', $to_forum_id);

User avatar
leviatan21
Registered User
Posts: 2663
Joined: Fri Aug 10, 2007 7:22 am
Location: Buenos Aires, Argentina
Name: Gabriel

Re: [2.0.6] Simply Merge Threads

Post by leviatan21 » Sun Dec 09, 2007 5:27 am

A_O_C wrote:it will show the topics as merged, but not before i get the error above

*EDIT* fixed... comment out this code...

Code: Select all

		// synchronise the destination topic, and the both forums
		sync('topic', $to_topic_id);
		if ($from_forum_id != $to_forum_id) sync('forum', $from_forum_id);
		sync('forum', $to_forum_id);
:oops: Sorry it's my mistake, the "function sync" is from "includes/functions_admin"
so

Code: Select all

#
#-----[ OPEN ]-------------------------
#
merge.php

#
#-----[ FIND ]-------------------------
#
//include($phpbb_root_path . 'includes/functions_admin.'.$phpEx);
#
#-----[ REPLACE , WITH ]-------------------------
#
include($phpbb_root_path . 'includes/functions_admin.'.$phpEx);
Sorry again
(I will edit my post before and fix it)
Excuse me for my poor English, I speak Spanish. | Image phpBB en Español

User avatar
Sylver Cheetah 53
I've Been Banned!
Posts: 126
Joined: Sat Nov 24, 2007 1:44 pm
Location: Milky Way
Contact:

Re: [2.0.6] Simply Merge Threads

Post by Sylver Cheetah 53 » Thu Dec 20, 2007 8:59 pm

Can this trick be used somehow on Split and Merge in One Step MOD? :?

User avatar
leviatan21
Registered User
Posts: 2663
Joined: Fri Aug 10, 2007 7:22 am
Location: Buenos Aires, Argentina
Name: Gabriel

Re: [2.0.6] Simply Merge Threads

Post by leviatan21 » Thu Dec 20, 2007 9:31 pm

Sylver Cheetah 53 wrote:Can this trick be used somehow on Split and Merge in One Step MOD? :?
Bringme a link to that mod and I will see how mix my fix .
Excuse me for my poor English, I speak Spanish. | Image phpBB en Español


Post Reply

Return to “[2.0.x] MOD Database Releases”