Log IP Address on Registration

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in here. No new MODs will be accepted into the MOD Database for phpBB2
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Post Reply

Rating:

Excellent!
112
78%
Very Good
16
11%
Good
8
6%
Fair
3
2%
Poor
4
3%
 
Total votes: 143

TerraFrost
Former Team Member
Posts: 5957
Joined: Sun Dec 26, 2004 3:40 am
Location: Austin, TX

Post by TerraFrost » Sun Aug 07, 2005 8:57 pm

You wouldn't happen to be the one who gave this MOD a poor rating, would you?

In any case, try doing what 4rum suggested and then posting the exact output here, in this thread. Doing so will prove, once and for all, whether or not the column was created. If it turns out the column was created (something that not even I am convinced of, actually), that'll also better inspire people to look for alternative solutions (whatever those solutions may be...)

ALLMIGHTYGOD
I've Been Banned!
Posts: 34
Joined: Mon Oct 25, 2004 4:58 pm

Post by ALLMIGHTYGOD » Mon Aug 08, 2005 9:28 am

dear TerraFrost,

you got me...

You wouldn't happen to be the one who gave this MOD a poor rating, would you?


You are not somebody who likes to get good ratings but canT cope with poor rating or critics, aren't you? If the rating would have one opinion only it wouldnt be a rating, would it?

What kind of grade would you give s.th. which doesnT work on your server?! :)

In case it get it working 2day - i' ll rate it again... :oops:


*greets*

Allmightygod
DO NOT MAKE YOUR PROBLEMS TO MINE
OR

I DO NOT SEE THERE A PROBLEM; and if there schould be one- it is DEFENTLEY NOT MINE!

ALLMIGHTYGOD
I've Been Banned!
Posts: 34
Joined: Mon Oct 25, 2004 4:58 pm

Post by ALLMIGHTYGOD » Mon Aug 08, 2005 10:03 am

allrite, allrite... shame on me

it really was my fault....

8)


thx 4 ur help and TERRAFROST---> GREAT MOD!

would rate again, but canT * :: -- ))

nice life everyone...
DO NOT MAKE YOUR PROBLEMS TO MINE
OR

I DO NOT SEE THERE A PROBLEM; and if there schould be one- it is DEFENTLEY NOT MINE!

ALLMIGHTYGOD
I've Been Banned!
Posts: 34
Joined: Mon Oct 25, 2004 4:58 pm

i 4 got

Post by ALLMIGHTYGOD » Mon Aug 08, 2005 10:13 am

hi again,
another question melman has:

is it possible to say at the END OF REGISTRATION:E.g.
Your IP Adress was xxxx
? That would be cool; what do I have to do for this?!

later
DO NOT MAKE YOUR PROBLEMS TO MINE
OR

I DO NOT SEE THERE A PROBLEM; and if there schould be one- it is DEFENTLEY NOT MINE!

TerraFrost
Former Team Member
Posts: 5957
Joined: Sun Dec 26, 2004 3:40 am
Location: Austin, TX

Post by TerraFrost » Mon Aug 08, 2005 1:31 pm

Code: Select all

#
#-----[ OPEN ]------------------------------------------
#
includes/usercp_register.php
#
#-----[ FIND ]------------------------------------------
#
				$message = $lang['Account_added'];
#
#-----[ AFTER, ADD ]------------------------------------
#
				$message .= "Your Registration IP was " . decode_ip($userdata['session_ip']);
Untested, but it should work. Anyway, if you'd like something more easily translateable, let me know.
Last edited by TerraFrost on Mon Aug 08, 2005 6:28 pm, edited 1 time in total.

ALLMIGHTYGOD
I've Been Banned!
Posts: 34
Joined: Mon Oct 25, 2004 4:58 pm

Post by ALLMIGHTYGOD » Mon Aug 08, 2005 3:55 pm

thx 4 that TerraFrost

it doens't show up in the information Text, tho..

but maybe someone can test it and find out why the "ip Text" doesnT appear!

*greets*[/b]
DO NOT MAKE YOUR PROBLEMS TO MINE
OR

I DO NOT SEE THERE A PROBLEM; and if there schould be one- it is DEFENTLEY NOT MINE!

kornhead
Registered User
Posts: 72
Joined: Sun Jun 12, 2005 4:36 pm
Location: Russia
Contact:

Post by kornhead » Mon Aug 08, 2005 6:09 pm

By the time I've installed this mod I've already had 90 (or smth around) users, and their ip is 0.0.0.0, so is it posible for them to change their 0.0.0.0 ip on the ip under which they will login next time?

TerraFrost
Former Team Member
Posts: 5957
Joined: Sun Dec 26, 2004 3:40 am
Location: Austin, TX

Post by TerraFrost » Mon Aug 08, 2005 6:28 pm

ALLMIGHTYGOD wrote: thx 4 that TerraFrost

it doens't show up in the information Text, tho..

but maybe someone can test it and find out why the "ip Text" doesnT appear!

*greets*[/b]

Sorry - that was a mistake in the code I posted in my earlier post (well, assuming I understood the problem correctly, heh). This mistake has since been corrected. As such, I'd recommend just undoing that addition and redoing it with the code in that post.
By the time I've installed this mod I've already had 90 (or smth around) users, and their ip is 0.0.0.0, so is it posible for them to change their 0.0.0.0 ip on the ip under which they will login next time?

nikosama posted a MOD that does that. It can be found here:
http://www.phpbb.com/phpBB/viewtopic.ph ... 49#1693449

ALLMIGHTYGOD
I've Been Banned!
Posts: 34
Joined: Mon Oct 25, 2004 4:58 pm

Post by ALLMIGHTYGOD » Tue Aug 09, 2005 9:18 am

thx 4 that TerraFrost

it doens't show up in the information Text, tho..

but maybe someone can test it and find out why the "ip Text" doesnT appear!

*greets*[/b]

Sorry - that was a mistake in the code I posted in my earlier post (well, assuming I understood the problem correctly, heh). This mistake has since been corrected. As such, I'd recommend just undoing that addition and redoing it with the code in that post.


hmmm..the IP just doens't want to show up; donT know what I am doing wrong... :(

But there is NO ERROR message; the registrations work fine

only changed this:
-[ OPEN ]------------------------------------------
#
includes/usercp_register.php
#
#-----[ FIND ]------------------------------------------
#
$message = $lang['Account_added'];
#
#-----[ AFTER, ADD ]------------------------------------
#
$message .= "Your Registration IP was " . decode_ip($userdata['session_ip']);


maybe u finde my mistake..

thx
DO NOT MAKE YOUR PROBLEMS TO MINE
OR

I DO NOT SEE THERE A PROBLEM; and if there schould be one- it is DEFENTLEY NOT MINE!

ALLMIGHTYGOD
I've Been Banned!
Posts: 34
Joined: Mon Oct 25, 2004 4:58 pm

Post by ALLMIGHTYGOD » Tue Aug 09, 2005 11:33 pm

in case u donT have newest version of phpbb

here ist the old text with the mod

Code: Select all

<?php
/***************************************************************************
 *                                login.php
 *                            -------------------
 *   begin                : Saturday, Feb 13, 2001
 *   copyright            : (C) 2001 The phpBB Group
 *   email                : support@phpbb.com
 *
 *   $Id: login.php,v 1.47.2.16 2004/07/17 13:48:32 acydburn Exp $
 *
 *

cu
 ***************************************************************************/

/***************************************************************************
 *
 *   This program is free software; you can redistribute it and/or modify
 *   it under the terms of the GNU General Public License as published by
 *   the Free Software Foundation; either version 2 of the License, or
 *   (at your option) any later version.
 *
 ***************************************************************************/

//
// Allow people to reach login page if
// board is shut down
//
define("IN_LOGIN", true);

define('IN_PHPBB', true);
$phpbb_root_path = './';
include($phpbb_root_path . 'extension.inc');
include($phpbb_root_path . 'common.'.$phpEx);

//
// Set page ID for session management
//
$userdata = session_pagestart($user_ip, PAGE_LOGIN);
init_userprefs($userdata);
//
// End session management
//

// session id check
if (!empty($HTTP_POST_VARS['sid']) || !empty($HTTP_GET_VARS['sid']))
{
	$sid = (!empty($HTTP_POST_VARS['sid'])) ? $HTTP_POST_VARS['sid'] : $HTTP_GET_VARS['sid'];
}
else
{
	$sid = '';
}

if( isset($HTTP_POST_VARS['login']) || isset($HTTP_GET_VARS['login']) || isset($HTTP_POST_VARS['logout']) || isset($HTTP_GET_VARS['logout']) )
{
	if( ( isset($HTTP_POST_VARS['login']) || isset($HTTP_GET_VARS['login']) ) && !$userdata['session_logged_in'] )
	{
		$username = isset($HTTP_POST_VARS['username']) ? trim(htmlspecialchars($HTTP_POST_VARS['username'])) : '';
		$username = substr(str_replace("\\'", "'", $username), 0, 25);
		$username = str_replace("'", "\\'", $username);
		$password = isset($HTTP_POST_VARS['password']) ? $HTTP_POST_VARS['password'] : '';

		$sql = "SELECT user_id,  user_regip, username, user_password, user_active, user_level
			FROM " . USERS_TABLE . "
			WHERE username = '" . str_replace("\\'", "''", $username) . "'";
		if ( !($result = $db->sql_query($sql)) )
		{
			message_die(GENERAL_ERROR, 'Error in obtaining userdata', '', __LINE__, __FILE__, $sql);
		}

		if( $row = $db->sql_fetchrow($result) )
		{
			if( $row['user_level'] != ADMIN && $board_config['board_disable'] )
			{
				redirect(append_sid("index.$phpEx", true));
			}
			else
			{
				if( md5($password) == $row['user_password'] && $row['user_active'] )
				{
					$autologin = ( isset($HTTP_POST_VARS['autologin']) ) ? TRUE : 0;

					$session_id = session_begin($row['user_id'], $user_ip, PAGE_INDEX, FALSE, $autologin); // Mod:RecordIPifZero mod by niko
if ( ($row['user_regip']) == '0' )
{
// non zero user id should never happen
if ( $row['user_id'] )
{
$sql = "UPDATE " . USERS_TABLE . " SET user_regip = '$user_ip' WHERE user_id = '" .

$row['user_id'] . "'";
if ( !$db->sql_query($sql) )
{
message_die(CRITICAL_ERROR, "RecordIPifZero mod: Error during update of user_regip",

"", __LINE__, __FILE__);
}
}
}
// end RecordIPifZero mod by niko 

					if( $session_id )
					{
						$url = ( !empty($HTTP_POST_VARS['redirect']) ) ? str_replace('&', '&', htmlspecialchars($HTTP_POST_VARS['redirect'])) : "index.$phpEx";
						redirect(append_sid($url, true));
					}
					else
					{
						message_die(CRITICAL_ERROR, "Couldn't start session : login", "", __LINE__, __FILE__);
					}
				}
				else
				{
					$redirect = ( !empty($HTTP_POST_VARS['redirect']) ) ? str_replace('&', '&', htmlspecialchars($HTTP_POST_VARS['redirect'])) : '';
					$redirect = str_replace('?', '&', $redirect);

					if (strstr(urldecode($redirect), "\n") || strstr(urldecode($redirect), "\r"))
					{
						message_die(GENERAL_ERROR, 'Tried to redirect to potentially insecure url.');
					}

					$template->assign_vars(array(
						'META' => "<meta http-equiv=\"refresh\" content=\"3;url=login.$phpEx?redirect=$redirect\">")
					);

					$message = $lang['Error_login'] . '<br /><br />' . sprintf($lang['Click_return_login'], "<a href=\"login.$phpEx?redirect=$redirect\">", '</a>') . '<br /><br />' .  sprintf($lang['Click_return_index'], '<a href="' . append_sid("index.$phpEx") . '">', '</a>');

					message_die(GENERAL_MESSAGE, $message);
				}
			}
		}
		else
		{
			$redirect = ( !empty($HTTP_POST_VARS['redirect']) ) ? str_replace('&', '&', htmlspecialchars($HTTP_POST_VARS['redirect'])) : "";
			$redirect = str_replace("?", "&", $redirect);

			if (strstr(urldecode($redirect), "\n") || strstr(urldecode($redirect), "\r"))
			{
				message_die(GENERAL_ERROR, 'Tried to redirect to potentially insecure url.');
			}

			$template->assign_vars(array(
				'META' => "<meta http-equiv=\"refresh\" content=\"3;url=login.$phpEx?redirect=$redirect\">")
			);

			$message = $lang['Error_login'] . '<br /><br />' . sprintf($lang['Click_return_login'], "<a href=\"login.$phpEx?redirect=$redirect\">", '</a>') . '<br /><br />' .  sprintf($lang['Click_return_index'], '<a href="' . append_sid("index.$phpEx") . '">', '</a>');

			message_die(GENERAL_MESSAGE, $message);
		}
	}
	else if( ( isset($HTTP_GET_VARS['logout']) || isset($HTTP_POST_VARS['logout']) ) && $userdata['session_logged_in'] )
	{
		if( $userdata['session_logged_in'] )
		{
			session_end($userdata['session_id'], $userdata['user_id']);
		}

		if (!empty($HTTP_POST_VARS['redirect']) || !empty($HTTP_GET_VARS['redirect']))
		{
			$url = (!empty($HTTP_POST_VARS['redirect'])) ? htmlspecialchars($HTTP_POST_VARS['redirect']) : htmlspecialchars($HTTP_GET_VARS['redirect']);
			$url = str_replace('&', '&', $url);
			redirect(append_sid($url, true));
		}
		else
		{
			redirect(append_sid("index.$phpEx", true));
		}
	}
	else
	{
		$url = ( !empty($HTTP_POST_VARS['redirect']) ) ? str_replace('&', '&', htmlspecialchars($HTTP_POST_VARS['redirect'])) : "index.$phpEx";
		redirect(append_sid($url, true));
	}
}
else
{
	//
	// Do a full login page dohickey if
	// user not already logged in
	//
	if( !$userdata['session_logged_in'] )
	{
		$page_title = $lang['Login'];
		include($phpbb_root_path . 'includes/page_header.'.$phpEx);

		$template->set_filenames(array(
			'body' => 'login_body.tpl')
		);

		if( isset($HTTP_POST_VARS['redirect']) || isset($HTTP_GET_VARS['redirect']) )
		{
			$forward_to = $HTTP_SERVER_VARS['QUERY_STRING'];

			if( preg_match("/^redirect=([a-z0-9\.#\/\?&=\+\-_]+)/si", $forward_to, $forward_matches) )
			{
				$forward_to = ( !empty($forward_matches[3]) ) ? $forward_matches[3] : $forward_matches[1];
				$forward_match = explode('&', $forward_to);

				if(count($forward_match) > 1)
				{
					$forward_page = '';

					for($i = 1; $i < count($forward_match); $i++)
					{
						if( !ereg("sid=", $forward_match[$i]) )
						{
							if( $forward_page != '' )
							{
								$forward_page .= '&';
							}
							$forward_page .= $forward_match[$i];
						}
					}
					$forward_page = $forward_match[0] . '?' . $forward_page;
				}
				else
				{
					$forward_page = $forward_match[0];
				}
			}
		}
		else
		{
			$forward_page = '';
		}

		$username = ( $userdata['user_id'] != ANONYMOUS ) ? $userdata['username'] : '';

		$s_hidden_fields = '<input type="hidden" name="redirect" value="' . $forward_page . '" />';

		make_jumpbox('viewforum.'.$phpEx, $forum_id);
		$template->assign_vars(array(
			'USERNAME' => $username,

			'L_ENTER_PASSWORD' => $lang['Enter_password'],
			'L_SEND_PASSWORD' => $lang['Forgotten_password'],

			'U_SEND_PASSWORD' => append_sid("profile.$phpEx?mode=sendpassword"),

			'S_HIDDEN_FIELDS' => $s_hidden_fields)
		);

		$template->pparse('body');

		include($phpbb_root_path . 'includes/page_tail.'.$phpEx);
	}
	else
	{
		redirect(append_sid("index.$phpEx", true));
	}

}

?>
DO NOT MAKE YOUR PROBLEMS TO MINE
OR

I DO NOT SEE THERE A PROBLEM; and if there schould be one- it is DEFENTLEY NOT MINE!

ALLMIGHTYGOD
I've Been Banned!
Posts: 34
Joined: Mon Oct 25, 2004 4:58 pm

Post by ALLMIGHTYGOD » Tue Aug 09, 2005 11:35 pm

ohh damn; wrong forum....

may delete it...
DO NOT MAKE YOUR PROBLEMS TO MINE
OR

I DO NOT SEE THERE A PROBLEM; and if there schould be one- it is DEFENTLEY NOT MINE!

bre
Registered User
Posts: 20
Joined: Sun Dec 08, 2002 4:31 am

Post by bre » Wed Aug 10, 2005 12:19 am

Will this work on 2.0.17? Has anyone tried it?

kornhead
Registered User
Posts: 72
Joined: Sun Jun 12, 2005 4:36 pm
Location: Russia
Contact:

Post by kornhead » Wed Aug 10, 2005 12:22 am

TerraFrost wrote:
By the time I've installed this mod I've already had 90 (or smth around) users, and their ip is 0.0.0.0, so is it posible for them to change their 0.0.0.0 ip on the ip under which they will login next time?

nikosama posted a MOD that does that. It can be found here:
http://www.phpbb.com/phpBB/viewtopic.ph ... 49#1693449

Great! Thanks a Lot! :P

TerraFrost
Former Team Member
Posts: 5957
Joined: Sun Dec 26, 2004 3:40 am
Location: Austin, TX

Post by TerraFrost » Wed Aug 10, 2005 7:35 pm

-[ OPEN ]------------------------------------------
#
includes/usercp_register.php
#
#-----[ FIND ]------------------------------------------
#
$message = $lang['Account_added'];
#
#-----[ AFTER, ADD ]------------------------------------
#
$message .= "Your Registration IP was " . decode_ip($userdata['session_ip']);


maybe u finde my mistake..

All I can say is that it works for me, on a virgin phpBB. After installing it, I see that it'd look better if there was a <br /> before the Y, but it does, never-the-less, work.

Anyway, it's possible that I'm not really understanding what you're wanting. Could you perhapes post an edited screenshot?
Will this work on 2.0.17? Has anyone tried it?

Yup, it does...

bre
Registered User
Posts: 20
Joined: Sun Dec 08, 2002 4:31 am

Post by bre » Thu Aug 11, 2005 11:44 am

Yes it does and thank you.

Not sure if its the mod but since I upgraded to 2.0.17 and installed the mod, I can't approve registrations. I used to be notified by email on new registrations and would just click on link in email and it would approve. Now I'm getting 'Not Authorised' and have to do approves manually.

Post Reply

Return to “[2.0.x] MOD Database Releases”