This is Only One Quote

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in here. No new MODs will be accepted into the MOD Database for phpBB2
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.

Rating:

Excellent!
11
61%
Very Good
3
17%
Good
1
6%
Fair
1
6%
Poor
2
11%
 
Total votes: 18

dvdd127
Registered User
Posts: 402
Joined: Fri Jan 13, 2006 12:35 am
Location: Chicago, IL

Re: This is Only One Quote

Post by dvdd127 » Sun Oct 28, 2007 1:02 pm

3Di wrote:
dvdd127 wrote:

Code: Select all

$message = preg_replace('/(\[quote=(.*?)\]((.|\n)*)\[\/quote\])/si',"", $message);
the code above causes a stack overflow.. any ideas how to fix it???
Would you mind please to PM me a link where to see that?
the website the problem is occurring on requires log in.. and I am pretty sure that it is a problem being caused because of php and mysql being out of date... because when I tried it on a server with php5 and mysql5 it worked fine... so we are going to update the server.. and if we still have problems i am going to post back.

thanks.
/DD

User avatar
3Di
Former Team Member
Posts: 14053
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: This is Only One Quote

Post by 3Di » Sun Oct 28, 2007 3:38 pm

dvdd127 wrote:
3Di wrote:
dvdd127 wrote:

Code: Select all

$message = preg_replace('/(\[quote=(.*?)\]((.|\n)*)\[\/quote\])/si',"", $message);
the code above causes a stack overflow.. any ideas how to fix it???
Would you mind please to PM me a link where to see that?
the website the problem is occurring on requires log in.. and I am pretty sure that it is a problem being caused because of php and mysql being out of date... because when I tried it on a server with php5 and mysql5 it worked fine... so we are going to update the server.. and if we still have problems i am going to post back.

thanks.
The present MOD has been developped and tested onto a localhost server running into a Win-XP based computer, to be accurate: easyphp1.8 has been used as the server (PHP and MySql versions are the ones built-in there). If by any chance you'll be able to post more details about the issue you above described it'll be nice.
Thanks
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

dvdd127
Registered User
Posts: 402
Joined: Fri Jan 13, 2006 12:35 am
Location: Chicago, IL

Re: This is Only One Quote

Post by dvdd127 » Sun Oct 28, 2007 4:35 pm

3Di wrote:
dvdd127 wrote:
3Di wrote:
dvdd127 wrote:

Code: Select all

$message = preg_replace('/(\[quote=(.*?)\]((.|\n)*)\[\/quote\])/si',"", $message);
the code above causes a stack overflow.. any ideas how to fix it???
Would you mind please to PM me a link where to see that?
the website the problem is occurring on requires log in.. and I am pretty sure that it is a problem being caused because of php and mysql being out of date... because when I tried it on a server with php5 and mysql5 it worked fine... so we are going to update the server.. and if we still have problems i am going to post back.

thanks.
The present MOD has been developped and tested onto a localhost server running into a Win-XP based computer, to be accurate: easyphp1.8 has been used as the server (PHP and MySql versions are the ones built-in there). If by any chance you'll be able to post more details about the issue you above described it'll be nice.
Thanks
there is not much more to it.. except that we are getting stack overflow errors when we try to quote SOME of the posts on our board...and i was able to narrow it down to that line of code being the issue.
/DD

User avatar
3Di
Former Team Member
Posts: 14053
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: This is Only One Quote

Post by 3Di » Sun Oct 28, 2007 5:05 pm

dvdd127 wrote:
3Di wrote:
dvdd127 wrote:
3Di wrote:
dvdd127 wrote:

Code: Select all

$message = preg_replace('/(\[quote=(.*?)\]((.|\n)*)\[\/quote\])/si',"", $message);
the code above causes a stack overflow.. any ideas how to fix it???
Would you mind please to PM me a link where to see that?
the website the problem is occurring on requires log in.. and I am pretty sure that it is a problem being caused because of php and mysql being out of date... because when I tried it on a server with php5 and mysql5 it worked fine... so we are going to update the server.. and if we still have problems i am going to post back.

thanks.
The present MOD has been developped and tested onto a localhost server running into a Win-XP based computer, to be accurate: easyphp1.8 has been used as the server (PHP and MySql versions are the ones built-in there). If by any chance you'll be able to post more details about the issue you above described it'll be nice.
Thanks
snip/except that we are getting stack overflow errors when we try to quote SOME of the posts on our board./snip
Okay, got it.. but wich ones especially? How long/heavy they are? Any further detail on this? .. Since I'm just trying to focus that stuff I have to tell you that a simple stack_overflow general error can't help me to help you.
Greets.
Last edited by 3Di on Sun Oct 28, 2007 5:10 pm, edited 1 time in total.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

dvdd127
Registered User
Posts: 402
Joined: Fri Jan 13, 2006 12:35 am
Location: Chicago, IL

Re: This is Only One Quote

Post by dvdd127 » Sun Oct 28, 2007 5:09 pm

most of the problem posts are only two deep.... so something like this..

Code: Select all

[quote]someone posted something[/quote]another person replied to the post.
when we try to quote this we get the error and it doesnt even bring us to the posting page.

Remember though.. it is NOT even ALL posts like this that it happens with.. only SOME of them..
/DD

User avatar
3Di
Former Team Member
Posts: 14053
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: This is Only One Quote

Post by 3Di » Sun Oct 28, 2007 5:18 pm

dvdd127 wrote:most of the problem posts are only two deep.... so something like this..

Code: Select all

[quote]someone posted something[/quote]another person replied to the post.
when we try to quote this we get the error and it doesnt even bring us to the posting page.
Well, I edited the above post of mine just while you're posting this last, and.. I see.

This kind of error I'm not able to reproduce it and also I wasn't into the RC's tests. When you say 'we'.. what do you really mean? You admin/moderators or what?
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

dvdd127
Registered User
Posts: 402
Joined: Fri Jan 13, 2006 12:35 am
Location: Chicago, IL

Re: This is Only One Quote

Post by dvdd127 » Sun Oct 28, 2007 5:33 pm

3Di wrote:
dvdd127 wrote:most of the problem posts are only two deep.... so something like this..

Code: Select all

[quote]someone posted something[/quote]another person replied to the post.
when we try to quote this we get the error and it doesnt even bring us to the posting page.
Well, I edited the above post of mine just while you're posting this last, and.. I see.

This kind of error I'm not able to reproduce it and also I wasn't into the RC's tests. When you say 'we'.. what do you really mean? You admin/moderators or what?
When I say we... i mean myself and all the users on my board..... admins, mods, regular users.. it doesnt matter.
/DD

dvdd127
Registered User
Posts: 402
Joined: Fri Jan 13, 2006 12:35 am
Location: Chicago, IL

Re: This is Only One Quote

Post by dvdd127 » Sun Oct 28, 2007 5:34 pm

BTW, I also edited my last post.
/DD

User avatar
3Di
Former Team Member
Posts: 14053
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: This is Only One Quote

Post by 3Di » Sun Oct 28, 2007 5:43 pm

dvdd127 wrote:BTW, I also edited my last post.
Yes, with this:
dvdd127 wrote:Remember though.. it is NOT even ALL posts like this that it happens with.. only SOME of them..
Very well, I'm so bound to state this as 'unreproduceable' for the moment. ;) Status will change if news will arrive.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

dvdd127
Registered User
Posts: 402
Joined: Fri Jan 13, 2006 12:35 am
Location: Chicago, IL

Re: This is Only One Quote

Post by dvdd127 » Sun Oct 28, 2007 5:56 pm

3Di wrote:
dvdd127 wrote:BTW, I also edited my last post.
Yes, with this:
dvdd127 wrote:Remember though.. it is NOT even ALL posts like this that it happens with.. only SOME of them..
Very well, I'm so bound to state this as 'unreproduceable' for the moment. ;) Status will change if news will arrive.
i understand it is unreproduceable... which is why I think it is because the versions of php and mysql are both out of date by over two years. and have made plans to move the site to a new server... if that doesnt fix the problem. I will try to get more information for you. We would be moving the site though until the end of nov. so please give me some time to get you more information.
/DD

User avatar
3Di
Former Team Member
Posts: 14053
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: This is Only One Quote

Post by 3Di » Sun Oct 28, 2007 11:59 pm

dvdd127 wrote:so please give me some time to get you more information.
No probs, there we'll go.. ;)
Regards.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

Lusch
Registered User
Posts: 10
Joined: Thu Mar 06, 2008 8:14 pm

Re: This is Only One Quote

Post by Lusch » Sat Mar 15, 2008 11:22 pm

I installed this mod, but had some issues:
- The regex doesn't match normal quotes (without a username)
- multiple quotes in a message didn't all match the regex
- sometimes the entire $message string matched the regex, so it displayed the 'no last quote' message

I changed the regex line in posting.php and privmsgs.php from

Code: Select all

/(\[quote=(.*?)\]((.|\n)*)\[\/quote\])/si'
to

Code: Select all

/\[quote(.*?)\](.*?)\[\/quote\]/si
This works everytime!

Also, I added a trim() to the message afterwards, so that there are no spaces or newlines after `[quote="Nickname"]` or before `[/ quote]`

User avatar
3Di
Former Team Member
Posts: 14053
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: This is Only One Quote

Post by 3Di » Mon Mar 17, 2008 1:22 pm

The new version it is on his way at the present time. ;)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

Peter77sx
Registered User
Posts: 3253
Joined: Wed Nov 09, 2005 2:51 pm

Re: This is Only One Quote

Post by Peter77sx » Mon Mar 24, 2008 11:34 pm

3Di wrote:The new version it is on his way at the present time. ;)
Updating easy? I need this yesterday. :lol:

User avatar
3Di
Former Team Member
Posts: 14053
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: This is Only One Quote

Post by 3Di » Tue Mar 25, 2008 4:51 pm

Peter77sx wrote:
3Di wrote:The new version it is on his way at the present time. ;)
Updating easy? I need this yesterday. :lol:
Tomorrow will be a new day. :lol: :ugeek:
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

Post Reply

Return to β€œ[2.0.x] MOD Database Releases”