[Tool] phpBB 2.0.17 to phpBB 2.0.18 Code Changes

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in here. No new MODs will be accepted into the MOD Database for phpBB2
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Post Reply

Rating:

Excellent!
13
52%
Very Good
6
24%
Good
2
8%
Fair
1
4%
Poor
3
12%
 
Total votes: 25

User avatar
MHobbit
Former Team Member
Posts: 4761
Joined: Thu Mar 18, 2004 5:32 pm
Location: There and Back Again

Post by MHobbit » Wed Nov 16, 2005 9:08 pm

ikhonlord: I don't think mailto in [url] was ever allowed... try [email].

Code: Select all

[email]test@test.com[/email]
yields

test@test.com

.

Besides, if you type in the email address by itself without any BBCode tags surrounding it, phpBB should parse it automatically.

Canadian Pyscho: That probably means you've modified that template file beforehand, probably due to a MOD. The best thing to do in this case is to find the template change in this MOD install script, and apply it manually, finding the line most similar to the target line(s).

IOW, EasyMOD can't find that line because you modified it, so that the template file is no longer like a standard, vanilla phpBB template file.
Last edited by MHobbit on Wed Nov 16, 2005 9:29 pm, edited 1 time in total.
Former phpBB MOD Team member
No private support is offered.
"There’s too many things to get done, and I’m running out of days..."

mickal555
Registered User
Posts: 102
Joined: Sat Apr 09, 2005 4:52 am
Contact:

Post by mickal555 » Wed Nov 16, 2005 9:24 pm

mickal555 wrote:
mickal555 wrote:
MennoniteHobbit wrote: mickal555: Well, it seems you installed a MOD that conflicted... in your case, your best bet is to uninstall the MOD that made that change in includes/sessions.php.

I would have no idea what MOD did that...

damn

it's a "repace with" command too...

Just had a look
Here is what is there instead...

Looks the same...
//
// Delete expired sessions
//
$expiry_time = $current_time - $board_config['session_length'];

$sql = "DELETE FROM " . SESSIONS_TABLE . "
WHERE UNIX_TIMESTAMP() - session_time >=172800
AND session_id <> '$session_id'";
if ( !$db->sql_query($sql) )
{
message_die(CRITICAL_ERROR, 'Error clearing sessions table', '', __LINE__, __FILE__, $sql);
}

setcookie($cookiename . '_data', serialize($sessiondata), $current_time + 31536000, $cookiepath, $cookiedomain, $cookiesecure);
setcookie($cookiename . '_sid', $session_id, 0, $cookiepath, $cookiedomain, $cookiesecure);
}

return $userdata;
}
}
}


:?

Does anyone have any reccomendations on what I should do?

thanks,
Mickal

Please?
If this writing is blue you're going too fast!
Element CollectionsNewest additions: Bismuth and bismuth crystal making
My Forum!

NightriderXP
Registered User
Posts: 1418
Joined: Sat Oct 09, 2004 8:17 am
Location: Florida, US
Contact:

Post by NightriderXP » Wed Nov 16, 2005 9:30 pm

Did you keep all of the MODs that you have installed? If so, you can search on some key words from the script that is missing in your code and you should be able to find the MOD that changed it. You might consider uninstalling that MOD if it isn't really important or better yet, I bet this problem has surfaced in its discussion, along with a workaround...

Image

ikhonlord
Registered User
Posts: 33
Joined: Wed Jul 06, 2005 4:52 am
Contact:

Post by ikhonlord » Wed Nov 16, 2005 9:41 pm

MennoniteHobbit wrote: ikhonlord: I don't think mailto in was ever allowed... try [email]. [cod ... McCoy.com

That is what my user has in her sig, but if I click on it, or look at the link property it says this:

mailto:http://www.chloe-mccoy.com/

Any idea why?? it almost looks like its replacing the existing BBCode with a random one...

User avatar
MHobbit
Former Team Member
Posts: 4761
Joined: Thu Mar 18, 2004 5:32 pm
Location: There and Back Again

Post by MHobbit » Wed Nov 16, 2005 10:38 pm

ikhonlord: Sounds very odd... it's probably the result of some incorrect file editing. Also, make sure you don't have any MODs installed that'd do that, or anything similar (purposely or not). 2.0.18 itself would not cause that...
Former phpBB MOD Team member
No private support is offered.
"There’s too many things to get done, and I’m running out of days..."

ikhonlord
Registered User
Posts: 33
Joined: Wed Jul 06, 2005 4:52 am
Contact:

Post by ikhonlord » Wed Nov 16, 2005 11:16 pm

MennoniteHobbit wrote: ikhonlord: Sounds very odd... it's probably the result of some incorrect file editing. Also, make sure you don't have any MODs installed that'd do that, or anything similar (purposely or not). 2.0.18 itself would not cause that...


Thank you for your response! I will try to roll back to .17 and see if that does the trick, if it does I will try .18 again and see what is going on.

Is there somenthing i should be aware of when it comes to rolling back from 17 to 18? It should be as simple as taking my back up files and replacing what is on the server right?

Once again thank you for your help!

ivyivy
Registered User
Posts: 30
Joined: Sun Nov 21, 2004 8:44 pm

Post by ivyivy » Wed Nov 16, 2005 11:46 pm

ivyivy wrote: I need help with admin_smilies.php

The same instructions was written twice. Is there a mistake there?

If we have to do the same thing twice, then

1. there is only one "$smile_url = ( isset" line. So I can't do it twice
2. there are 3 "message_die(MESSAGE" line. (one in smile_url and two in cat_des). do we have to change them all? or like I said before is there a mistake and it is written twice.

thanks


any help on this subject?

User avatar
MHobbit
Former Team Member
Posts: 4761
Joined: Thu Mar 18, 2004 5:32 pm
Location: There and Back Again

Post by MHobbit » Thu Nov 17, 2005 12:33 am

ikhonlord wrote: Thank you for your response! I will try to roll back to .17 and see if that does the trick, if it does I will try .18 again and see what is going on.

Is there somenthing i should be aware of when it comes to rolling back from 17 to 18? It should be as simple as taking my back up files and replacing what is on the server right?

Once again thank you for your help!


Rolling back was not my suggestion... my last sentence stated that this 2.0.18 update would not cause your problems itself, if applied properly. As I said before, check to see if any other MODs require modifications to the same code segment...
Former phpBB MOD Team member
No private support is offered.
"There’s too many things to get done, and I’m running out of days..."

ikhonlord
Registered User
Posts: 33
Joined: Wed Jul 06, 2005 4:52 am
Contact:

Post by ikhonlord » Thu Nov 17, 2005 8:55 pm

I got it fixed...the BBCode file for some reason was messed up...got an old BBcode file I had as a back up and replaced it..and it worked!

Thank you for your help!

Blankety Blank Man
Registered User
Posts: 881
Joined: Wed Mar 30, 2005 3:54 am

Post by Blankety Blank Man » Fri Nov 18, 2005 12:18 am

This section of the update isn't doing what it should:

Code: Select all

#
#
# NOTE --- The following action adds the ability to show the 'Mark forums read' link to logged in users only.
#
#-----[ FIND ]---------------------------------------------
#
	<td align="left"><span class="gensmall"><a href="{U_MARK_READ}" class="gensmall">{L_MARK_FORUMS_READ}</a></span></td>

#
#-----[ REPLACE WITH ]---------------------------------------------
#
 	<td align="left">
 	<!-- BEGIN switch_user_logged_in -->
 		<span class="gensmall"><a href="{U_MARK_READ}" class="gensmall">{L_MARK_FORUMS_READ}</a></span>
 	<!-- END switch_user_logged_in -->
 	</td>
In my style, this is my code:

Code: Select all

   <!-- BEGIN catrow -->
   <tr>
      <td class="bold catLeft" colspan="2" align="center">
         <span class="bold cattitle">
            <a href="{catrow.U_VIEWCAT}">{catrow.CAT_DESC}</a>
         </span>
      </td>
      <td class="rowpic" colspan="3" align="center">
         <!-- BEGIN switch_user_logged_in -->
         <span class="small">
            <a href="{U_MARK_READ}">{L_MARK_FORUMS_READ}</a>
         </span>
         <!-- END switch_user_logged_in -->
      </td>
   </tr>
   <!-- BEGIN forumrow -->
Yet whether I'm logged in or not, the mark all forums read link doesn't appear.
Predictably, removing the switch makes it visible whne logged in or out.

Other sections of code within the same switch work properly, but for some reason they don't work there. Could it be due to the fact that it is within the catrow loop? But catrow.switch_user_logged_in caused an eval failure in template.php...
I'm confused... >,<

wickedintense
Registered User
Posts: 52
Joined: Mon Oct 25, 2004 2:42 am

Post by wickedintense » Fri Nov 18, 2005 3:33 am

?

I am in the process of doing the mod manually, never had much luck with ez mod and i am at the posting.php at this section
#-----[ FIND ]---------------------------------------------
# NOTE --- This is a partial match, the whole line on a fresh installation looks like this:
# $select_sql = ( !$submit ) ? ", t.topic_title, p.enable_bbcode, p.enable_html, p.enable_smilies, p.enable_sig, p.post_username, pt.post_subject, pt.post_text, pt.bbcode_uid, u.username, u.user_id, u.user_sig" : '';
#
$select_sql = ( !$submit ) ? "

#
#-----[ IN-LINE FIND ]---------------------------------------------
#
( !$submit ) ? "


then
#-----[ IN-LINE REPLACE WITH ]---------------------------------------------
#
(!$submit) ? '


should i replace both ( !$submit ) ? " with (!$submit) ? ' or just the first or just the second?


and also in groupcp.php there is a part that says
#-----[ FIND ]---------------------------------------------
#
//
// Load and process templates
//

#
#-----[ AFTER, ADD ]---------------------------------------------
#
$page_title = $lang['Group_Control_Panel'];


I already have this line in after that "find"
$page_title = $lang['Group_Control_Panel'];


I assume i shouldn't add it again which would repeat the same line.. is that correct?[/quote]

if i did it would look like this

$page_title = $lang['Group_Control_Panel'];
$page_title = $lang['Group_Control_Panel'];

MALdito
Registered User
Posts: 54
Joined: Mon Aug 18, 2003 11:12 pm
Contact:

Post by MALdito » Fri Nov 18, 2005 4:42 am

First of all, THANKS markus_petrux!!
That being said, don´t run this mod with EM if you have one of the following:

1- Users Online Today by rhs98, specifically the sessios.php file.
http://www.phpbb.com/phpBB/viewtopic.php?t=253650
older versiosn. (see my post at the end)

2- Search Engine Optimization by Craven de Kere, also with the sessions.php file.
http://www.phpbb.com/phpBB/viewtopic.php?t=152036

I had to uninstall those. Then, just to make sure, I coded everything by hand.

Then, I ran into some problems with the common.php file:

Fatal error: Call to a member function on a non-object in /path/to/public_html/foros/common.php on line 212

I made a post about it:
http://www.phpbb.com/phpBB/viewtopic.php?t=342318

MALdito
Registered User
Posts: 54
Joined: Mon Aug 18, 2003 11:12 pm
Contact:

Post by MALdito » Fri Nov 18, 2005 7:04 pm

Be carefull with this one (in posting.php)

http://www.phpbb.com/phpBB/viewtopic.ph ... 16#1846516
Webmasterks wrote: No, I've found the problem and corrected it. It works fine now. It's in the MOD. It shouldn't be:

Code: Select all

#-----[ FIND ]---------------------------------------------
# NOTE --- This is a partial match, the whole line on a fresh installation looks like this:
#		$user_sig = ( $post_info['user_sig'] != '' && $board_config['allow_sig'] ) ? $post_info['user_sig'] : '';
#
		$user_sig = ( $post_info['user_sig'] != ''

#
#-----[ AFTER, ADD ]---------------------------------------------
#
		$userdata['user_sig_bbcode_uid'] = $post_info['user_sig_bbcode_uid'];
but

Code: Select all

#-----[ FIND ]---------------------------------------------
#
#		$user_sig = ( $post_info['user_sig'] != '' && $board_config['allow_sig'] ) ? $post_info['user_sig'] : '';
#

#
#-----[ AFTER, ADD ]---------------------------------------------
#
		$userdata['user_sig_bbcode_uid'] = $post_info['user_sig_bbcode_uid'];
...otherwise the added code would be in the middle of the found line, which causes the parse error.

markus_petrux
Former Team Member
Posts: 1887
Joined: Wed Apr 23, 2003 7:11 am
Location: Girona, Catalunya (Spain)
Contact:

Post by markus_petrux » Fri Nov 18, 2005 7:42 pm

Be aware, the code changes MOD is correct!

What's wrong is Webmasterks' interpretation! That MOD action is NOT an IN-LINE action, therefore the code should be added just after the line found by previous FIND, which happens to be a partial match, to avoid conflicts if another MOD modified part of that line.


Please, consult the MOD Template Actions article in the KB for further information.
EasyMOD Standards | MOD Template Actions | MODs in Development Rules
Useful information for MOD Authors | MOD Queue Stats | Search MODs
Write SQL/DDL portable to all SQL servers supported by phpBB!
Get EasyMOD 0.3.0! | Suport al phpBB en Català!
8)

rr2000
Registered User
Posts: 39
Joined: Fri Oct 03, 2003 10:52 am

Post by rr2000 » Sat Nov 19, 2005 5:33 am

To those who are planning to EasyMOD this mod, PLEASE STAY AWAY...! Especially so if you have mod-ed/customized your scripts.. I had enough trouble already, and restored scripts to 2.0.17 version. Better wait the dust to settle down, there are just too many files that are touched in this mod.

Will the mod author add a warning to the first post for people having EasyMod 0.2 ..? That would've helped me save a lot of time.. :(

Post Reply

Return to “[2.0.x] MOD Database Releases”