[Tool] phpBB 2.0.18 to 2.0.19 Code Changes

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in here. No new MODs will be accepted into the MOD Database for phpBB2
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Post Reply

Rating:

Excellent!
21
75%
Very Good
4
14%
Good
0
No votes
Fair
1
4%
Poor
2
7%
 
Total votes: 28

Extensions Robot
Extensions Robot
Extensions Robot
Posts: 27977
Joined: Sat Aug 16, 2003 7:36 am

[Tool] phpBB 2.0.18 to 2.0.19 Code Changes

Post by Extensions Robot » Fri Dec 30, 2005 1:18 pm

MOD Name: phpBB 2.0.18 to 2.0.19 Code Changes
Author: Acyd Burn
MOD Description: Code Changes from phpBB 2.0.18 to 2.0.19 in three formats (text/mod, html, bbcode prepared for posting the changes on phpBB forums).


MOD Version: 1.0.0

Download File: phpBB-2.0.19-codechanges.zip
mods overview page: View
File Size: 25656 Bytes

Security Score: 0

Support for this MOD needs to be asked within this topic. The phpBB Teams are not responsible or required to give anyone support for this MOD. By installing this MOD, the phpBB Support Team or phpBB MODifications Team may not be able to provide support.

This MOD has only been tested by the phpBB MOD Team with the phpBB version in the topic title. It may not work in any other versions of phpBB.
Last edited by Extensions Robot on Mon Apr 30, 2007 12:27 am, edited 1 time in total.
(this is a non-active account manager for the phpBB Extension Customisations Team)

wGEric
Former Team Member
Posts: 8805
Joined: Sun Oct 13, 2002 3:01 am
Location: Friday
Name: Eric Faerber
Contact:

Post by wGEric » Fri Dec 30, 2005 2:51 pm

MOD Validated/Released

Notes:
Ues these instructions to update your board to 2.0.19 if it is heavily modified. Make sure you run install/update_to_lastest.php after making the code changes.
Eric

in-toxic-ated
Registered User
Posts: 16
Joined: Thu May 12, 2005 7:05 pm

Post by in-toxic-ated » Fri Dec 30, 2005 4:14 pm

went just fine using easymod after changing the instaltxt due to changes concerning previous mods (custom ranks being one of them)
Last edited by in-toxic-ated on Fri Dec 30, 2005 4:30 pm, edited 1 time in total.

ViPeR5000
Registered User
Posts: 34
Joined: Sat Dec 13, 2003 7:44 am
Location: Portugal
Contact:

Post by ViPeR5000 » Fri Dec 30, 2005 4:27 pm

in-toxic-ated wrote: went just fine using easymod after changing the instaltxt due to changes concerning previous mods (custom ranks being one of them)


its dont work using easymod !

User avatar
UseLess
Registered User
Posts: 521
Joined: Mon Jul 22, 2002 7:26 pm
Location: North East UK

Post by UseLess » Fri Dec 30, 2005 5:56 pm

Greetings,

Line 346 in the 'phpbb_2.0.18_to_2.0.19.txt' file

Code: Select all

message_die(GENERAL_MESSAGE, 'Please_remove_install_contrib');
should be;

Code: Select all

message_die(GENERAL_MESSAGE, $lang['Please_remove_install_contrib']);
Last edited by UseLess on Fri Dec 30, 2005 5:57 pm, edited 1 time in total.
Movie Quote:
It's not the years honey, it's the mileage...
phpBB 3 Mods @ phpBBStyles

User avatar
bonelifer
Community Team Member
Community Team Member
Posts: 3476
Joined: Wed Oct 27, 2004 11:35 pm
Name: William
Contact:

Post by bonelifer » Fri Dec 30, 2005 5:57 pm

There is one FIND that isn't optimized. In the mod file find includes/usercp_register.php.

FIND this:

Code: Select all

#
#-----[ FIND ]---------------------------------------------
# Line 110
	$strip_var_list = array('username' => 'username', 'email' => 'email', 'icq' => 'icq', 'aim' => 'aim', 'msn' => 'msn', 'yim' => 'yim', 'website' => 'website', 'location' => 'location', 'occupation' => 'occupation', 'interests' => 'interests');
	$strip_var_list['confirm_code'] = 'confirm_code';

#
#-----[ REPLACE WITH ]---------------------------------------------
# 
	$strip_var_list = array('email' => 'email', 'icq' => 'icq', 'aim' => 'aim', 'msn' => 'msn', 'yim' => 'yim', 'website' => 'website', 'location' => 'location', 'occupation' => 'occupation', 'interests' => 'interests', 'confirm_code' => 'confirm_code');
And REPLACE it with this:

Code: Select all

#
#-----[ FIND ]---------------------------------------------
# Line 110
	$strip_var_list = array(

#
#-----------[ IN-LINE FIND ]-------------------------------------------
#
'username' => 'username', '


#
#-----------[ IN-LINE REPLACE WITH ]-------------------------------------------
#
'

#
#-----------[ IN-LINE FIND ]-------------------------------------------
#
);

#
#-----------[ IN-LINE BEFORE, ADD ]-------------------------------------------
#
, 'confirm_code' => 'confirm_code'

#
#-----[ FIND ]---------------------------------------------
# Line 111
	$strip_var_list['confirm_code'] = 'confirm_code';

#
#-----[ REPLACE WITH ]---------------------------------------------
# 
Knowledge Base | phpBB Board Rules | Search Customisation Database
Image
Please don't contact me via PM or email for phpBB support .

phantomk
Registered User
Posts: 1039
Joined: Wed Apr 14, 2004 5:32 am
Location: Canada Eh?
Name: Daniel Lee
Contact:

Post by phantomk » Fri Dec 30, 2005 6:27 pm

UseLess wrote: Greetings,

Line 346 in the 'phpbb_2.0.18_to_2.0.19.txt' file

Code: Select all

message_die(GENERAL_MESSAGE, 'Please_remove_install_contrib');
should be;

Code: Select all

message_die(GENERAL_MESSAGE, $lang['Please_remove_install_contrib']);

No it is correct the way it is done ;) Check the function message_die :)

Manipe
Former Team Member
Posts: 1146
Joined: Thu Jul 22, 2004 6:30 pm
Location: Éire
Contact:

Post by Manipe » Fri Dec 30, 2005 6:37 pm

UseLess wrote: Greetings,

Line 346 in the 'phpbb_2.0.18_to_2.0.19.txt' file

Code: Select all

message_die(GENERAL_MESSAGE, 'Please_remove_install_contrib');
should be;

Code: Select all

message_die(GENERAL_MESSAGE, $lang['Please_remove_install_contrib']);
No, that's not a mistake.
If a string like that is given to message_die(), it looks to see if there is a $lang variable with that key, and if not outputs it to the browser. If there is a $lang variable there, it will output that.
My MODs: [ Topics a user has started ] , [ Profile views ] , [ Colour on poll results ] , [ Topic posters ] , [ Add number to PM ] , [ Default avatar ] , [ View category name ] , [ Null vote ] , [ Forum description in viewforum ] , [ Resync forum ids ] , [ View PM while replying ] , [ Quick poll insert ] , [ Limit login attempts ] , [ Track PMs ]

www.ManipeF1.com

4rum
Registered User
Posts: 60
Joined: Sun Jul 04, 2004 3:21 am

Post by 4rum » Fri Dec 30, 2005 7:10 pm

:? So is the MODification OK as it stands and do we disregard the posts by bonelifer and UseLess . :?

Can the MOD Team please clarify.

Spinebuster
Registered User
Posts: 197
Joined: Sat Nov 27, 2004 6:48 am
Location: IN
Contact:

Post by Spinebuster » Fri Dec 30, 2005 7:20 pm

The tabbed spacing is off in the html update file. :cry:

:lol:

phantomk
Registered User
Posts: 1039
Joined: Wed Apr 14, 2004 5:32 am
Location: Canada Eh?
Name: Daniel Lee
Contact:

Post by phantomk » Fri Dec 30, 2005 7:21 pm

Disregard them both. The post by UseLess was incorrect, the one posted by Bonelifer is just a "mod friendly" way of doing the update.

User avatar
bonelifer
Community Team Member
Community Team Member
Posts: 3476
Joined: Wed Oct 27, 2004 11:35 pm
Name: William
Contact:

Post by bonelifer » Fri Dec 30, 2005 7:37 pm

phantomk wrote: Disregard them both. The post by UseLess was incorrect, the one posted by Bonelifer is just a "mod friendly" way of doing the update.


It's true it is a "mod friendly" way of doing it. But remember the UPGRADE file path, especially the MOD version is intended for heavily moded boards as examplified in wGErics Validation post.
wGEric wrote: MOD Validated/Released

Notes:
Ues these instructions to update your board to 2.0.19 if it is heavily modified. Make sure you run install/update_to_lastest.php after making the code changes.


Also it would seem necessary to run the update_to_latest.php file first. I didn't and when I tried I was loged out and couldn't run it. I had restore the backup files and then run the SQL update file and use Easymod to remod the files again.
Knowledge Base | phpBB Board Rules | Search Customisation Database
Image
Please don't contact me via PM or email for phpBB support .

Spinebuster
Registered User
Posts: 197
Joined: Sat Nov 27, 2004 6:48 am
Location: IN
Contact:

Post by Spinebuster » Fri Dec 30, 2005 8:17 pm

In login.php,

Shouldnt this:

Code: Select all

if ($row['user_last_login_try'] && $board_config['login_reset_time'] && $board_config['max_login_attempts'] && 
					$row['user_last_login_try'] >= (time() - ($board_config['login_reset_time'] * 60)) && $row['user_login_tries'] >= $board_config['max_login_attempts'])
Be this:

Code: Select all

if ($row['user_last_login_try'] && $board_config['login_reset_time'] && $board_config['max_login_attempts'] && $row['user_last_login_try'] >= (time() - ($board_config['login_reset_time'] * 60)) && $row['user_login_tries'] >= $board_config['max_login_attempts'])

Wo1f
Registered User
Posts: 2039
Joined: Fri Jan 28, 2005 3:20 am

Post by Wo1f » Fri Dec 30, 2005 8:56 pm

And again... another flawless upgrade. Darn good batting average guys. Many thanks and a happy new year to everyone! 8)

Note: To Manipe - I installed your "limit_login_attempts_1.0.0.txt" which was excellent btw a while back, and has now become redundant. Correct? Please confirm for everyone's benefit, and if this is the case, it might be a good idea to mention it in the install package and remove it from the mod database, as I'm not sure if they can co-exist peacefully especially with different default values.

Regards,
Wolf

User avatar
bonelifer
Community Team Member
Community Team Member
Posts: 3476
Joined: Wed Oct 27, 2004 11:35 pm
Name: William
Contact:

Post by bonelifer » Fri Dec 30, 2005 9:02 pm

I know feature requests aren't taken for 2.0.xx but could a future enhancement to the login attempts log the IP so that only the hacker is penalized. It would be nice to set the time to 60 minutes. It really shouldn't penalize the actual user.
Knowledge Base | phpBB Board Rules | Search Customisation Database
Image
Please don't contact me via PM or email for phpBB support .

Post Reply

Return to “[2.0.x] MOD Database Releases”